From 0f8db9fa2891ce22ad0292bdfac07a3fe26ebb66 Mon Sep 17 00:00:00 2001 From: Jamie Liu Date: Fri, 20 Dec 2024 13:35:12 -0800 Subject: [PATCH] Deflake process_vm_read_write test. Passing an uninitialized iovec can cause process_vm_readv/writev to fail for reasons other than the intended one. PiperOrigin-RevId: 708414541 --- test/syscalls/linux/process_vm_read_write.cc | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/test/syscalls/linux/process_vm_read_write.cc b/test/syscalls/linux/process_vm_read_write.cc index 3d482a6e2..9cee80df5 100644 --- a/test/syscalls/linux/process_vm_read_write.cc +++ b/test/syscalls/linux/process_vm_read_write.cc @@ -350,11 +350,15 @@ TEST(ProcessVMInvalidTest, NULLRemoteIovec) { } TEST(ProcessVMInvalidTest, ProcessNoExist) { + std::string contents = "3263827"; struct iovec iov; + iov.iov_base = contents.data(); + iov.iov_len = contents.size(); + EXPECT_THAT(process_vm_readv(-1, &iov, 1, &iov, 1, 0), - SyscallFailsWithErrno(::testing::AnyOf(ESRCH, EFAULT))); + SyscallFailsWithErrno(ESRCH)); EXPECT_THAT(process_vm_writev(-1, &iov, 1, &iov, 1, 0), - SyscallFailsWithErrno(::testing::AnyOf(ESRCH, EFAULT))); + SyscallFailsWithErrno(ESRCH)); } TEST(ProcessVMInvalidTest, GreaterThanIOV_MAX) {