From 06670e5a9c2fb13a6f816a2ac34842e78e715dc2 Mon Sep 17 00:00:00 2001
From: Lucas Manning <lucasmanning@google.com>
Date: Wed, 25 Jan 2023 16:20:36 -0800
Subject: [PATCH] Deprecate the original FUSE testing framework.

The tests written for this testing framework are fragile and
difficult to maintain. Each time we add a new a new feature,
like permission checking with FUSE_ACCESS, we have to upgrade
each test with corresponding request and response RPCS at the
correct places.

The new FUSE testing frameworks works by adding usefusefs=True. No
extra work is needed.

PiperOrigin-RevId: 504689971
---
 test/fuse/BUILD     | 64 +++++++++++++++++++++++++++++++++++++++++++++
 test/fuse/README.md |  2 ++
 2 files changed, 66 insertions(+)

diff --git a/test/fuse/BUILD b/test/fuse/BUILD
index 851195413..484381a76 100644
--- a/test/fuse/BUILD
+++ b/test/fuse/BUILD
@@ -4,80 +4,144 @@ package(licenses = ["notice"])
 
 syscall_test(
     allow_native = False,
+    tags = [
+        "noguitar",
+        "notap",
+    ],
     test = "//test/fuse/linux:stat_test",
 )
 
 syscall_test(
     allow_native = False,
+    tags = [
+        "noguitar",
+        "notap",
+    ],
     test = "//test/fuse/linux:statfs_test",
 )
 
 syscall_test(
     allow_native = False,
+    tags = [
+        "noguitar",
+        "notap",
+    ],
     test = "//test/fuse/linux:open_test",
 )
 
 syscall_test(
     allow_native = False,
+    tags = [
+        "noguitar",
+        "notap",
+    ],
     test = "//test/fuse/linux:release_test",
 )
 
 syscall_test(
     allow_native = False,
+    tags = [
+        "noguitar",
+        "notap",
+    ],
     test = "//test/fuse/linux:mknod_test",
 )
 
 syscall_test(
     allow_native = False,
+    tags = [
+        "noguitar",
+        "notap",
+    ],
     test = "//test/fuse/linux:symlink_test",
 )
 
 syscall_test(
     allow_native = False,
+    tags = [
+        "noguitar",
+        "notap",
+    ],
     test = "//test/fuse/linux:readlink_test",
 )
 
 syscall_test(
     allow_native = False,
+    tags = [
+        "noguitar",
+        "notap",
+    ],
     test = "//test/fuse/linux:mkdir_test",
 )
 
 syscall_test(
     allow_native = False,
+    tags = [
+        "noguitar",
+        "notap",
+    ],
     test = "//test/fuse/linux:read_test",
 )
 
 syscall_test(
     allow_native = False,
+    tags = [
+        "noguitar",
+        "notap",
+    ],
     test = "//test/fuse/linux:write_test",
 )
 
 syscall_test(
     allow_native = False,
+    tags = [
+        "noguitar",
+        "notap",
+    ],
     test = "//test/fuse/linux:rmdir_test",
 )
 
 syscall_test(
     allow_native = False,
+    tags = [
+        "noguitar",
+        "notap",
+    ],
     test = "//test/fuse/linux:readdir_test",
 )
 
 syscall_test(
     allow_native = False,
+    tags = [
+        "noguitar",
+        "notap",
+    ],
     test = "//test/fuse/linux:create_test",
 )
 
 syscall_test(
     allow_native = False,
+    tags = [
+        "noguitar",
+        "notap",
+    ],
     test = "//test/fuse/linux:unlink_test",
 )
 
 syscall_test(
     allow_native = False,
+    tags = [
+        "noguitar",
+        "notap",
+    ],
     test = "//test/fuse/linux:setstat_test",
 )
 
 syscall_test(
     allow_native = False,
+    tags = [
+        "noguitar",
+        "notap",
+    ],
     test = "//test/fuse/linux:mount_test",
 )
diff --git a/test/fuse/README.md b/test/fuse/README.md
index 7a960ff18..6b8519513 100644
--- a/test/fuse/README.md
+++ b/test/fuse/README.md
@@ -1,5 +1,7 @@
 # gVisor FUSE Test Suite
 
+## This test framework is deprecated. Please use the `usefusefs=True` in syscall tests to test FUSE going forward.
+
 This is an integration test suite for fuse(4) filesystem. It runs under gVisor
 sandbox container with FUSE function enabled.