From 05335ebd62d166ff63f61a9065d4e9ca3361e8fc Mon Sep 17 00:00:00 2001 From: Kevin Krakauer Date: Fri, 26 Apr 2024 16:42:38 -0700 Subject: [PATCH] netstack: update tcp_benchmark flag to match that RACK is enabled by default PiperOrigin-RevId: 628542796 --- test/benchmarks/tcp/tcp_proxy.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/test/benchmarks/tcp/tcp_proxy.go b/test/benchmarks/tcp/tcp_proxy.go index 06aba544d..47a4ec9fc 100644 --- a/test/benchmarks/tcp/tcp_proxy.go +++ b/test/benchmarks/tcp/tcp_proxy.go @@ -59,7 +59,7 @@ var ( mask = flag.Int("mask", 8, "mask size for address") iface = flag.String("iface", "", "network interface name to bind for netstack") sack = flag.Bool("sack", false, "enable SACK support for netstack") - rack = flag.Bool("rack", false, "enable RACK in TCP") + rack = flag.Bool("rack", true, "enable RACK in TCP") moderateRecvBuf = flag.Bool("moderate_recv_buf", true, "enable TCP Receive Buffer Auto-tuning") cubic = flag.Bool("cubic", false, "enable use of CUBIC congestion control for netstack") gso = flag.Int("gso", 0, "GSO maximum size") @@ -289,10 +289,11 @@ func newNetstackImpl(mode string) (impl, error) { } } - if *rack { - opt := tcpip.TCPRecovery(tcpip.TCPRACKLossDetection) + // RACK is enabled by default in netstack. + if !*rack { + opt := tcpip.TCPRecovery(0) if err := s.SetTransportProtocolOption(tcp.ProtocolNumber, &opt); err != nil { - return nil, fmt.Errorf("enabling RACK failed: %v", err) + return nil, fmt.Errorf("disabling RACK failed: %v", err) } }