mirror of
https://github.com/netbirdio/gomobile-tvos-fork.git
synced 2026-05-22 18:43:29 -07:00
bind,cmd,internal: generate reverse bindings for exported Go structs
Before this CL, the type of the implicit "this" parameter to Java methods
implemented in Go could only be a super class of the generated Java
class. For example, the following GoRunnable type is an implementation of
the Java interface java.lang.Runnable with a toString method:
package somepkg
import "Java/java/lang"
type GoRunnable struct {
lang.Runnable
}
func (r *GoRunnable) ToString(this lang.Runnable) string {
...
}
The "this" parameter is implicit in the sense that the reverse generator
automatically fills it with a reference to the Java instance of
GoRunnable.
Note that "this" has the type Java/java/lang.Runnable, not
Java/go/somepkg.GoRunnable, which renders it impossible to call Java
methods and functions that expect GoRunnable. The most practical example
of this is the Android databinding libraries.
This CL changes the implicit this parameter to always match the exact
type. In the example, the toString implementation becomes:
import gopkg "Java/go/somepkg"
func (r *GoRunnable) ToString(this gopkg.GoRunnable) string {
...
}
One strategy would be to simply treat the generated Java classes
(GoRunnable in our example) as any other Java class and import it
through javap. However, since the Java classes are generated after
importing, this present a chicken-and-egg problem.
Instead, use the newly added support for structs with embedded prefixed types
and synthesize class descriptors for every exported Go struct type.
Change-Id: Ic5ce4a151312bd89f91798ed4088c9959225b448
Reviewed-on: https://go-review.googlesource.com/34776
Reviewed-by: David Crawshaw <crawshaw@golang.org>
This commit is contained in:
Vendored
-16
@@ -41,14 +41,10 @@ jclass proxy_class_java_F;
|
||||
jmethodID proxy_class_java_F_cons;
|
||||
jclass proxy_class_java_O;
|
||||
jmethodID proxy_class_java_O_cons;
|
||||
// skipped method O.Super with unsupported parameter or return types
|
||||
|
||||
jclass proxy_class_java_R;
|
||||
jmethodID proxy_class_java_R_cons;
|
||||
jclass proxy_class_java_S;
|
||||
jmethodID proxy_class_java_S_cons;
|
||||
// skipped method S.Super with unsupported parameter or return types
|
||||
|
||||
|
||||
JNIEXPORT void JNICALL
|
||||
Java_go_java_Java__1init(JNIEnv *env, jclass _unused) {
|
||||
@@ -62,8 +58,6 @@ Java_go_java_Java__1init(JNIEnv *env, jclass _unused) {
|
||||
proxy_class_java_O = (*env)->NewGlobalRef(env, clazz);
|
||||
proxy_class_java_O_cons = (*env)->GetMethodID(env, clazz, "<init>", "(Lgo/Seq$Ref;)V");
|
||||
clazz = (*env)->FindClass(env, "go/java/O");
|
||||
// skipped method O.Super with unsupported parameter or return types
|
||||
|
||||
|
||||
clazz = (*env)->FindClass(env, "go/java/Java$proxyR");
|
||||
proxy_class_java_R = (*env)->NewGlobalRef(env, clazz);
|
||||
@@ -74,16 +68,6 @@ Java_go_java_Java__1init(JNIEnv *env, jclass _unused) {
|
||||
proxy_class_java_S = (*env)->NewGlobalRef(env, clazz);
|
||||
proxy_class_java_S_cons = (*env)->GetMethodID(env, clazz, "<init>", "(Lgo/Seq$Ref;)V");
|
||||
clazz = (*env)->FindClass(env, "go/java/S");
|
||||
// skipped method S.Super with unsupported parameter or return types
|
||||
|
||||
|
||||
}
|
||||
|
||||
// skipped function O.Super with unsupported parameter or return types
|
||||
|
||||
// skipped method O with unsupported parameter or return types
|
||||
|
||||
// skipped function S.Super with unsupported parameter or return types
|
||||
|
||||
// skipped method S with unsupported parameter or return types
|
||||
|
||||
|
||||
Reference in New Issue
Block a user