netbird/gomobile-tvos-fork
0
0
Fork 0
mirror of https://github.com/netbirdio/gomobile-tvos-fork.git synced 2026-05-22 18:43:29 -07:00
Code Issues Packages Projects Releases Wiki Activity

all: fix printf(var) mistakes detected by latest printf checker

Browse Source 
There's some similarity here to the situation in CL 610676. The calls
that now look like g.Printf("%s", something) would perhaps be better
expressed like g.Print(something) or g.WriteString(something), but
that's a bigger potential change to consider. This is a minimal fix.

For golang/go#69267.

Change-Id: I9cf23aef7bf2b9d9c7e9dcf3b48ecb23231016dd
Reviewed-on: https://go-review.googlesource.com/c/mobile/+/610800
Reviewed-by: Tim King <taking@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
This commit is contained in:
Dmitri Shuralyov
2024-09-05 00:41:12 +00:00
committed by Gopher Robot
parent 81131f6468
commit 7c4916698c
6 changed files with 22 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bind/genjava.go
+9 -9
View File
@@ -437,7 +437,7 @@ func (g *JavaGen) genConstructor(f *types.Func, n string, jcls bool) {
if i > 0 {
g.Printf(", ")
}
g.Printf(g.paramName(params, i))
g.Printf("%s", g.paramName(params, i))
}
g.Printf(");\n")
}
@@ -447,7 +447,7 @@ func (g *JavaGen) genConstructor(f *types.Func, n string, jcls bool) {
if i > 0 {
g.Printf(", ")
}
g.Printf(g.paramName(params, i))
g.Printf("%s", g.paramName(params, i))
}
g.Printf(");\n")
g.Printf("Seq.trackGoRef(refnum, this);\n")
@@ -757,21 +757,21 @@ func (g *JavaGen) genJNIFuncSignature(o *types.Func, sName string, jm *java.Func
g.Printf("Java_%s_", g.jniPkgName())
if sName != "" {
if proxy {
g.Printf(java.JNIMangle(g.className()))
g.Printf("%s", java.JNIMangle(g.className()))
// 0024 is the mangled form of $, for naming inner classes.
g.Printf("_00024proxy%s", sName)
} else {
g.Printf(java.JNIMangle(g.javaTypeName(sName)))
g.Printf("%s", java.JNIMangle(g.javaTypeName(sName)))
}
} else {
g.Printf(java.JNIMangle(g.className()))
g.Printf("%s", java.JNIMangle(g.className()))
}
g.Printf("_")
if jm != nil {
g.Printf(jm.JNIName)
g.Printf("%s", jm.JNIName)
} else {
oName := javaNameReplacer(lowerFirst(o.Name()))
g.Printf(java.JNIMangle(oName))
g.Printf("%s", java.JNIMangle(oName))
}
g.Printf("(JNIEnv* env, ")
if sName != "" {
@@ -839,9 +839,9 @@ func (g *JavaGen) genFuncSignature(o *types.Func, jm *java.Func, hasThis bool) {
g.Printf("%s ", ret)
if jm != nil {
g.Printf(jm.Name)
g.Printf("%s", jm.Name)
} else {
g.Printf(javaNameReplacer(lowerFirst(o.Name())))
g.Printf("%s", javaNameReplacer(lowerFirst(o.Name())))
}
g.Printf("(")
g.genFuncArgs(o, jm, hasThis)