netbird/gomobile-tvos-fork
0
0
Fork 0
mirror of https://github.com/netbirdio/gomobile-tvos-fork.git synced 2026-05-22 18:43:29 -07:00
Code Issues Packages Projects Releases Wiki Activity

bind: format generated go code before comparing with golden files

Browse Source 
bind_test.go compares the generated Go files against golden files
checked in the repository. The bind package formats some of the
generated Go files, so any changes in the go formatter can break
the tests.

This change makes the test more robust by applying formatting based
on the currently used go version. Since a golden file often
includes multiple go files generated by the bind, the `gofmt`
function splits the golden file using the gobindPreamble marker
and then run format.Source for each chunk. In order to ease the
golden file splitting, this CL also moves the gobindPreamble
to the beginning of each generated file consistently.

It turned out bind omits formatting for some go files (generated
for reverse binding). That needs to be fixed but it is a much
bigger fix. Thus, in this CL, we apply the formatting on the
bind's output as well.

This CL also updates the gobindPreamble to follow the style guide
for generated code. https://golang.org/s/generatedcode

Fixes golang/go#34619

Change-Id: Ia2957693154face2848e051ebbb2373e95d79593
Reviewed-on: https://go-review.googlesource.com/c/mobile/+/198322
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
This commit is contained in:
Hana Kim
2019-10-02 17:59:09 +00:00
committed by Hyang-Ah Hana Kim
parent d3ece3b6da
commit 6d0d39b2ca
73 changed files with 653 additions and 431 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bind/testdata/java.java.h.golden
Vendored
+5 -3
View File
@@ -1,4 +1,5 @@
// File is generated by gobind. Do not edit.
// Code generated by gobind. DO NOT EDIT.
#include <jni.h>
#include "seq.h"
@@ -49,10 +50,11 @@ typedef struct ret_nbyteslice {
extern ret_nstring cproxy_java_lang_Float_toString(jint this);
extern ret_nstring cproxy_java_lang_Long_toString(jint this);
extern ret_nstring cproxy_java_lang_Object_toString(jint this);
// Code generated by gobind. DO NOT EDIT.
// JNI function headers for the Go <=> Java bridge.
// gobind -lang=java java
//
// File is generated by gobind. Do not edit.
// autogenerated by gobind -lang=java java
#ifndef __Java_H__
#define __Java_H__