netbird/gomobile-tvos-fork
0
0
Fork 0
mirror of https://github.com/netbirdio/gomobile-tvos-fork.git synced 2026-05-22 18:43:29 -07:00
Code Issues Packages Projects Releases Wiki Activity

mobile/bind: don't force Java classes to extend stub classes

Browse Source 
Requiring user code to extend Go interface Stubs to be able to pass
Java objects to Go is clumsy and use up the single extend slot.
Instead, support (and enforce) java classes to implement translated
Go interface directly. This is similar to how ObjC works.

The stub classes are now gone, and users of gobind Java APIs need
to update their code to implement interfaces directly.

Change-Id: I880bb7c8e89d3c21210b2ab2c85ced8d7859ff48
Reviewed-on: https://go-review.googlesource.com/21313
Reviewed-by: David Crawshaw <crawshaw@golang.org>
This commit is contained in:
Elias Naur
2016-03-31 07:59:45 +00:00
parent 07a529f836
commit 5e11c20fc0
13 changed files with 151 additions and 337 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bind/java/SeqTest.java
+9 -9
View File
@@ -216,7 +216,7 @@ public class SeqTest extends InstrumentationTestCase {
assertEquals("S should be collected", 1, collected);
}
private class AnI extends Testpkg.I.Stub {
private class AnI implements Testpkg.I {
public void E() throws Exception {
throw new Exception("my exception from E");
}
@@ -355,7 +355,7 @@ public class SeqTest extends InstrumentationTestCase {
private int countI = 0;
private class CountI extends Testpkg.I.Stub {
private class CountI implements Testpkg.I {
public void F() { countI++; }
public void E() throws Exception {}
@@ -425,7 +425,7 @@ public class SeqTest extends InstrumentationTestCase {
//test if we have JNI local reference table overflow error
public void testLocalReferenceOverflow() {
Testpkg.CallWithCallback(new Testpkg.GoCallback.Stub() {
Testpkg.CallWithCallback(new Testpkg.GoCallback() {
@Override
public void VarUpdate() {
@@ -435,7 +435,7 @@ public class SeqTest extends InstrumentationTestCase {
}
public void testNullReferences() {
assertTrue(Testpkg.CallWithNull(null, new Testpkg.NullTest.Stub() {
assertTrue(Testpkg.CallWithNull(null, new Testpkg.NullTest() {
public Testpkg.NullTest Null() {
return null;
}
@@ -445,7 +445,7 @@ public class SeqTest extends InstrumentationTestCase {
}
public void testPassByteArray() {
Testpkg.PassByteArray(new Testpkg.B.Stub() {
Testpkg.PassByteArray(new Testpkg.B() {
@Override public void B(byte[] b) {
byte[] want = new byte[]{1, 2, 3, 4};
MoreAsserts.assertEquals("bytes should match", want, b);
@@ -468,14 +468,14 @@ public class SeqTest extends InstrumentationTestCase {
}
public void testGoroutineCallback() {
Testpkg.GoroutineCallback(new Testpkg.Receiver.Stub() {
Testpkg.GoroutineCallback(new Testpkg.Receiver() {
@Override public void Hello(String msg) {
}
});
}
public void testImportedPkg() {
Testpkg.CallImportedI(new Secondpkg.I.Stub() {
Testpkg.CallImportedI(new Secondpkg.I() {
@Override public long F(long i) {
return i;
}
@@ -505,13 +505,13 @@ public class SeqTest extends InstrumentationTestCase {
public void testRoundtripEquality() {
Testpkg.I want = new AnI();
assertTrue("java object passed through Go should not be wrapped", want == Testpkg.IDup(want));
Testpkg.InterfaceDupper idup = new Testpkg.InterfaceDupper.Stub(){
Testpkg.InterfaceDupper idup = new Testpkg.InterfaceDupper(){
@Override public Testpkg.Interface IDup(Testpkg.Interface i) {
return i;
}
};
assertTrue("Go interface passed through Java should not be wrapped", Testpkg.CallIDupper(idup));
Testpkg.ConcreteDupper cdup = new Testpkg.ConcreteDupper.Stub(){
Testpkg.ConcreteDupper cdup = new Testpkg.ConcreteDupper(){
@Override public Testpkg.Concrete CDup(Testpkg.Concrete c) {
return c;
}