From 64971c81265300fdc23a0c9555e323b28b99bb3c Mon Sep 17 00:00:00 2001 From: Aleksandr Petrukhin Date: Fri, 15 Jul 2016 17:46:25 +0300 Subject: [PATCH 1/9] Added decoder for slice in response --- gen/decoder.go | 49 +++++++++++++++++++++++++++++++++++++------------ 1 file changed, 37 insertions(+), 12 deletions(-) diff --git a/gen/decoder.go b/gen/decoder.go index a1291fc..e812567 100644 --- a/gen/decoder.go +++ b/gen/decoder.go @@ -13,7 +13,7 @@ import ( // Target this byte size for initial slice allocation to reduce garbage collection. const minSliceBytes = 64 -func (g *Generator) getStructDecoderName(t reflect.Type) string { +func (g *Generator) getDecoderName(t reflect.Type) string { return g.functionName("decode_", t) } @@ -47,7 +47,7 @@ var primitiveStringDecoders = map[reflect.Kind]string{ reflect.Uint64: "in.Uint64Str()", } -// genTypeDecoder generates decoding code for the type t. +// genTypeDecoderNoCheck generates decoding code for the type t, but checks t's unmarhaler. func (g *Generator) genTypeDecoder(t reflect.Type, out string, tags fieldTags, indent int) error { ws := strings.Repeat(" ", indent) @@ -65,6 +65,13 @@ func (g *Generator) genTypeDecoder(t reflect.Type, out string, tags fieldTags, i return nil } + err := g.genTypeDecoderNoCheck(t, out, tags, indent) + return err +} + +// genTypeDecoderNoCheck generates decoding code for the type t. +func (g *Generator) genTypeDecoderNoCheck(t reflect.Type, out string, tags fieldTags, indent int) error { + ws := strings.Repeat(" ", indent) // Check whether type is primitive, needs to be done after interface check. if dec := primitiveStringDecoders[t.Kind()]; dec != "" && tags.asString { fmt.Fprintln(g.out, ws+out+" = "+g.getType(t)+"("+dec+")") @@ -86,7 +93,7 @@ func (g *Generator) genTypeDecoder(t reflect.Type, out string, tags fieldTags, i fmt.Fprintln(g.out, ws+"in.Delim('[')") fmt.Fprintln(g.out, ws+"if !in.IsDelim(']') {") - fmt.Fprintln(g.out, ws+" "+out+" = make([]"+g.getType(elem)+", 0, "+fmt.Sprint(capacity)+")") + fmt.Fprintln(g.out, ws+" "+out+" = make("+g.getType(t)+", 0, "+fmt.Sprint(capacity)+")") fmt.Fprintln(g.out, ws+"} else {") fmt.Fprintln(g.out, ws+" "+out+" = nil") fmt.Fprintln(g.out, ws+"}") @@ -101,7 +108,7 @@ func (g *Generator) genTypeDecoder(t reflect.Type, out string, tags fieldTags, i fmt.Fprintln(g.out, ws+"in.Delim(']')") case reflect.Struct: - dec := g.getStructDecoderName(t) + dec := g.getDecoderName(t) g.addType(t) fmt.Fprintln(g.out, ws+dec+"(in, &"+out+")") @@ -130,7 +137,7 @@ func (g *Generator) genTypeDecoder(t reflect.Type, out string, tags fieldTags, i fmt.Fprintln(g.out, ws+"} else {") fmt.Fprintln(g.out, ws+" in.Delim('{')") fmt.Fprintln(g.out, ws+" if !in.IsDelim('}') {") - fmt.Fprintln(g.out, ws+" "+out+" = make(map["+g.getType(t.Key())+"]"+g.getType(t.Elem())+")") + fmt.Fprintln(g.out, ws+" "+out+" = make("+g.getType(t)+")") fmt.Fprintln(g.out, ws+" } else {") fmt.Fprintln(g.out, ws+" "+out+" = nil") fmt.Fprintln(g.out, ws+" }") @@ -260,12 +267,30 @@ func getStructFields(t reflect.Type) ([]reflect.StructField, error) { return mergeStructFields(efields, fields), nil } -func (g *Generator) genStructDecoder(t reflect.Type) error { - if t.Kind() != reflect.Struct { - return fmt.Errorf("cannot generate encoder/decoder for %v, not a struct type", t) +func (g *Generator) genSliceDecoder(t reflect.Type) error { + if t.Kind() != reflect.Slice { + return fmt.Errorf("cannot generate encoder/decoder for %v, not a slice type", t) } - fname := g.getStructDecoderName(t) + fname := g.getDecoderName(t) + typ := g.getType(t) + + fmt.Fprintln(g.out, "func "+fname+"(in *jlexer.Lexer, out *"+typ+") {") + err := g.genTypeDecoder(t, "out", fieldTags{}, 1) + if err != nil { + return err + } + fmt.Fprintln(g.out, "}") + + return nil +} + +func (g *Generator) genStructDecoder(t reflect.Type) error { + if t.Kind() != reflect.Struct { + return fmt.Errorf("cannot generate encoder/decoder for %v, not a struct type") + } + + fname := g.getDecoderName(t) typ := g.getType(t) fmt.Fprintln(g.out, "func "+fname+"(in *jlexer.Lexer, out *"+typ+") {") @@ -326,11 +351,11 @@ func (g *Generator) genStructDecoder(t reflect.Type) error { } func (g *Generator) genStructUnmarshaller(t reflect.Type) error { - if t.Kind() != reflect.Struct { - return fmt.Errorf("cannot generate encoder/decoder for %v, not a struct type", t) + if t.Kind() != reflect.Struct && t.Kind() != reflect.Slice { + return fmt.Errorf("cannot generate encoder/decoder for %v, not a struct/slice type", t) } - fname := g.getStructDecoderName(t) + fname := g.getDecoderName(t) typ := g.getType(t) if !g.noStdMarshalers { From 6f382c67e7508f0f384d667357f41cba1bbb857b Mon Sep 17 00:00:00 2001 From: Aleksandr Petrukhin Date: Fri, 15 Jul 2016 17:46:45 +0300 Subject: [PATCH 2/9] Added encoder for slice in response --- gen/encoder.go | 45 +++++++++++++++++++++++++++++++++++---------- 1 file changed, 35 insertions(+), 10 deletions(-) diff --git a/gen/encoder.go b/gen/encoder.go index c263c21..08b6ea2 100644 --- a/gen/encoder.go +++ b/gen/encoder.go @@ -10,7 +10,7 @@ import ( "github.com/mailru/easyjson" ) -func (g *Generator) getStructEncoderName(t reflect.Type) string { +func (g *Generator) getEncoderName(t reflect.Type) string { return g.functionName("encode_", t) } @@ -79,7 +79,7 @@ func parseFieldTags(f reflect.StructField) fieldTags { return ret } -// genTypeEncoder generates code that encodes in of type t into the writer. +// genTypeEncoder generates code that encodes in of type t into the writer, but checks t's marshaler. func (g *Generator) genTypeEncoder(t reflect.Type, in string, tags fieldTags, indent int) error { ws := strings.Repeat(" ", indent) @@ -95,6 +95,14 @@ func (g *Generator) genTypeEncoder(t reflect.Type, in string, tags fieldTags, in return nil } + err := g.genTypeEncoderNoCheck(t, in, tags, indent) + return err +} + +// genTypeEncoderNoCheck generates code that encodes in of type t into the writer. +func (g *Generator) genTypeEncoderNoCheck(t reflect.Type, in string, tags fieldTags, indent int) error { + ws := strings.Repeat(" ", indent) + // Check whether type is primitive, needs to be done after interface check. if enc := primitiveStringEncoders[t.Kind()]; enc != "" && tags.asString { fmt.Fprintf(g.out, ws+enc+"\n", in) @@ -122,7 +130,7 @@ func (g *Generator) genTypeEncoder(t reflect.Type, in string, tags fieldTags, in fmt.Fprintln(g.out, ws+"out.RawByte(']')") case reflect.Struct: - enc := g.getStructEncoderName(t) + enc := g.getEncoderName(t) g.addType(t) fmt.Fprintln(g.out, ws+enc+"(out, "+in+")") @@ -224,12 +232,29 @@ func (g *Generator) genStructFieldEncoder(t reflect.Type, f reflect.StructField) return nil } -func (g *Generator) genStructEncoder(t reflect.Type) error { - if t.Kind() != reflect.Struct { - return fmt.Errorf("cannot generate encoder/decoder for %v, not a struct type", t) +func (g *Generator) genSliceEncoder(t reflect.Type) error { + if t.Kind() != reflect.Slice { + return fmt.Errorf("cannot generate encoder/decoder for %v, not a slice type", t) } - fname := g.getStructEncoderName(t) + fname := g.getEncoderName(t) + typ := g.getType(t) + + fmt.Fprintln(g.out, "func "+fname+"(out *jwriter.Writer, in "+typ+") {") + err := g.genTypeEncoderNoCheck(t, "in", fieldTags{}, 1) + if err != nil { + return err + } + fmt.Fprintln(g.out, "}") + return nil +} + +func (g *Generator) genStructEncoder(t reflect.Type) error { + if t.Kind() != reflect.Struct { + return fmt.Errorf("cannot generate encoder/decoder for %v, not a struct type: type %v", t, t.Kind().String()) + } + + fname := g.getEncoderName(t) typ := g.getType(t) fmt.Fprintln(g.out, "func "+fname+"(out *jwriter.Writer, in "+typ+") {") @@ -254,11 +279,11 @@ func (g *Generator) genStructEncoder(t reflect.Type) error { } func (g *Generator) genStructMarshaller(t reflect.Type) error { - if t.Kind() != reflect.Struct { - return fmt.Errorf("cannot generate encoder/decoder for %v, not a struct type", t) + if t.Kind() != reflect.Struct && t.Kind() != reflect.Slice { + return fmt.Errorf("cannot generate encoder/decoder for %v, not a struct/slice type", t) } - fname := g.getStructEncoderName(t) + fname := g.getEncoderName(t) typ := g.getType(t) if !g.noStdMarshalers { From 66a279264f78b50e273c69f16db21ab815e70c7d Mon Sep 17 00:00:00 2001 From: Aleksandr Petrukhin Date: Fri, 15 Jul 2016 17:50:49 +0300 Subject: [PATCH 3/9] Fixed generator to generate slices without their type in response --- gen/generator.go | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/gen/generator.go b/gen/generator.go index 83bf812..e10a1c6 100644 --- a/gen/generator.go +++ b/gen/generator.go @@ -175,11 +175,21 @@ func (g *Generator) Run(out io.Writer) error { g.typesUnseen = g.typesUnseen[:len(g.typesUnseen)-1] g.typesSeen[t] = true - if err := g.genStructDecoder(t); err != nil { - return err - } - if err := g.genStructEncoder(t); err != nil { - return err + switch t.Kind() { + case reflect.Slice: + if err := g.genSliceDecoder(t); err != nil { + return err + } + if err := g.genSliceEncoder(t); err != nil { + return err + } + default: + if err := g.genStructDecoder(t); err != nil { + return err + } + if err := g.genStructEncoder(t); err != nil { + return err + } } if !g.marshallers[t] { From 8b05604eb93f5e6485ed29f519a16219331392b1 Mon Sep 17 00:00:00 2001 From: Aleksandr Petrukhin Date: Fri, 15 Jul 2016 18:21:20 +0300 Subject: [PATCH 4/9] Added tests for slice in response --- tests/data.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/data.go b/tests/data.go index 1378f89..6fb2a16 100644 --- a/tests/data.go +++ b/tests/data.go @@ -246,6 +246,8 @@ type Structs struct { AnonymousSlice []struct{ V int } AnonymousPtrSlice []*struct{ V int } + Slice []string + unexported bool } @@ -282,6 +284,8 @@ var structsValue = Structs{ AnonymousSlice: []struct{ V int }{{1}, {2}}, AnonymousPtrSlice: []*struct{ V int }{{3}, {4}}, + + Slice: []string{"test5", "test6"}, } var structsString = "{" + @@ -306,6 +310,8 @@ var structsString = "{" + `"AnonymousSlice":[{"V":1},{"V":2}],` + `"AnonymousPtrSlice":[{"V":3},{"V":4}],` + + `"Slice":["test5","test6"],` + + // Embedded fields go last. `"V":"subp",` + `"Value":"test"` + From 959def05220b13f02e77403c606e632585a33466 Mon Sep 17 00:00:00 2001 From: Aleksandr Petrukhin Date: Fri, 15 Jul 2016 19:50:44 +0300 Subject: [PATCH 5/9] Changed comment --- gen/encoder.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gen/encoder.go b/gen/encoder.go index 08b6ea2..e9d4e20 100644 --- a/gen/encoder.go +++ b/gen/encoder.go @@ -251,7 +251,7 @@ func (g *Generator) genSliceEncoder(t reflect.Type) error { func (g *Generator) genStructEncoder(t reflect.Type) error { if t.Kind() != reflect.Struct { - return fmt.Errorf("cannot generate encoder/decoder for %v, not a struct type: type %v", t, t.Kind().String()) + return fmt.Errorf("cannot generate encoder/decoder for %v, not a struct type") } fname := g.getEncoderName(t) From a777ea8b73be23bb8a87d7d9d59870a8400d6dcf Mon Sep 17 00:00:00 2001 From: Aleksandr Petrukhin Date: Mon, 18 Jul 2016 15:04:06 +0300 Subject: [PATCH 6/9] Minor fixes --- gen/decoder.go | 11 ++++++++++- gen/encoder.go | 9 +++++++++ gen/generator.go | 20 +++++--------------- 3 files changed, 24 insertions(+), 16 deletions(-) diff --git a/gen/decoder.go b/gen/decoder.go index e812567..2bc9f1f 100644 --- a/gen/decoder.go +++ b/gen/decoder.go @@ -267,6 +267,15 @@ func getStructFields(t reflect.Type) ([]reflect.StructField, error) { return mergeStructFields(efields, fields), nil } +func (g *Generator) genDecoder(t reflect.Type) error { + switch t.Kind() { + case reflect.Slice: + return g.genSliceDecoder(t) + default: + return g.genStructDecoder(t) + } +} + func (g *Generator) genSliceDecoder(t reflect.Type) error { if t.Kind() != reflect.Slice { return fmt.Errorf("cannot generate encoder/decoder for %v, not a slice type", t) @@ -287,7 +296,7 @@ func (g *Generator) genSliceDecoder(t reflect.Type) error { func (g *Generator) genStructDecoder(t reflect.Type) error { if t.Kind() != reflect.Struct { - return fmt.Errorf("cannot generate encoder/decoder for %v, not a struct type") + return fmt.Errorf("cannot generate encoder/decoder for %v, not a struct type", t) } fname := g.getDecoderName(t) diff --git a/gen/encoder.go b/gen/encoder.go index e9d4e20..19d7077 100644 --- a/gen/encoder.go +++ b/gen/encoder.go @@ -232,6 +232,15 @@ func (g *Generator) genStructFieldEncoder(t reflect.Type, f reflect.StructField) return nil } +func (g *Generator) genEncoder(t reflect.Type) error { + switch t.Kind() { + case reflect.Slice: + return g.genSliceEncoder(t) + default: + return g.genStructEncoder(t) + } +} + func (g *Generator) genSliceEncoder(t reflect.Type) error { if t.Kind() != reflect.Slice { return fmt.Errorf("cannot generate encoder/decoder for %v, not a slice type", t) diff --git a/gen/generator.go b/gen/generator.go index e10a1c6..fcf0dda 100644 --- a/gen/generator.go +++ b/gen/generator.go @@ -175,21 +175,11 @@ func (g *Generator) Run(out io.Writer) error { g.typesUnseen = g.typesUnseen[:len(g.typesUnseen)-1] g.typesSeen[t] = true - switch t.Kind() { - case reflect.Slice: - if err := g.genSliceDecoder(t); err != nil { - return err - } - if err := g.genSliceEncoder(t); err != nil { - return err - } - default: - if err := g.genStructDecoder(t); err != nil { - return err - } - if err := g.genStructEncoder(t); err != nil { - return err - } + if err := g.genDecoder(t); err != nil { + return err + } + if err := g.genEncoder(t); err != nil { + return err } if !g.marshallers[t] { From 97a4110e854d5f3c5d78fd62b8aab3478f63413b Mon Sep 17 00:00:00 2001 From: Aleksandr Petrukhin Date: Mon, 18 Jul 2016 15:58:29 +0300 Subject: [PATCH 7/9] Fixed comments --- gen/decoder.go | 2 +- gen/encoder.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gen/decoder.go b/gen/decoder.go index 2bc9f1f..fa70be1 100644 --- a/gen/decoder.go +++ b/gen/decoder.go @@ -47,7 +47,7 @@ var primitiveStringDecoders = map[reflect.Kind]string{ reflect.Uint64: "in.Uint64Str()", } -// genTypeDecoderNoCheck generates decoding code for the type t, but checks t's unmarhaler. +// genTypeDecoder generates decoding code for the type t, but uses unmarshaler interface if implemented by t. func (g *Generator) genTypeDecoder(t reflect.Type, out string, tags fieldTags, indent int) error { ws := strings.Repeat(" ", indent) diff --git a/gen/encoder.go b/gen/encoder.go index 19d7077..b6cdee6 100644 --- a/gen/encoder.go +++ b/gen/encoder.go @@ -79,7 +79,7 @@ func parseFieldTags(f reflect.StructField) fieldTags { return ret } -// genTypeEncoder generates code that encodes in of type t into the writer, but checks t's marshaler. +// genTypeEncoder generates code that encodes in of type t into the writer, but uses marshaler interface if implemented by t. func (g *Generator) genTypeEncoder(t reflect.Type, in string, tags fieldTags, indent int) error { ws := strings.Repeat(" ", indent) From 79b36b0b05c3e43bb3cb21e8207b1dd0bb526beb Mon Sep 17 00:00:00 2001 From: Aleksandr Petrukhin Date: Mon, 18 Jul 2016 16:20:51 +0300 Subject: [PATCH 8/9] Fixed generation of decoder --- gen/decoder.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gen/decoder.go b/gen/decoder.go index fa70be1..7080715 100644 --- a/gen/decoder.go +++ b/gen/decoder.go @@ -285,7 +285,7 @@ func (g *Generator) genSliceDecoder(t reflect.Type) error { typ := g.getType(t) fmt.Fprintln(g.out, "func "+fname+"(in *jlexer.Lexer, out *"+typ+") {") - err := g.genTypeDecoder(t, "out", fieldTags{}, 1) + err := g.genTypeDecoderNoCheck(t, "*out", fieldTags{}, 1) if err != nil { return err } From 7f82bd347ff745963d0379709ff88e5ff04db778 Mon Sep 17 00:00:00 2001 From: Aleksandr Petrukhin Date: Mon, 18 Jul 2016 16:21:03 +0300 Subject: [PATCH 9/9] Added test-case for slice marshalling --- tests/basic_test.go | 5 +++-- tests/data.go | 7 +++++++ 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/tests/basic_test.go b/tests/basic_test.go index 8525240..d2eac28 100644 --- a/tests/basic_test.go +++ b/tests/basic_test.go @@ -32,6 +32,7 @@ var testCases = []struct { {&excludedFieldValue, excludedFieldString}, {&mapsValue, mapsString}, {&deepNestValue, deepNestString}, + {&IntsValue, IntsString}, } func TestMarshal(t *testing.T) { @@ -107,7 +108,7 @@ func TestParseNull(t *testing.T) { var testSpecialCases = []struct { EncodedString string - Value string + Value string }{ {`"Username \u003cuser@example.com\u003e"`, `Username `}, {`"Username\ufffd"`, "Username\xc5"}, @@ -129,4 +130,4 @@ func TestSpecialCases(t *testing.T) { t.Errorf("[%d] Encoded() = %+v; want %+v", i, got, test.EncodedString) } } -} \ No newline at end of file +} diff --git a/tests/data.go b/tests/data.go index 6fb2a16..faa3093 100644 --- a/tests/data.go +++ b/tests/data.go @@ -532,6 +532,13 @@ var deepNestString = `{` + `"NamedStringSlice":["value4","value5"]` + `}` +//easyjson:json +type Ints []int + +var IntsValue = Ints{1, 2, 3, 4, 5} + +var IntsString = `[1,2,3,4,5]` + type RequiredOptionalStruct struct { FirstName string `json:"first_name,required"` Lastname string `json:"last_name"`