You've already forked ansible-netbird
mirror of
https://github.com/netbirdio/ansible-netbird.git
synced 2026-05-22 18:43:36 -07:00
Jack Carter
6f18e2cf5f
Code-review follow-up onbbea38e. Two small cleanups, no behavior change: - plugins/module_utils/netbird_api.py: revert update_nameserver_group's PUT-body construction for `domains` back to the partial-update pattern (`if domains is not None`) used by every other update_* method. The helper is now a pure HTTP primitive again, so future modules can rely on consistent partial-update semantics for this surface. - plugins/modules/netbird_dns.py: coerce `domains` and `groups` from None to [] at the module layer, right before building update_params and calling the API helper. This keeps the null-heal intent local to the DNS module (where the dashboard-crash reason lives) and applies symmetrically to both list fields, closing the asymmetry between nsgroup_needs_update (already symmetric) and the PUT body. Net effect is identical tobbea38e: installer-seeded `domains: null` still heals to `[]` on apply, the dashboard still loads, the sister repo's smoke/extended-CRUD assertions still pass. Only the layer at which the coercion lives has moved. Coexists cleanly with open PR #33 (fix/strict-name-resolution): both branches touch roles/configure/tasks/main.yml at non-overlapping hunks.