From 2e4efde08b624d03152d4b59f44449a5b7ee0627 Mon Sep 17 00:00:00 2001
From: Jack Carter <128555021+SunsetDrifter@users.noreply.github.com>
Date: Tue, 31 Mar 2026 11:59:11 +0200
Subject: [PATCH] fix: null guard sync_records() in netbird_dns_zone
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

list_dns_zone_records() returns null for zones with no records,
causing TypeError when iterating. Same pattern fixed in #20 for
other modules — this one was missed.
---
 plugins/modules/netbird_dns_zone.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plugins/modules/netbird_dns_zone.py b/plugins/modules/netbird_dns_zone.py
index 2391205..a1ba2e3 100644
--- a/plugins/modules/netbird_dns_zone.py
+++ b/plugins/modules/netbird_dns_zone.py
@@ -220,7 +220,7 @@ def sync_records(api, module, zone_id, desired_records):
 
     # Get current records
     current_records, _ = api.list_dns_zone_records(zone_id)
-    current_by_key = {get_record_key(r): r for r in current_records}
+    current_by_key = {get_record_key(r): r for r in (current_records or [])}
 
     # Build desired records map
     desired_by_key = {}