From e91c3399707638785850f03b3968fbd626f89bec Mon Sep 17 00:00:00 2001 From: "advisory-database[bot]" <45398580+advisory-database[bot]@users.noreply.github.com> Date: Thu, 1 May 2025 17:01:37 +0000 Subject: [PATCH] Publish Advisories GHSA-4pc9-x2fx-p7vj GHSA-7cp4-jw97-3rc2 GHSA-7cp4-jw97-3rc2 --- .../GHSA-4pc9-x2fx-p7vj.json | 65 +++++++++++++++++++ .../GHSA-7cp4-jw97-3rc2.json | 56 ++++++++++++++++ .../GHSA-7cp4-jw97-3rc2.json | 36 ---------- 3 files changed, 121 insertions(+), 36 deletions(-) create mode 100644 advisories/github-reviewed/2025/05/GHSA-4pc9-x2fx-p7vj/GHSA-4pc9-x2fx-p7vj.json create mode 100644 advisories/github-reviewed/2025/05/GHSA-7cp4-jw97-3rc2/GHSA-7cp4-jw97-3rc2.json delete mode 100644 advisories/unreviewed/2025/05/GHSA-7cp4-jw97-3rc2/GHSA-7cp4-jw97-3rc2.json diff --git a/advisories/github-reviewed/2025/05/GHSA-4pc9-x2fx-p7vj/GHSA-4pc9-x2fx-p7vj.json b/advisories/github-reviewed/2025/05/GHSA-4pc9-x2fx-p7vj/GHSA-4pc9-x2fx-p7vj.json new file mode 100644 index 00000000000..8ee74bfd867 --- /dev/null +++ b/advisories/github-reviewed/2025/05/GHSA-4pc9-x2fx-p7vj/GHSA-4pc9-x2fx-p7vj.json @@ -0,0 +1,65 @@ +{ + "schema_version": "1.4.0", + "id": "GHSA-4pc9-x2fx-p7vj", + "modified": "2025-05-01T17:00:29Z", + "published": "2025-05-01T17:00:29Z", + "aliases": [ + "CVE-2025-4143" + ], + "summary": "@cloudflare/workers-oauth-provider missing validation of redirect_uri on authorize endpoint", + "details": "### Summary\nPKCE was implemented in the OAuth implementation in workers-oauth-provider that is part of[ MCP framework](https://github.com/cloudflare/workers-mcp). However, it was found that an attacker could cause the check to be skipped.\n\n### Impact\nUnder certain circumstances (see below), if a victim had previously authorized with a server built on workers-oath-provider, and an attacker could later trick the victim into visiting a malicious web site, then attacker could potentially steal the victim's credentials to the same OAuth server and subsequently impersonate them.\n\nIn order for the attack to be possible, the OAuth server's authorized callback must be designed to auto-approve authorizations that appear to come from an OAuth client that the victim has authorized previously. The authorization flow is not implemented by workers-oauth-provider; it is up to the application built on top to decide whether to implement such automatic re-authorization. However, many applications do implement such logic.\n\n\n### Patches\nFixed in: https://github.com/cloudflare/workers-oauth-provider/pull/26\n\nWe patched up the vulnerabilities in the latest version, v 0.0.5 of the Workers OAuth provider (https://www.npmjs.com/package/@cloudflare/workers-oauth-provider). You'll need to update your MCP servers to use that version to resolve the vulnerability.\n\n\n### Workarounds\nNone\n\n### Note\n\nIt is a basic, well-known requirement that OAuth servers should verify that the redirect URI is among the allowed list for the client, both during the authorization flow and subsequently when exchanging the authorization code for an access token. workers-oauth-provider implemented only the latter check, not the former. Unfortunately, the former is the much more important check.\n\nReaders who are familiar with OAuth may recognize that failing to check redirect URIs against the allowed list is a well-known, basic mistake, covered extensively in the RFC and elsewhere. The author of this library would like everyone to know that he was, in fact, well-aware of this requirement, thought about it a lot while designing the library, and then, somehow, forgot to actually make sure the check was in the code. That is, it's not that he didn't know what he was doing, it's that he knew what he was doing but flubbed it.", + "severity": [ + { + "type": "CVSS_V4", + "score": "CVSS:4.0/AV:N/AC:H/AT:P/PR:N/UI:P/VC:H/VI:N/VA:N/SC:L/SI:N/SA:N" + } + ], + "affected": [ + { + "package": { + "ecosystem": "npm", + "name": "@cloudflare/workers-oauth-provider" + }, + "ranges": [ + { + "type": "ECOSYSTEM", + "events": [ + { + "introduced": "0" + }, + { + "fixed": "0.0.5" + } + ] + } + ] + } + ], + "references": [ + { + "type": "WEB", + "url": "https://github.com/cloudflare/workers-oauth-provider/security/advisories/GHSA-4pc9-x2fx-p7vj" + }, + { + "type": "ADVISORY", + "url": "https://nvd.nist.gov/vuln/detail/CVE-2025-4143" + }, + { + "type": "WEB", + "url": "https://github.com/cloudflare/workers-oauth-provider/pull/26" + }, + { + "type": "PACKAGE", + "url": "https://github.com/cloudflare/workers-oauth-provider" + } + ], + "database_specific": { + "cwe_ids": [ + "CWE-601" + ], + "severity": "MODERATE", + "github_reviewed": true, + "github_reviewed_at": "2025-05-01T17:00:29Z", + "nvd_published_at": null + } +} \ No newline at end of file diff --git a/advisories/github-reviewed/2025/05/GHSA-7cp4-jw97-3rc2/GHSA-7cp4-jw97-3rc2.json b/advisories/github-reviewed/2025/05/GHSA-7cp4-jw97-3rc2/GHSA-7cp4-jw97-3rc2.json new file mode 100644 index 00000000000..29a5f317580 --- /dev/null +++ b/advisories/github-reviewed/2025/05/GHSA-7cp4-jw97-3rc2/GHSA-7cp4-jw97-3rc2.json @@ -0,0 +1,56 @@ +{ + "schema_version": "1.4.0", + "id": "GHSA-7cp4-jw97-3rc2", + "modified": "2025-05-01T17:00:19Z", + "published": "2025-05-01T03:31:17Z", + "withdrawn": "2025-05-01T17:00:19Z", + "aliases": [], + "summary": "Duplicate Advisory: @cloudflare/workers-oauth-provider missing validation of redirect_uri on authorize endpoint", + "details": "# Duplicate Advisory\nThis advisory has been withdrawn because it is a duplicate of GHSA-4pc9-x2fx-p7vj. This link is maintained to preserve external references.\n\n# Original Description\nThe OAuth implementation in workers-oauth-provider that is part of MCP framework https://github.com/cloudflare/workers-mcp , did not correctly validate that redirect_uri was on the allowed list of redirect URIs for the given client registration.\n\nFixed in:  https://github.com/cloudflare/workers-oauth-provider/pull/26 https://github.com/cloudflare/workers-oauth-provider/pull/26 \n\nImpact:\n\n \n\nUnder certain circumstances (see below), if a victim had previously authorized with a server built on workers-oath-provider, and an attacker could later trick the victim into visiting a malicious web site, then attacker could potentially steal the victim's credentials to the same OAuth server and subsequently impersonate them.\n\nIn order for the attack to be possible, the OAuth server's authorized callback must be designed to auto-approve authorizations that appear to come from an OAuth client that the victim has authorized previously. The authorization flow is not implemented by workers-oauth-provider; it is up to the application built on top to decide whether to implement such automatic re-authorization. However, many applications do implement such logic.\n\nNote: It is a basic, well-known requirement that OAuth servers should verify that the redirect URI is among the allowed list for the client, both during the authorization flow and subsequently when exchanging the authorization code for an access token. workers-oauth-provider implemented only the latter check, not the former. Unfortunately, the former is the much more important check. Readers who are familiar with OAuth may recognize that failing to check redirect URIs against the allowed list is a well-known, basic mistake, covered extensively in the RFC and elsewhere. The author of this library would like everyone to know that he was, in fact, well-aware of this requirement, thought about it a lot while designing the library, and then, somehow, forgot to actually make sure the check was in the code. That is, it's not that he didn't know what he was doing, it's that he knew what he was doing but flubbed it.", + "severity": [ + { + "type": "CVSS_V4", + "score": "CVSS:4.0/AV:N/AC:H/AT:P/PR:N/UI:P/VC:H/VI:N/VA:N/SC:L/SI:N/SA:N/E:X/CR:X/IR:X/AR:X/MAV:X/MAC:X/MAT:X/MPR:X/MUI:X/MVC:X/MVI:X/MVA:X/MSC:X/MSI:X/MSA:X/S:X/AU:X/R:X/V:X/RE:X/U:Amber" + } + ], + "affected": [ + { + "package": { + "ecosystem": "npm", + "name": "@cloudflare/workers-oauth-provider" + }, + "ranges": [ + { + "type": "ECOSYSTEM", + "events": [ + { + "introduced": "0" + }, + { + "fixed": "0.0.5" + } + ] + } + ] + } + ], + "references": [ + { + "type": "ADVISORY", + "url": "https://nvd.nist.gov/vuln/detail/CVE-2025-4143" + }, + { + "type": "WEB", + "url": "https://github.com/cloudflare/workers-oauth-provider/pull/26" + } + ], + "database_specific": { + "cwe_ids": [ + "CWE-601" + ], + "severity": "MODERATE", + "github_reviewed": true, + "github_reviewed_at": "2025-05-01T17:00:19Z", + "nvd_published_at": "2025-05-01T01:15:54Z" + } +} \ No newline at end of file diff --git a/advisories/unreviewed/2025/05/GHSA-7cp4-jw97-3rc2/GHSA-7cp4-jw97-3rc2.json b/advisories/unreviewed/2025/05/GHSA-7cp4-jw97-3rc2/GHSA-7cp4-jw97-3rc2.json deleted file mode 100644 index 7e533b9b7c1..00000000000 --- a/advisories/unreviewed/2025/05/GHSA-7cp4-jw97-3rc2/GHSA-7cp4-jw97-3rc2.json +++ /dev/null @@ -1,36 +0,0 @@ -{ - "schema_version": "1.4.0", - "id": "GHSA-7cp4-jw97-3rc2", - "modified": "2025-05-01T03:31:17Z", - "published": "2025-05-01T03:31:17Z", - "aliases": [ - "CVE-2025-4143" - ], - "details": "The OAuth implementation in workers-oauth-provider that is part of MCP framework https://github.com/cloudflare/workers-mcp , did not correctly validate that redirect_uri was on the allowed list of redirect URIs for the given client registration.\n\nFixed in:  https://github.com/cloudflare/workers-oauth-provider/pull/26 https://github.com/cloudflare/workers-oauth-provider/pull/26 \n\nImpact:\n\n \n\nUnder certain circumstances (see below), if a victim had previously authorized with a server built on workers-oath-provider, and an attacker could later trick the victim into visiting a malicious web site, then attacker could potentially steal the victim's credentials to the same OAuth server and subsequently impersonate them.\n\nIn order for the attack to be possible, the OAuth server's authorized callback must be designed to auto-approve authorizations that appear to come from an OAuth client that the victim has authorized previously. The authorization flow is not implemented by workers-oauth-provider; it is up to the application built on top to decide whether to implement such automatic re-authorization. However, many applications do implement such logic.\n\nNote: It is a basic, well-known requirement that OAuth servers should verify that the redirect URI is among the allowed list for the client, both during the authorization flow and subsequently when exchanging the authorization code for an access token. workers-oauth-provider implemented only the latter check, not the former. Unfortunately, the former is the much more important check. Readers who are familiar with OAuth may recognize that failing to check redirect URIs against the allowed list is a well-known, basic mistake, covered extensively in the RFC and elsewhere. The author of this library would like everyone to know that he was, in fact, well-aware of this requirement, thought about it a lot while designing the library, and then, somehow, forgot to actually make sure the check was in the code. That is, it's not that he didn't know what he was doing, it's that he knew what he was doing but flubbed it.", - "severity": [ - { - "type": "CVSS_V4", - "score": "CVSS:4.0/AV:N/AC:H/AT:P/PR:N/UI:P/VC:H/VI:N/VA:N/SC:L/SI:N/SA:N/E:X/CR:X/IR:X/AR:X/MAV:X/MAC:X/MAT:X/MPR:X/MUI:X/MVC:X/MVI:X/MVA:X/MSC:X/MSI:X/MSA:X/S:X/AU:X/R:X/V:X/RE:X/U:Amber" - } - ], - "affected": [], - "references": [ - { - "type": "ADVISORY", - "url": "https://nvd.nist.gov/vuln/detail/CVE-2025-4143" - }, - { - "type": "WEB", - "url": "https://github.com/cloudflare/workers-oauth-provider/pull/26" - } - ], - "database_specific": { - "cwe_ids": [ - "CWE-601" - ], - "severity": "MODERATE", - "github_reviewed": false, - "github_reviewed_at": null, - "nvd_published_at": "2025-05-01T01:15:54Z" - } -} \ No newline at end of file