diff --git a/advisories/github-reviewed/2025/01/GHSA-45v3-38pc-874v/GHSA-45v3-38pc-874v.json b/advisories/github-reviewed/2025/01/GHSA-45v3-38pc-874v/GHSA-45v3-38pc-874v.json new file mode 100644 index 00000000000..3f5c45e8985 --- /dev/null +++ b/advisories/github-reviewed/2025/01/GHSA-45v3-38pc-874v/GHSA-45v3-38pc-874v.json @@ -0,0 +1,64 @@ +{ + "schema_version": "1.4.0", + "id": "GHSA-45v3-38pc-874v", + "modified": "2025-01-13T16:14:07Z", + "published": "2025-01-13T16:14:07Z", + "aliases": [ + "CVE-2024-56138" + ], + "summary": "notation-go's timestamp signature generation lacks certificate revocation check", + "details": "This issue was identified during Quarkslab's audit of the timestamp feature.\n\n### Summary\nDuring the timestamp signature generation, the revocation status of the certificate(s) used to generate the timestamp signature was not verified.\n\n### Details\nDuring timestamp signature generation, notation-go did not check the revocation status of the certificate chain used by the TSA. This oversight creates a vulnerability that could be exploited through a Man-in-The-Middle attack. An attacker could potentially use a compromised, intermediate, or revoked leaf certificate to generate a malicious countersignature, which would then be accepted and stored by `notation`.\n\n### Impact\nThis could lead to denial of service scenarios, particularly in CI/CD environments during signature verification processes because timestamp signature would fail due to the presence of a revoked certificate(s) potentially disrupting operations.\n", + "severity": [ + { + "type": "CVSS_V3", + "score": "CVSS:3.1/AV:L/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:L" + } + ], + "affected": [ + { + "package": { + "ecosystem": "Go", + "name": "github.com/notaryproject/notation-go" + }, + "ranges": [ + { + "type": "ECOSYSTEM", + "events": [ + { + "introduced": "1.2.0-beta.1" + }, + { + "fixed": "1.3.0-rc.2" + } + ] + } + ], + "database_specific": { + "last_known_affected_version_range": "<= 1.3.0-rc.1" + } + } + ], + "references": [ + { + "type": "WEB", + "url": "https://github.com/notaryproject/notation-go/security/advisories/GHSA-45v3-38pc-874v" + }, + { + "type": "WEB", + "url": "https://github.com/notaryproject/notation-go/commit/e99be1954a15673020150c5f8800b8174cd7428d" + }, + { + "type": "PACKAGE", + "url": "https://github.com/notaryproject/notation-go" + } + ], + "database_specific": { + "cwe_ids": [ + "CWE-299" + ], + "severity": "MODERATE", + "github_reviewed": true, + "github_reviewed_at": "2025-01-13T16:14:07Z", + "nvd_published_at": null + } +} \ No newline at end of file diff --git a/advisories/github-reviewed/2025/01/GHSA-qjh3-4j3h-vmwp/GHSA-qjh3-4j3h-vmwp.json b/advisories/github-reviewed/2025/01/GHSA-qjh3-4j3h-vmwp/GHSA-qjh3-4j3h-vmwp.json new file mode 100644 index 00000000000..7234f3d3ffb --- /dev/null +++ b/advisories/github-reviewed/2025/01/GHSA-qjh3-4j3h-vmwp/GHSA-qjh3-4j3h-vmwp.json @@ -0,0 +1,64 @@ +{ + "schema_version": "1.4.0", + "id": "GHSA-qjh3-4j3h-vmwp", + "modified": "2025-01-13T16:13:59Z", + "published": "2025-01-13T16:13:59Z", + "aliases": [ + "CVE-2024-51491" + ], + "summary": "notation-go has an OS error when setting CRL cache leads to denial of signature verification", + "details": "### Summary\nThe issue was identified during Quarkslab's security audit on the Certificate Revocation List (CRL) based revocation check feature.\nAfter retrieving the CRL, notation-go attempts to update the CRL cache using the os.Rename method. However, this operation may fail due to operating system-specific limitations, particularly when the source and destination paths are on different mount points. This failure could lead to an unexpected program termination.\n\n### Details\n\nIn method `crl.(*FileCache).Set`, a temporary file is created in the OS dedicated area (like /tmp for, usually, Linux/Unix). The file is written and then it is tried to move it to the dedicated `notation` cache directory thanks `os.Rename`. As specified in Go documentation, OS specific restriction may apply. When used with Linux OS, it is relying on `rename` syscall from the libc and as per the [documentation](https://man7.org/linux/man-pages/man2/rename.2.html), moving a file to a different mountpoint raises an `EXDEV` error, interpreted as `Cross device link not permitted error`.\nSome Linux distribution, like `RedHat` use a dedicated filesystem (`tmpfs`), mounted on a specific mountpoint (usually `/tmp`) for temporary files. When using such OS, revocation check based on CRL will repeatedly crash `notation`. \n\n### PoC\n1. Ensure that the temporary file storage area (e.g., /tmp) is mounted on a different mount point than the user's 'notation' cache directory.\n2. Either disable the Online Certificate Status Protocol (OCSP) revocation check, or utilize certificates that exclusively support Certificate Revocation Lists (CRLs) for revocation check.\n3. Try to verify a previously generated signature using the 'notation' tool.\n\n### Impact\nThe signature verification process is aborted as process crashes.\n\n### Remediation\nThe cache file should be created, written, then copied to the wanted final location, and finally removed. Additionally, this error shouldn't lead to a crash as it is not fatal and shouldn't prevent the rest of the program to properly continue\n", + "severity": [ + { + "type": "CVSS_V3", + "score": "CVSS:3.1/AV:L/AC:L/PR:N/UI:R/S:U/C:N/I:N/A:L" + } + ], + "affected": [ + { + "package": { + "ecosystem": "Go", + "name": "github.com/notaryproject/notation-go" + }, + "ranges": [ + { + "type": "ECOSYSTEM", + "events": [ + { + "introduced": "1.3.0-rc.1" + }, + { + "fixed": "1.3.0-rc.2" + } + ] + } + ], + "versions": [ + "1.3.0-rc.1" + ] + } + ], + "references": [ + { + "type": "WEB", + "url": "https://github.com/notaryproject/notation-go/security/advisories/GHSA-qjh3-4j3h-vmwp" + }, + { + "type": "WEB", + "url": "https://github.com/notaryproject/notation-go/commit/3c3302258ad510fbca2f8a73731569d91f07d196" + }, + { + "type": "PACKAGE", + "url": "https://github.com/notaryproject/notation-go" + } + ], + "database_specific": { + "cwe_ids": [ + "CWE-703" + ], + "severity": "LOW", + "github_reviewed": true, + "github_reviewed_at": "2025-01-13T16:13:59Z", + "nvd_published_at": null + } +} \ No newline at end of file