diff --git a/advisories/github-reviewed/2024/03/GHSA-cj3c-5xpm-cx94/GHSA-cj3c-5xpm-cx94.json b/advisories/github-reviewed/2024/03/GHSA-cj3c-5xpm-cx94/GHSA-cj3c-5xpm-cx94.json new file mode 100644 index 00000000000..1a07609b96c --- /dev/null +++ b/advisories/github-reviewed/2024/03/GHSA-cj3c-5xpm-cx94/GHSA-cj3c-5xpm-cx94.json @@ -0,0 +1,65 @@ +{ + "schema_version": "1.4.0", + "id": "GHSA-cj3c-5xpm-cx94", + "modified": "2024-03-29T19:05:49Z", + "published": "2024-03-29T19:05:49Z", + "aliases": [ + "CVE-2024-29200" + ], + "summary": "Kimai API returns timesheet entries a user should not be authorized to view", + "details": "### Summary\nThe permission `view_other_timesheet` performs differently for the Kimai UI and the API, thus returning unexpected data through the API.\n\n### Details\nWhen setting the `view_other_timesheet` permission to true, on the frontend, users can only see timesheet entries for teams they are a part of. When requesting all timesheets from the API, however, all timesheet entries are returned, regardless of whether the user shares team permissions or not.\n\nExample:\nThere are projects P1 and P2, Teams T1 and T2, users U1 and U2 and Timesheet entries E1 and E2. U1 is team leader of team T1 and has access to P1. U2 is in Team T2 and has access to both P1 and P2. U2 creates E1 for P1 and E2 for P2.\nIn the UI, U1 with `view _other_timesheet` perms sees E1 as he is a part of T1 that has access to P1.\nIn the API, however, he has access to E1 **and E2**.\n\nAdditionally, if U1 is not a team leader T1, he does not see any timesheet from a user other than himself in the UI, but still all timesheets in the API.\n\n### PoC\n- Give a user `view_other_timesheet` permission\n- The result of the UI and the API call to `/api/timesheets?user=all` differs in the data that is being returned\n\nCurl command:\n```bash\ncurl -X 'GET' \\\n 'https://kimai.instance.com/api/timesheets?user=all' \\\n -H 'accept: application/json' \\\n -H 'X-AUTH-USER: username' \\\n -H 'X-AUTH-TOKEN: api_token'\n ```\n\n### Impact\nThis is at least an insufficient granularity of access control weakness. People can see timesheet entries they are not supposed to.\nThis greatly affects the confidentiality of timesheet entries. \n\nRestricting API access to administrators is also not a valid solution, as API access is needed, for example, to use the mobile app.\n", + "severity": [ + { + "type": "CVSS_V3", + "score": "CVSS:3.1/AV:N/AC:L/PR:L/UI:R/S:C/C:H/I:N/A:N" + } + ], + "affected": [ + { + "package": { + "ecosystem": "Packagist", + "name": "kimai/kimai" + }, + "ranges": [ + { + "type": "ECOSYSTEM", + "events": [ + { + "introduced": "0" + }, + { + "fixed": "2.13.0" + } + ] + } + ] + } + ], + "references": [ + { + "type": "WEB", + "url": "https://github.com/kimai/kimai/security/advisories/GHSA-cj3c-5xpm-cx94" + }, + { + "type": "ADVISORY", + "url": "https://nvd.nist.gov/vuln/detail/CVE-2024-29200" + }, + { + "type": "PACKAGE", + "url": "https://github.com/kimai/kimai" + }, + { + "type": "WEB", + "url": "https://github.com/kimai/kimai/releases/tag/2.13.0" + } + ], + "database_specific": { + "cwe_ids": [ + "CWE-1220" + ], + "severity": "MODERATE", + "github_reviewed": true, + "github_reviewed_at": "2024-03-29T19:05:49Z", + "nvd_published_at": "2024-03-28T14:15:14Z" + } +} \ No newline at end of file diff --git a/advisories/github-reviewed/2024/03/GHSA-x768-cvr2-345r/GHSA-x768-cvr2-345r.json b/advisories/github-reviewed/2024/03/GHSA-x768-cvr2-345r/GHSA-x768-cvr2-345r.json new file mode 100644 index 00000000000..32a42b25e66 --- /dev/null +++ b/advisories/github-reviewed/2024/03/GHSA-x768-cvr2-345r/GHSA-x768-cvr2-345r.json @@ -0,0 +1,68 @@ +{ + "schema_version": "1.4.0", + "id": "GHSA-x768-cvr2-345r", + "modified": "2024-03-29T19:05:26Z", + "published": "2024-03-29T19:05:26Z", + "aliases": [ + "CVE-2024-28867" + ], + "summary": "Un-sanitized metric name or labels can be used to take over exported metrics", + "details": "### Impact\n\nIn code which applies _un-sanitized string values into metric names or labels_, like this:\n\n```swift\nlet lang = try? request.query-get(String.self, at: \"lang\")\nCounter (\n label: \"language\", \n dimensions: [(\"lang\", lang ?? \"unknown\" )]\n)\n```\n\nan attacker could make use of this and send a `?lang` query parameter containing newlines, `}` or similar characters which can lead to the attacker taking over the exported format -- including creating unbounded numbers of stored metrics, inflating server memory usage, or causing \"bogus\" metrics.\n\n### Patches\nThe default strategy to sanitize labels was moved deeper into the library, preventing illegal characters from appearing in name, label keys and values.\n\nMetric names and label names are now validated against the following requirement: `[a-zA-Z_:][a-zA-Z0-9_:]*` (for metric names) and `[a-zA-Z_][a-zA-Z0-9_]*` (for metric label names). Label values are not validated as they are allowed to contain any unicode characters. Developers _must_ validate labels themselves and not allow malicious input.\n\nThe approach taken here mirrors the approach taken in the Go reference implementation.\n\n### Discussion\n\nIt is **strongly discouraged** to use un-sanitized user input as names or labels in general, because they can lead to un-bounded growth of metrics, even as this vulnerability is patched and result in a Denial-of-Service attack opportunity -- **regardless** how well the library is sanitizing the inputs. We strongly recommend only using a sanitized set of values for your metrics names and labels. E.g., a `\"lang\"` label, should only use an expected set of values that can be used, and ignore other ones -- otherwise a determined attacker could create one metric per different label key, leading to unbounded memory use growth as metrics with distinct values must be kept in memory.\n\n**Validating label values:**\n\nThe library will **NOT** automatically validate and replace strings offered as label values.\nDevelopers **must** validate label values themselves, and it is strongly recommended to only accept a well known set of values.\n\nIt is possible to configure the `PrometheusSanitizer` to apply whatever validation you deem necessary:\n\n```swift\nlet mySanitizer = PrometheusSanitizer { metricName, labels in\n // ... your logic here ...\n (metricName, labels)\n}\n\nlet registry = PrometheusCollectorRegistry(sanitizer: mySanitizer)\nlet factory = PrometheusMetricsFactory(factory: registry)\n\n// swift-metrics\nMetricsSystem.bootstrap(factory)\n```\n\n\n\n### Workarounds\n\nDevelopers must validate user input before using it as metric names, label names or values. This follows common practice of not trusting any user input without sanitization.\n\n### Credits\n\nWe would like to thank Jonas Dörr for bringing out attention to the issue.", + "severity": [ + { + "type": "CVSS_V3", + "score": "CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:N/I:H/A:N" + } + ], + "affected": [ + { + "package": { + "ecosystem": "SwiftURL", + "name": "github.com/swift-server/swift-prometheus" + }, + "ranges": [ + { + "type": "ECOSYSTEM", + "events": [ + { + "introduced": "2.0.0-alpha.1" + }, + { + "fixed": "2.0.0-alpha.2" + } + ] + } + ], + "versions": [ + "2.0.0-alpha.1" + ] + } + ], + "references": [ + { + "type": "WEB", + "url": "https://github.com/swift-server/swift-prometheus/security/advisories/GHSA-x768-cvr2-345r" + }, + { + "type": "ADVISORY", + "url": "https://nvd.nist.gov/vuln/detail/CVE-2024-28867" + }, + { + "type": "WEB", + "url": "https://github.com/swift-server/swift-prometheus/commit/bfcd4bbfabe11aae4b035424ee9724582e288501" + }, + { + "type": "PACKAGE", + "url": "https://github.com/swift-server/swift-prometheus" + } + ], + "database_specific": { + "cwe_ids": [ + "CWE-74" + ], + "severity": "MODERATE", + "github_reviewed": true, + "github_reviewed_at": "2024-03-29T19:05:26Z", + "nvd_published_at": "2024-03-29T15:15:11Z" + } +} \ No newline at end of file