From b61c977b10496845000002c0b1b5a28294b7e958 Mon Sep 17 00:00:00 2001 From: "advisory-database[bot]" <45398580+advisory-database[bot]@users.noreply.github.com> Date: Thu, 15 May 2025 14:06:50 +0000 Subject: [PATCH] Publish Advisories GHSA-7mm3-vfg8-7rg6 GHSA-869w-47c6-fq8q --- .../GHSA-7mm3-vfg8-7rg6.json | 55 ++++++++++++++++++ .../GHSA-869w-47c6-fq8q.json | 56 +++++++++++++++++++ 2 files changed, 111 insertions(+) create mode 100644 advisories/github-reviewed/2025/05/GHSA-7mm3-vfg8-7rg6/GHSA-7mm3-vfg8-7rg6.json create mode 100644 advisories/github-reviewed/2025/05/GHSA-869w-47c6-fq8q/GHSA-869w-47c6-fq8q.json diff --git a/advisories/github-reviewed/2025/05/GHSA-7mm3-vfg8-7rg6/GHSA-7mm3-vfg8-7rg6.json b/advisories/github-reviewed/2025/05/GHSA-7mm3-vfg8-7rg6/GHSA-7mm3-vfg8-7rg6.json new file mode 100644 index 00000000000..e2ee9517391 --- /dev/null +++ b/advisories/github-reviewed/2025/05/GHSA-7mm3-vfg8-7rg6/GHSA-7mm3-vfg8-7rg6.json @@ -0,0 +1,55 @@ +{ + "schema_version": "1.4.0", + "id": "GHSA-7mm3-vfg8-7rg6", + "modified": "2025-05-15T14:05:32Z", + "published": "2025-05-15T14:05:32Z", + "aliases": [], + "summary": "Babylon Finality Provider `MsgCommitPubRandList` replay attack", + "details": "### Summary\n\nA high vulnerability exists in the Babylon protocol's x/finality module due to a lack of domain separation in signed messages, combined with insufficient validation in the MsgCommitPubRandList handler. Specifically, the handler does not enforce that the submitted Commitment field is 32 bytes long. This allows an attacker to replay a signature originally generated for a different message (e.g., a Proof-of-Possession in MsgCreateFinalityProvider) as a MsgCommitPubRandList. By crafting the message parameters, an attacker can use the typically 20-byte address bytes (from the PoP context) to form the StartHeight, NumPubRand, and a shorter-than-expected Commitment (e.g., 4 bytes). The replayed signature will pass verification for this crafted message, leading to the injection of an invalid PubRand commitment.\n\n### Impact\n\nSuccessful exploitation of this vulnerability, specifically via the PoP signature replay, allows an attacker to store an invalid PubRand commitment (with a non-standard length, e.g., 4 bytes) for a targeted Finality Provider (FP). Despite the commitment itself being malformed, it's the associated StartHeight and NumPubRand (derived from the replayed address bytes and typically very large) that cause severe consequences\n\n### Future recommendations\n\nTo minimize future risk of such attacks, all finality providers should:\n1. Never re-use your finality provider EOTS across the networks (e.g., the testnet) or for any other purpose. \n2. Never use EOTS keys to sign any other data than relevant to in-protocol messages. Ideally EOTS key should only be used to:\n - Sign initial proof of possession message\n - Sign periodic randomness commits\n - Sign finality votes with every block", + "severity": [ + { + "type": "CVSS_V4", + "score": "CVSS:4.0/AV:N/AC:L/AT:P/PR:N/UI:N/VC:N/VI:H/VA:N/SC:N/SI:H/SA:N" + } + ], + "affected": [ + { + "package": { + "ecosystem": "Go", + "name": "github.com/babylonlabs-io/babylon" + }, + "ranges": [ + { + "type": "ECOSYSTEM", + "events": [ + { + "introduced": "0" + }, + { + "last_affected": "1.0.2" + } + ] + } + ] + } + ], + "references": [ + { + "type": "WEB", + "url": "https://github.com/babylonlabs-io/babylon/security/advisories/GHSA-7mm3-vfg8-7rg6" + }, + { + "type": "PACKAGE", + "url": "https://github.com/babylonlabs-io/babylon" + } + ], + "database_specific": { + "cwe_ids": [ + "CWE-290" + ], + "severity": "HIGH", + "github_reviewed": true, + "github_reviewed_at": "2025-05-15T14:05:32Z", + "nvd_published_at": null + } +} \ No newline at end of file diff --git a/advisories/github-reviewed/2025/05/GHSA-869w-47c6-fq8q/GHSA-869w-47c6-fq8q.json b/advisories/github-reviewed/2025/05/GHSA-869w-47c6-fq8q/GHSA-869w-47c6-fq8q.json new file mode 100644 index 00000000000..fb284c1f855 --- /dev/null +++ b/advisories/github-reviewed/2025/05/GHSA-869w-47c6-fq8q/GHSA-869w-47c6-fq8q.json @@ -0,0 +1,56 @@ +{ + "schema_version": "1.4.0", + "id": "GHSA-869w-47c6-fq8q", + "modified": "2025-05-15T14:05:50Z", + "published": "2025-05-15T14:05:50Z", + "aliases": [], + "summary": "Babylon Integer Overflow in Distribution Module CumulativeRewardRatio Calculation Leading to Chain Halt", + "details": "### Summary\nMinting large amount of tokens through ibc transfer and then depositing them in validator rewards pool (via `DepositValidatorRewardsPool` message) can lead to integer overflow panic when calculating `cumulative_reward_ratio` for the validator.\n\nThis calculation happens in `x/epoching` module `EndBlocker`, thus the panic will halt the chain.\n\n### Impact\n\nDenial of Service - Due to panic in the `EndBlocker` Babylon Genesis will halt", + "severity": [ + { + "type": "CVSS_V4", + "score": "CVSS:4.0/AV:N/AC:L/AT:P/PR:N/UI:N/VC:N/VI:N/VA:H/SC:N/SI:N/SA:N" + } + ], + "affected": [ + { + "package": { + "ecosystem": "Go", + "name": "github.com/babylonlabs-io/babylon" + }, + "ranges": [ + { + "type": "ECOSYSTEM", + "events": [ + { + "introduced": "0" + }, + { + "last_affected": "1.0.2" + } + ] + } + ] + } + ], + "references": [ + { + "type": "WEB", + "url": "https://github.com/babylonlabs-io/babylon/security/advisories/GHSA-869w-47c6-fq8q" + }, + { + "type": "PACKAGE", + "url": "https://github.com/babylonlabs-io/babylon" + } + ], + "database_specific": { + "cwe_ids": [ + "CWE-190", + "CWE-770" + ], + "severity": "HIGH", + "github_reviewed": true, + "github_reviewed_at": "2025-05-15T14:05:50Z", + "nvd_published_at": null + } +} \ No newline at end of file