diff --git a/advisories/github-reviewed/2024/04/GHSA-ppx5-q359-pvwj/GHSA-ppx5-q359-pvwj.json b/advisories/github-reviewed/2024/04/GHSA-ppx5-q359-pvwj/GHSA-ppx5-q359-pvwj.json new file mode 100644 index 00000000000..dfe25da238d --- /dev/null +++ b/advisories/github-reviewed/2024/04/GHSA-ppx5-q359-pvwj/GHSA-ppx5-q359-pvwj.json @@ -0,0 +1,73 @@ +{ + "schema_version": "1.4.0", + "id": "GHSA-ppx5-q359-pvwj", + "modified": "2024-04-25T19:53:43Z", + "published": "2024-04-25T19:53:43Z", + "aliases": [ + "CVE-2024-32481" + ], + "summary": "vyper's range(start, start + N) reverts for negative numbers", + "details": "### Summary\n\nWhen looping over a `range` of the form `range(start, start + N)`, if `start` is negative, the execution will always revert.\n \n### Details\n\nThis issue is caused by an incorrect assertion inserted by the code generation of the range (`stmt.parse_For_range()`):\n\nhttps://github.com/vyperlang/vyper/blob/9136169468f317a53b4e7448389aa315f90b95ba/vyper/codegen/stmt.py#L286-L287\n\nThis assertion was introduced in https://github.com/vyperlang/vyper/commit/3de1415ee77a9244eb04bdb695e249d3ec9ed868 to fix https://github.com/advisories/GHSA-6r8q-pfpv-7cgj. The issue arises when `start` is signed, instead of using `sle`, `le` is used and `start` is interpreted as an unsigned integer for the comparison. If it is a negative number, its 255th bit is set to `1` and is hence interpreted as a very large unsigned integer making the assertion always fail. \n### PoC\n\n```Vyper\n@external\ndef foo():\n x:int256 = min_value(int256)\n # revert when it should not since we have the following assertion that fails:\n # [assert, [le, min_value(int256), max_value(int256) + 1 - 10]],\n for i in range(x, x + 10):\n pass\n```\n\n### Patches\n\npatched in v0.4.0, specifically, https://github.com/vyperlang/vyper/pull/3679 disallows this form of `range()`.\n\n### Impact\n\nAny contract having a `range(start, start + N)` where `start` is a signed integer with the possibility for `start` to be negative is affected. If a call goes through the loop while supplying a negative `start` the execution will revert.", + "severity": [ + { + "type": "CVSS_V3", + "score": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:L/A:N" + } + ], + "affected": [ + { + "package": { + "ecosystem": "PyPI", + "name": "vyper" + }, + "ranges": [ + { + "type": "ECOSYSTEM", + "events": [ + { + "introduced": "0.3.8" + }, + { + "fixed": "0.4.0" + } + ] + } + ] + } + ], + "references": [ + { + "type": "WEB", + "url": "https://github.com/vyperlang/vyper/security/advisories/GHSA-ppx5-q359-pvwj" + }, + { + "type": "ADVISORY", + "url": "https://nvd.nist.gov/vuln/detail/CVE-2024-32481" + }, + { + "type": "WEB", + "url": "https://github.com/vyperlang/vyper/commit/3de1415ee77a9244eb04bdb695e249d3ec9ed868" + }, + { + "type": "WEB", + "url": "https://github.com/vyperlang/vyper/commit/5319cfbe14951e007ccdb323257e5ada869b35d5" + }, + { + "type": "PACKAGE", + "url": "https://github.com/vyperlang/vyper" + }, + { + "type": "WEB", + "url": "https://github.com/vyperlang/vyper/blob/9136169468f317a53b4e7448389aa315f90b95ba/vyper/codegen/stmt.py#L286-L287" + } + ], + "database_specific": { + "cwe_ids": [ + "CWE-681" + ], + "severity": "MODERATE", + "github_reviewed": true, + "github_reviewed_at": "2024-04-25T19:53:43Z", + "nvd_published_at": "2024-04-25T17:15:50Z" + } +} \ No newline at end of file diff --git a/advisories/github-reviewed/2024/04/GHSA-xchq-w5r3-4wg3/GHSA-xchq-w5r3-4wg3.json b/advisories/github-reviewed/2024/04/GHSA-xchq-w5r3-4wg3/GHSA-xchq-w5r3-4wg3.json new file mode 100644 index 00000000000..5a3dba796c7 --- /dev/null +++ b/advisories/github-reviewed/2024/04/GHSA-xchq-w5r3-4wg3/GHSA-xchq-w5r3-4wg3.json @@ -0,0 +1,61 @@ +{ + "schema_version": "1.4.0", + "id": "GHSA-xchq-w5r3-4wg3", + "modified": "2024-04-25T19:53:10Z", + "published": "2024-04-25T19:53:10Z", + "aliases": [ + "CVE-2024-32645" + ], + "summary": "vyper performs incorrect topic logging in raw_log", + "details": "### Summary\nIncorrect values can be logged when `raw_log` builtin is called with memory or storage arguments to be used as topics.\n\nA contract search was performed and no vulnerable contracts were found in production. In particular, no uses of `raw_log()` were found at all in production; it is apparently not a well-known function.\n\n### Details\nThe `build_IR` function of the `RawLog` class fails to properly unwrap the variables provided as topics. Consequently, incorrect values are logged as topics.\n\n### PoC\n```vyper\nx: bytes32\n\n@external\ndef f():\n self.x = 0x1234567890123456789012345678901234567890123456789012345678901234\n raw_log([self.x], b\"\") # LOG1(offset:0x60, size:0x00, topic1:0x00)\n\n y: bytes32 = 0x1234567890123456789012345678901234567890123456789012345678901234\n raw_log([y], b\"\") # LOG1(offset:0x80, size:0x00, topic1:0x40)\n```\n\n### Impact\nIncorrect values can be logged which may result in unexpected behavior in client-side applications relying on these logs.\n", + "severity": [ + { + "type": "CVSS_V3", + "score": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:L/A:N" + } + ], + "affected": [ + { + "package": { + "ecosystem": "PyPI", + "name": "vyper" + }, + "ranges": [ + { + "type": "ECOSYSTEM", + "events": [ + { + "introduced": "0" + }, + { + "last_affected": "0.3.10" + } + ] + } + ] + } + ], + "references": [ + { + "type": "WEB", + "url": "https://github.com/vyperlang/vyper/security/advisories/GHSA-xchq-w5r3-4wg3" + }, + { + "type": "ADVISORY", + "url": "https://nvd.nist.gov/vuln/detail/CVE-2024-32645" + }, + { + "type": "PACKAGE", + "url": "https://github.com/vyperlang/vyper" + } + ], + "database_specific": { + "cwe_ids": [ + "CWE-20" + ], + "severity": "MODERATE", + "github_reviewed": true, + "github_reviewed_at": "2024-04-25T19:53:10Z", + "nvd_published_at": "2024-04-25T18:15:08Z" + } +} \ No newline at end of file