From 33285c3e18b8db693f868df31ef8ea58db56af0f Mon Sep 17 00:00:00 2001 From: "advisory-database[bot]" <45398580+advisory-database[bot]@users.noreply.github.com> Date: Tue, 14 Jan 2025 16:33:40 +0000 Subject: [PATCH] Publish Advisories GHSA-j2jg-fq62-7c3h GHSA-w8xv-rwgf-4fwh --- .../GHSA-j2jg-fq62-7c3h.json | 63 +++++++++++++++++++ .../GHSA-w8xv-rwgf-4fwh.json | 59 +++++++++++++++++ 2 files changed, 122 insertions(+) create mode 100644 advisories/github-reviewed/2025/01/GHSA-j2jg-fq62-7c3h/GHSA-j2jg-fq62-7c3h.json create mode 100644 advisories/github-reviewed/2025/01/GHSA-w8xv-rwgf-4fwh/GHSA-w8xv-rwgf-4fwh.json diff --git a/advisories/github-reviewed/2025/01/GHSA-j2jg-fq62-7c3h/GHSA-j2jg-fq62-7c3h.json b/advisories/github-reviewed/2025/01/GHSA-j2jg-fq62-7c3h/GHSA-j2jg-fq62-7c3h.json new file mode 100644 index 00000000000..4d9079243cd --- /dev/null +++ b/advisories/github-reviewed/2025/01/GHSA-j2jg-fq62-7c3h/GHSA-j2jg-fq62-7c3h.json @@ -0,0 +1,63 @@ +{ + "schema_version": "1.4.0", + "id": "GHSA-j2jg-fq62-7c3h", + "modified": "2025-01-14T16:32:22Z", + "published": "2025-01-14T16:32:22Z", + "aliases": [], + "summary": "Gradio Blocked Path ACL Bypass Vulnerability", + "details": "## Summary\n\nGradio's Access Control List (ACL) for file paths can be bypassed by altering the letter case of a blocked file or directory path. This vulnerability arises due to the lack of case normalization in the file path validation logic. On case-insensitive file systems, such as those used by Windows and macOS, this flaw enables attackers to circumvent security restrictions and access sensitive files that should be protected.\n\nThis issue can lead to unauthorized data access, exposing sensitive information and undermining the integrity of Gradio's security model. Given Gradio's popularity for building web applications, particularly in machine learning and AI, this vulnerability may pose a substantial threat if exploited in production environments.\n\n## Affected Version\n\nGradio <= 5.6.0\n\n## Impact\n\n- **Unauthorized Access**: Sensitive files or directories specified in `blocked_paths` can be accessed by attackers.\n\n- **Data Exposure**: Critical files, such as configuration files or user data, may be leaked.\n\n- **Security Breach**: This can lead to broader application or system compromise if sensitive files contain credentials or API keys.\n\n## Root Cause\n\nThe [`blocked_paths`](https://github.com/gradio-app/gradio/blob/main/gradio/blocks.py#L2310) parameter in Gradio block's initial configuration is designed to restrict user access to specific files or directories in the local file system. However, it does not account for case-insensitive operating systems, such as Windows and macOS. This oversight enables attackers to bypass ACL restrictions by changing the case of file paths.\n\nVulnerable snippet: \n\n```python\n# https://github.com/gradio-app/gradio/blob/main/gradio/utils.py#L1500-L1517\ndef is_allowed_file(\n path: Path,\n blocked_paths: Sequence[str | Path],\n allowed_paths: Sequence[str | Path],\n created_paths: Sequence[str | Path],\n) -> tuple[\n bool, Literal[\"in_blocklist\", \"allowed\", \"created\", \"not_created_or_allowed\"]\n]:\n in_blocklist = any(\n is_in_or_equal(path, blocked_path) for blocked_path in blocked_paths\n )\n if in_blocklist:\n return False, \"in_blocklist\"\n if any(is_in_or_equal(path, allowed_path) for allowed_path in allowed_paths):\n return True, \"allowed\"\n if any(is_in_or_equal(path, created_path) for created_path in created_paths):\n return True, \"created\"\n return False, \"not_created_or_allowed\"\n```\n\nGradio relies on `is_in_or_equal` to determine if a file path is restricted. However, this logic fails to handle case variations in paths on case-insensitive file systems, leading to the bypass.\n\n## Proof of Concept (PoC)\n\n### Steps to Reproduce\n\n- Deploy a Gradio demo app on a case-insensitive operating system (e.g., Windows or macOS).\n\n ```bash\n import gradio as gr\n def update(name):\n return f\"Welcome to Gradio, {name}!\"\n \n with gr.Blocks() as demo:\n gr.Markdown(\"Start typing below and then click **Run** to see the output.\")\n with gr.Row():\n inp = gr.Textbox(placeholder=\"What is your name?\")\n out = gr.Textbox()\n btn = gr.Button(\"Run\")\n btn.click(fn=update, inputs=inp, outputs=out)\n \n demo.launch(blocked_paths=['resources/admin'], allowed_paths=['resources/'])\n ```\n\n- Set up the file system:\n\n - Create a folder named `resources` in the same directory as the app, containing a file `1.txt`.\n\n - Inside the `resources` folder, create a subfolder named `admin` containing a sensitive file `credential.txt` (this file should be inaccessible due to `blocked_paths`).\n\n- Perform the attack:\n\n - Access the sensitive file using a case-altered path:\n\n ```\n http://127.0.0.1:PORT/gradio_api/file=resources/adMin/credential.txt\n ```\n\n### Expected Result\n\nAccess to `resources/admin/credential.txt` should be blocked.\n\n### Actual Result\n\nBy altering the case in the path (e.g., `adMin`), the blocked ACL is bypassed, and unauthorized access to the sensitive file is granted.\n\n![image-20241119172439042](https://api.2h0ng.wiki:443/noteimages/2024/11/19/17-24-39-883969d4c31ce8a8d2a939654fab56d4.png)\n\nThis demonstration highlights that flipping the case of restricted paths allows attackers to bypass Gradio's ACL and access sensitive data.\n\n## Remediation Recommendations\n\n1. **Normalize Path Case**:\n\n - Before evaluating paths against the ACL, normalize the case of both the requested path and the blocked paths (e.g., convert all paths to lowercase).\n\n - Example:\n\n ```python\n normalized_path = str(path).lower()\n normalized_blocked_paths = [str(p).lower() for p in blocked_paths]\n ```\n\n2. **Update Documentation**:\n\n - Warn developers about potential risks when deploying Gradio on case-insensitive file systems.\n\n3. **Release Security Patches**:\n\n - Notify users of the vulnerability and release an updated version of Gradio with the fixed logic.\n\n## ", + "severity": [ + { + "type": "CVSS_V4", + "score": "CVSS:4.0/AV:N/AC:L/AT:P/PR:N/UI:N/VC:H/VI:H/VA:N/SC:N/SI:N/SA:N" + } + ], + "affected": [ + { + "package": { + "ecosystem": "PyPI", + "name": "gradio" + }, + "ranges": [ + { + "type": "ECOSYSTEM", + "events": [ + { + "introduced": "0" + }, + { + "fixed": "5.11.0" + } + ] + } + ] + } + ], + "references": [ + { + "type": "WEB", + "url": "https://github.com/gradio-app/gradio/security/advisories/GHSA-j2jg-fq62-7c3h" + }, + { + "type": "WEB", + "url": "https://github.com/gradio-app/gradio/commit/6b63fdec441b5c9bf910f910a2505d8defbb6bf8" + }, + { + "type": "PACKAGE", + "url": "https://github.com/gradio-app/gradio" + }, + { + "type": "WEB", + "url": "https://github.com/gradio-app/gradio/releases/tag/gradio%405.11.0" + } + ], + "database_specific": { + "cwe_ids": [ + "CWE-178" + ], + "severity": "CRITICAL", + "github_reviewed": true, + "github_reviewed_at": "2025-01-14T16:32:22Z", + "nvd_published_at": null + } +} \ No newline at end of file diff --git a/advisories/github-reviewed/2025/01/GHSA-w8xv-rwgf-4fwh/GHSA-w8xv-rwgf-4fwh.json b/advisories/github-reviewed/2025/01/GHSA-w8xv-rwgf-4fwh/GHSA-w8xv-rwgf-4fwh.json new file mode 100644 index 00000000000..5e0daaa62b8 --- /dev/null +++ b/advisories/github-reviewed/2025/01/GHSA-w8xv-rwgf-4fwh/GHSA-w8xv-rwgf-4fwh.json @@ -0,0 +1,59 @@ +{ + "schema_version": "1.4.0", + "id": "GHSA-w8xv-rwgf-4fwh", + "modified": "2025-01-14T16:32:07Z", + "published": "2025-01-14T16:32:07Z", + "aliases": [ + "CVE-2025-0343" + ], + "summary": "CVE-2025-0343: Swift ASN.1 can crash when parsing maliciously formed BER/DER", + "details": "Swift ASN.1 can be caused to crash when parsing certain BER/DER constructions. This crash is caused by a confusion in the ASN.1 library itself which assumes that certain objects can only be provided in either constructed or primitive forms, and will trigger a `preconditionFailure` if that constraint isn't met.\n\nImportantly, these constraints are actually required to be true in DER, but that correctness wasn't enforced on the early node parser side so it was incorrect to rely on it later on in decoding, which is what the library did.\n\nThese crashes can be triggered when parsing any DER/BER format object. There is no memory-safety issue here: the crash is a graceful one from the Swift runtime. The impact of this is that it can be used as a denial-of-service vector when parsing BER/DER data from unknown sources, e.g. when parsing TLS certificates.\n\nMany thanks to @baarde for reporting this issue and providing the fix.", + "severity": [], + "affected": [ + { + "package": { + "ecosystem": "SwiftURL", + "name": "github.com/apple/swift-asn1" + }, + "ranges": [ + { + "type": "ECOSYSTEM", + "events": [ + { + "introduced": "0" + }, + { + "fixed": "1.3.1" + } + ] + } + ], + "database_specific": { + "last_known_affected_version_range": "<= 1.3.0" + } + } + ], + "references": [ + { + "type": "WEB", + "url": "https://github.com/apple/swift-asn1/security/advisories/GHSA-w8xv-rwgf-4fwh" + }, + { + "type": "WEB", + "url": "https://github.com/apple/swift-asn1/commit/ae33e5941bb88d88538d0a6b19ca0b01e6c76dcf" + }, + { + "type": "PACKAGE", + "url": "https://github.com/apple/swift-asn1" + } + ], + "database_specific": { + "cwe_ids": [ + "CWE-228" + ], + "severity": "LOW", + "github_reviewed": true, + "github_reviewed_at": "2025-01-14T16:32:07Z", + "nvd_published_at": null + } +} \ No newline at end of file