This lint warns on each `macro_use` attribute on an extern crate. Such a
way of importing macros from a crate is being phased out. Instead of it,
we should directly import the needed macro using `use` import.
The current behaviour of handling unmatched PDUs in fn read_by_hint()
isn't good enough. An unexpected PDUs may be received and fail to be
decoded during Acceptor::step().
Change the code to simply drop unexpected PDUs (as opposed to attempting
to replay the unmatched leftover, which isn't clearly needed)
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
When compiled in debug mode, the code checks the expected Action hint.
But in release mode, no checks are done and the it will have to fail
later.
Instead, return whether the PDU is matching the hint, so the caller can
decide what to do in this case.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Replace the bitflag-based config API with a boolean-based one:
- `enable_tls`: set the PROTOCOL_SSL flag
- `enable_credssp`: set the PROTOCOL_HYBRID and PROTOCOL_HYBRID_EX flags
The `--security_protocol` argument was removed from the native client
CLI, and instead it’s possible to disable specific protocols with
`--no-tls` and `--no-credssp`. By default, both protocols are
enabled for maximum compatibility with most RDP servers. We may change
the defaults in the future.
