From f68cd06ac3705608e6f2ac6bde684d9ae906ea53 Mon Sep 17 00:00:00 2001 From: Alex Yusiuk <55661041+RRRadicalEdward@users.noreply.github.com> Date: Tue, 3 Jun 2025 14:42:46 +0000 Subject: [PATCH] fix!: rename callExtension to invokeExtension (#803) --- crates/iron-remote-desktop/src/lib.rs | 6 +++--- crates/iron-remote-desktop/src/session.rs | 2 +- crates/ironrdp-web/src/session.rs | 2 +- web-client/iron-remote-desktop/src/interfaces/Session.ts | 2 +- web-client/iron-remote-desktop/src/services/PublicAPI.ts | 6 +++--- .../src/services/remote-desktop.service.ts | 4 ++-- 6 files changed, 11 insertions(+), 11 deletions(-) diff --git a/crates/iron-remote-desktop/src/lib.rs b/crates/iron-remote-desktop/src/lib.rs index 016a4cd3..3f2e86cc 100644 --- a/crates/iron-remote-desktop/src/lib.rs +++ b/crates/iron-remote-desktop/src/lib.rs @@ -188,12 +188,12 @@ macro_rules! make_bridge { $crate::Session::supports_unicode_keyboard_shortcuts(&self.0) } - #[wasm_bindgen(js_name = extensionCall)] - pub fn extension_call( + #[wasm_bindgen(js_name = invokeExtension)] + pub fn invoke_extension( &self, ext: $crate::Extension, ) -> Result<$crate::internal::wasm_bindgen::JsValue, IronError> { - <<$api as $crate::RemoteDesktopApi>::Session as $crate::Session>::extension_call(&self.0, ext) + <<$api as $crate::RemoteDesktopApi>::Session as $crate::Session>::invoke_extension(&self.0, ext) .map_err(IronError) } } diff --git a/crates/iron-remote-desktop/src/session.rs b/crates/iron-remote-desktop/src/session.rs index d7cb256a..a1b8dc51 100644 --- a/crates/iron-remote-desktop/src/session.rs +++ b/crates/iron-remote-desktop/src/session.rs @@ -98,7 +98,7 @@ pub trait Session { fn supports_unicode_keyboard_shortcuts(&self) -> bool; - fn extension_call(&self, ext: Extension) -> Result; + fn invoke_extension(&self, ext: Extension) -> Result; } pub trait SessionTerminationInfo { diff --git a/crates/ironrdp-web/src/session.rs b/crates/ironrdp-web/src/session.rs index 99eca8e7..b3d864fb 100644 --- a/crates/ironrdp-web/src/session.rs +++ b/crates/ironrdp-web/src/session.rs @@ -805,7 +805,7 @@ impl iron_remote_desktop::Session for Session { false } - fn extension_call(&self, ext: Extension) -> Result { + fn invoke_extension(&self, ext: Extension) -> Result { Err( IronError::from(anyhow::Error::msg(format!("unknown extension: {}", ext.ident()))) .with_kind(IronErrorKind::General), diff --git a/web-client/iron-remote-desktop/src/interfaces/Session.ts b/web-client/iron-remote-desktop/src/interfaces/Session.ts index 91aaf829..514d0aac 100644 --- a/web-client/iron-remote-desktop/src/interfaces/Session.ts +++ b/web-client/iron-remote-desktop/src/interfaces/Session.ts @@ -9,7 +9,7 @@ export interface Session { applyInputs(transaction: InputTransaction): void; releaseAllInputs(): void; synchronizeLockKeys(scrollLock: boolean, numLock: boolean, capsLock: boolean, kanaLock: boolean): void; - extensionCall(value: unknown): unknown; + invokeExtension(value: unknown): unknown; shutdown(): void; onClipboardPaste(data: ClipboardData): Promise; resize( diff --git a/web-client/iron-remote-desktop/src/services/PublicAPI.ts b/web-client/iron-remote-desktop/src/services/PublicAPI.ts index dc50b5ec..2b91cd76 100644 --- a/web-client/iron-remote-desktop/src/services/PublicAPI.ts +++ b/web-client/iron-remote-desktop/src/services/PublicAPI.ts @@ -63,8 +63,8 @@ export class PublicAPI { this.remoteDesktopService.setEnableClipboard(enable); } - private callExtension(ext: Extension) { - this.remoteDesktopService.callExtension(ext); + private invokeExtension(ext: Extension) { + this.remoteDesktopService.invokeExtension(ext); } getExposedFunctions(): UserInteraction { @@ -83,7 +83,7 @@ export class PublicAPI { setCursorStyleOverride: this.setCursorStyleOverride.bind(this), resize: this.resize.bind(this), setEnableClipboard: this.setEnableClipboard.bind(this), - callExtension: this.callExtension.bind(this), + callExtension: this.invokeExtension.bind(this), }; } } diff --git a/web-client/iron-remote-desktop/src/services/remote-desktop.service.ts b/web-client/iron-remote-desktop/src/services/remote-desktop.service.ts index 9eeca875..e4e3518e 100644 --- a/web-client/iron-remote-desktop/src/services/remote-desktop.service.ts +++ b/web-client/iron-remote-desktop/src/services/remote-desktop.service.ts @@ -281,8 +281,8 @@ export class RemoteDesktopService { } } - callExtension(ext: Extension) { - this.session?.extensionCall(ext); + invokeExtension(ext: Extension) { + this.session?.invokeExtension(ext); } private releaseAllInputs() {