From c6d606e67054df0d751afb25e5e7b0f4acd1e68c Mon Sep 17 00:00:00 2001 From: Alexandr Yusiuk Date: Wed, 16 Jul 2025 19:12:46 +0300 Subject: [PATCH] refactor: add as_pointer_underscore clippy safety lint --- Cargo.toml | 1 + crates/ironrdp-dvc-pipe-proxy/src/windows/pipe.rs | 12 ++++++------ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index 39b79d1e..1646bde8 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -77,6 +77,7 @@ undocumented_unsafe_blocks = "warn" multiple_unsafe_ops_per_block = "warn" transmute_ptr_to_ptr = "warn" as_ptr_cast_mut = "warn" +as_pointer_underscore = "warn" cast_ptr_alignment = "warn" fn_to_numeric_cast_any = "warn" ptr_cast_constness = "warn" diff --git a/crates/ironrdp-dvc-pipe-proxy/src/windows/pipe.rs b/crates/ironrdp-dvc-pipe-proxy/src/windows/pipe.rs index 88ab42b4..754f49ab 100644 --- a/crates/ironrdp-dvc-pipe-proxy/src/windows/pipe.rs +++ b/crates/ironrdp-dvc-pipe-proxy/src/windows/pipe.rs @@ -114,7 +114,7 @@ impl<'a> OverlappedPipeConnectCtx<'a> { /// after returned event handle is signaled to complete the connection. pub(crate) fn overlapped_connect(&mut self) -> Result { // SAFETY: The handle is valid and we are the owner of the handle. - let result = unsafe { ConnectNamedPipe(self.pipe.raw(), Some(self.overlapped.deref_mut() as *mut _)) }; + let result = unsafe { ConnectNamedPipe(self.pipe.raw(), Some(self.overlapped.deref_mut() as *mut OVERLAPPED)) }; match result { Ok(()) => { @@ -148,7 +148,7 @@ impl<'a> OverlappedPipeConnectCtx<'a> { unsafe { GetOverlappedResult( self.pipe.raw(), - self.overlapped.deref_mut() as *mut _, + self.overlapped.deref_mut() as *mut OVERLAPPED, &mut bytes_read as *mut u32, false, ) @@ -195,7 +195,7 @@ impl<'a> OverlappedPipeReadCtx<'a> { self.pipe.raw(), Some(self.buffer.as_mut_slice()), None, - Some(self.overlapped.deref_mut() as *mut _), + Some(self.overlapped.deref_mut() as *mut OVERLAPPED), ) }; @@ -213,7 +213,7 @@ impl<'a> OverlappedPipeReadCtx<'a> { unsafe { GetOverlappedResult( self.pipe.raw(), - self.overlapped.deref_mut() as *mut _, + self.overlapped.deref_mut() as *mut OVERLAPPED, &mut bytes_read as *mut u32, false, ) @@ -262,7 +262,7 @@ impl<'a> OverlappedWriteCtx<'a> { self.pipe.raw(), Some(&self.data), None, - Some(self.overlapped.deref_mut() as *mut _), + Some(self.overlapped.deref_mut() as *mut OVERLAPPED), ) }; @@ -279,7 +279,7 @@ impl<'a> OverlappedWriteCtx<'a> { unsafe { GetOverlappedResult( self.pipe.raw(), - self.overlapped.deref_mut() as *const _, + self.overlapped.deref_mut() as *const OVERLAPPED, &mut bytes_written as *mut u32, true, )