refactor(core): move cursor.rs

Add documentation.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Cargo.lock

@@ -2022,6 +2022,7 @@ name = "ironrdp-ainput"
 version = "0.1.0"
 dependencies = [
  "bitflags 2.6.0",
+ "ironrdp-core",
  "ironrdp-dvc",
  "ironrdp-pdu",
  "num-derive",
@@ -2093,6 +2094,7 @@ dependencies = [
 name = "ironrdp-cliprdr-format"
 version = "0.1.0"
 dependencies = [
+ "ironrdp-core",
  "ironrdp-pdu",
  "png",
  "thiserror",
@@ -2196,6 +2198,7 @@ dependencies = [
  "bmp",
  "byteorder",
  "expect-test",
+ "ironrdp-core",
  "ironrdp-error",
  "ironrdp-pdu",
  "lazy_static",
@@ -2322,6 +2325,7 @@ name = "ironrdp-session"
 version = "0.1.0"
 dependencies = [
  "ironrdp-connector",
+ "ironrdp-core",
  "ironrdp-displaycontrol",
  "ironrdp-dvc",
  "ironrdp-error",
@@ -2355,6 +2359,7 @@ dependencies = [
  "ironrdp-cliprdr",
  "ironrdp-cliprdr-format",
  "ironrdp-connector",
+ "ironrdp-core",
  "ironrdp-displaycontrol",
  "ironrdp-dvc",
  "ironrdp-fuzzing",
@@ -2806,6 +2811,7 @@ name = "now-proto-pdu"
 version = "0.1.0"
 dependencies = [
  "bitflags 2.6.0",
+ "ironrdp-core",
  "ironrdp-error",
  "ironrdp-pdu",
 ]

crates/ironrdp-ainput/Cargo.toml

@@ -22,6 +22,7 @@ bitflags.workspace = true
 
 num-derive.workspace = true # TODO: remove
 num-traits.workspace = true # TODO: remove
+ironrdp-core.workspace = true
 
 [lints]
 workspace = true

crates/ironrdp-ainput/src/lib.rs

@@ -3,7 +3,7 @@ use ironrdp_dvc::DvcPduEncode;
 use num_derive::{FromPrimitive, ToPrimitive};
 use num_traits::{FromPrimitive as _, ToPrimitive as _};
 
-use ironrdp_pdu::cursor::{ReadCursor, WriteCursor};
+use ironrdp_core::{ReadCursor, WriteCursor};
 use ironrdp_pdu::{ensure_fixed_part_size, invalid_message_err, PduDecode, PduEncode, PduResult};
 // Advanced Input channel as defined from Freerdp, [here]:
 //

crates/ironrdp-cliprdr-format/Cargo.toml

@@ -20,6 +20,7 @@ test = false
 ironrdp-pdu.workspace = true
 thiserror.workspace = true
 png = "0.17"
+ironrdp-core.workspace = true
 
 [lints]
 workspace = true

crates/ironrdp-cliprdr-format/src/bitmap.rs

@@ -1,4 +1,4 @@
-use ironrdp_pdu::cursor::{ReadCursor, WriteCursor};
+use ironrdp_core::{ReadCursor, WriteCursor};
 use ironrdp_pdu::{cast_int, ensure_fixed_part_size, invalid_message_err, PduDecode, PduEncode, PduResult};
 use thiserror::Error;
 

crates/ironrdp-cliprdr-native/src/windows/cliprdr_backend.rs

@@ -1,11 +1,11 @@
 use std::sync::mpsc as mpsc_sync;
 
-use ironrdp_core::impl_as_any;
 use ironrdp_cliprdr::backend::CliprdrBackend;
 use ironrdp_cliprdr::pdu::{
     ClipboardFormat, ClipboardGeneralCapabilityFlags, FileContentsRequest, FileContentsResponse, FormatDataRequest,
     FormatDataResponse, LockDataId,
 };
+use ironrdp_core::impl_as_any;
 use windows::Win32::Foundation::{HWND, LPARAM, WPARAM};
 use windows::Win32::UI::WindowsAndMessaging::PostMessageW;
 

crates/ironrdp-cliprdr/src/pdu/capabilities.rs

@@ -1,5 +1,5 @@
 use bitflags::bitflags;
-use ironrdp_pdu::cursor::{ReadCursor, WriteCursor};
+use ironrdp_core::{ReadCursor, WriteCursor};
 use ironrdp_pdu::{
     cast_int, cast_length, ensure_fixed_part_size, ensure_size, impl_pdu_pod, invalid_message_err, read_padding,
     write_padding, PduDecode, PduEncode, PduResult,

crates/ironrdp-cliprdr/src/pdu/client_temporary_directory.rs

@@ -1,6 +1,6 @@
 use std::borrow::Cow;
 
-use ironrdp_pdu::cursor::{ReadCursor, WriteCursor};
+use ironrdp_core::{ReadCursor, WriteCursor};
 use ironrdp_pdu::utils::{read_string_from_cursor, write_string_to_cursor, CharacterSet};
 use ironrdp_pdu::{
     cast_int, ensure_size, impl_pdu_borrowing, invalid_message_err, IntoOwnedPdu, PduDecode, PduEncode, PduResult,

crates/ironrdp-cliprdr/src/pdu/file_contents.rs

@@ -1,7 +1,7 @@
 use std::borrow::Cow;
 
 use bitflags::bitflags;
-use ironrdp_pdu::cursor::{ReadCursor, WriteCursor};
+use ironrdp_core::{ReadCursor, WriteCursor};
 use ironrdp_pdu::utils::{combine_u64, split_u64};
 use ironrdp_pdu::{
     cast_int, ensure_size, impl_pdu_borrowing, invalid_message_err, IntoOwnedPdu, PduDecode, PduEncode, PduResult,

crates/ironrdp-cliprdr/src/pdu/format_data/file_list.rs

@@ -1,5 +1,5 @@
 use bitflags::bitflags;
-use ironrdp_pdu::cursor::{ReadCursor, WriteCursor};
+use ironrdp_core::{ReadCursor, WriteCursor};
 use ironrdp_pdu::utils::{combine_u64, decode_string, encode_string, split_u64, CharacterSet};
 use ironrdp_pdu::{cast_length, ensure_fixed_part_size, impl_pdu_pod, write_padding, PduDecode, PduEncode, PduResult};
 

crates/ironrdp-cliprdr/src/pdu/format_data/metafile.rs

@@ -1,7 +1,7 @@
 use std::borrow::Cow;
 
 use bitflags::bitflags;
-use ironrdp_pdu::cursor::{ReadCursor, WriteCursor};
+use ironrdp_core::{ReadCursor, WriteCursor};
 use ironrdp_pdu::{ensure_fixed_part_size, ensure_size, PduDecode, PduEncode, PduResult};
 
 bitflags! {

crates/ironrdp-cliprdr/src/pdu/format_data/mod.rs

@@ -9,7 +9,7 @@ pub use self::palette::*;
 #[rustfmt::skip]
 use std::borrow::Cow;
 
-use ironrdp_pdu::cursor::{ReadCursor, WriteCursor};
+use ironrdp_core::{ReadCursor, WriteCursor};
 use ironrdp_pdu::utils::{read_string_from_cursor, to_utf16_bytes, CharacterSet};
 use ironrdp_pdu::{
     cast_int, ensure_fixed_part_size, ensure_size, impl_pdu_borrowing, IntoOwnedPdu, PduDecode, PduEncode, PduResult,

crates/ironrdp-cliprdr/src/pdu/format_data/palette.rs

@@ -1,4 +1,4 @@
-use ironrdp_pdu::cursor::{ReadCursor, WriteCursor};
+use ironrdp_core::{ReadCursor, WriteCursor};
 use ironrdp_pdu::{impl_pdu_pod, PduDecode, PduEncode, PduResult};
 
 /// Represents `PALETTEENTRY`

crates/ironrdp-cliprdr/src/pdu/format_list.rs

@@ -1,6 +1,6 @@
 use std::borrow::Cow;
 
-use ironrdp_pdu::cursor::{ReadCursor, WriteCursor};
+use ironrdp_core::{ReadCursor, WriteCursor};
 use ironrdp_pdu::utils::{read_string_from_cursor, to_utf16_bytes, write_string_to_cursor, CharacterSet};
 use ironrdp_pdu::{
     cast_int, ensure_size, impl_pdu_borrowing, impl_pdu_pod, invalid_message_err, IntoOwnedPdu, PduDecode, PduEncode,

crates/ironrdp-cliprdr/src/pdu/lock.rs

@@ -1,4 +1,4 @@
-use ironrdp_pdu::cursor::{ReadCursor, WriteCursor};
+use ironrdp_core::{ReadCursor, WriteCursor};
 use ironrdp_pdu::{cast_int, ensure_fixed_part_size, impl_pdu_pod, PduDecode, PduEncode, PduResult};
 
 use crate::pdu::PartialHeader;

crates/ironrdp-cliprdr/src/pdu/mod.rs

@@ -17,7 +17,7 @@ pub use self::lock::*;
 
 #[rustfmt::skip]
 use bitflags::bitflags;
-use ironrdp_pdu::cursor::{ReadCursor, WriteCursor};
+use ironrdp_core::{ReadCursor, WriteCursor};
 use ironrdp_pdu::{ensure_fixed_part_size, invalid_message_err, PduDecode, PduEncode, PduResult};
 use ironrdp_svc::SvcPduEncode;
 

crates/ironrdp-core/src/lib.rs

@@ -11,10 +11,12 @@ extern crate alloc;
 mod macros;
 
 mod as_any;
+mod cursor;
 
 // Flat API hierarchy of common traits and types
 
 pub use self::as_any::*;
+pub use self::cursor::*;
 
 // Trait that can only be implemented within the current module
 pub(crate) mod private {

crates/ironrdp-core/src/macros.rs

@@ -21,4 +21,3 @@ macro_rules! assert_impl {
         };
     };
 }
-

crates/ironrdp-displaycontrol/src/client.rs

@@ -2,9 +2,9 @@ use crate::{
     pdu::{DisplayControlCapabilities, DisplayControlMonitorLayout, DisplayControlPdu},
     CHANNEL_NAME,
 };
-use ironrdp_core::impl_as_any;
+use ironrdp_core::{impl_as_any, ReadCursor};
 use ironrdp_dvc::{encode_dvc_messages, DvcClientProcessor, DvcMessage, DvcProcessor};
-use ironrdp_pdu::{cursor::ReadCursor, PduDecode, PduResult};
+use ironrdp_pdu::{PduDecode, PduResult};
 use ironrdp_svc::{ChannelFlags, SvcMessage};
 use tracing::debug;