From 5d8a487001c1280cbaf9f581f2a9a2f47d187bf0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Beno=C3=AEt=20CORTIER?= Date: Mon, 4 Aug 2025 19:15:30 +0900 Subject: [PATCH] fix: rename option no_audio_playback into enable_audio_playback --- crates/ironrdp-client/src/config.rs | 2 +- crates/ironrdp-connector/src/connection.rs | 2 +- crates/ironrdp-connector/src/lib.rs | 2 +- crates/ironrdp-testsuite-extra/tests/tests.rs | 2 +- crates/ironrdp-web/src/session.rs | 2 +- crates/ironrdp/examples/screenshot.rs | 2 +- ffi/src/connector/config.rs | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/crates/ironrdp-client/src/config.rs b/crates/ironrdp-client/src/config.rs index 01e069c1..bbf56c0d 100644 --- a/crates/ironrdp-client/src/config.rs +++ b/crates/ironrdp-client/src/config.rs @@ -417,7 +417,7 @@ impl Config { license_cache: None, enable_server_pointer: !args.no_server_pointer, autologon: args.autologon, - no_audio_playback: false, + enable_audio_playback: true, request_data: None, pointer_software_rendering: false, performance_flags: PerformanceFlags::default(), diff --git a/crates/ironrdp-connector/src/connection.rs b/crates/ironrdp-connector/src/connection.rs index 68b9740c..a79d2119 100644 --- a/crates/ironrdp-connector/src/connection.rs +++ b/crates/ironrdp-connector/src/connection.rs @@ -725,7 +725,7 @@ fn create_client_info_pdu(config: &Config, client_addr: &SocketAddr) -> rdp::Cli flags |= ClientInfoFlags::PASSWORD_IS_SC_PIN; } - if config.no_audio_playback { + if !config.enable_audio_playback { flags |= ClientInfoFlags::NO_AUDIO_PLAYBACK; } diff --git a/crates/ironrdp-connector/src/lib.rs b/crates/ironrdp-connector/src/lib.rs index 5844690c..b443f878 100644 --- a/crates/ironrdp-connector/src/lib.rs +++ b/crates/ironrdp-connector/src/lib.rs @@ -179,7 +179,7 @@ pub struct Config { /// If true, the INFO_AUTOLOGON flag is set in the [`ClientInfoPdu`](ironrdp_pdu::rdp::ClientInfoPdu) pub autologon: bool, /// If true, the INFO_NOAUDIOPLAYBACK flag is set in the [`ClientInfoPdu`](ironrdp_pdu::rdp::ClientInfoPdu) - pub no_audio_playback: bool, + pub enable_audio_playback: bool, pub performance_flags: PerformanceFlags, pub license_cache: Option>, diff --git a/crates/ironrdp-testsuite-extra/tests/tests.rs b/crates/ironrdp-testsuite-extra/tests/tests.rs index 8055e54b..713d6324 100644 --- a/crates/ironrdp-testsuite-extra/tests/tests.rs +++ b/crates/ironrdp-testsuite-extra/tests/tests.rs @@ -297,7 +297,7 @@ fn default_client_config() -> connector::Config { hardware_id: None, request_data: None, autologon: false, - no_audio_playback: false, + enable_audio_playback: true, license_cache: None, enable_server_pointer: true, pointer_software_rendering: true, diff --git a/crates/ironrdp-web/src/session.rs b/crates/ironrdp-web/src/session.rs index 6cb099ce..4b29c58c 100644 --- a/crates/ironrdp-web/src/session.rs +++ b/crates/ironrdp-web/src/session.rs @@ -889,7 +889,7 @@ fn build_config( platform: ironrdp::pdu::rdp::capability_sets::MajorPlatformType::UNSPECIFIED, enable_server_pointer: false, autologon: false, - no_audio_playback: true, + enable_audio_playback: false, request_data: None, pointer_software_rendering: false, performance_flags: PerformanceFlags::default(), diff --git a/crates/ironrdp/examples/screenshot.rs b/crates/ironrdp/examples/screenshot.rs index 6d30c193..12b4143d 100644 --- a/crates/ironrdp/examples/screenshot.rs +++ b/crates/ironrdp/examples/screenshot.rs @@ -208,7 +208,7 @@ fn build_config(username: String, password: String, domain: Option) -> c enable_server_pointer: false, // Disable custom pointers (there is no user interaction anyway). request_data: None, autologon: false, - no_audio_playback: true, + enable_audio_playback: false, pointer_software_rendering: true, performance_flags: PerformanceFlags::default(), desktop_scale_factor: 0, diff --git a/ffi/src/connector/config.rs b/ffi/src/connector/config.rs index 62f9e838..abdfd1ff 100644 --- a/ffi/src/connector/config.rs +++ b/ffi/src/connector/config.rs @@ -193,7 +193,7 @@ pub mod ffi { enable_server_pointer: self.enable_server_pointer.unwrap_or(false), autologon: self.autologon.unwrap_or(false), - no_audio_playback: self.no_audio_playback.unwrap_or(false), + enable_audio_playback: self.no_audio_playback.unwrap_or(true), request_data: None, pointer_software_rendering: self.pointer_software_rendering.unwrap_or(false), performance_flags: self.performance_flags.ok_or("performance flag is missing")?,