diff --git a/Cargo.toml b/Cargo.toml index adeadfb5..7670a2c1 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -132,6 +132,7 @@ allow_attributes = "warn" disallowed_script_idents = "warn" non_zero_suggestions = "warn" renamed_function_params = "warn" +unused_trait_names = "warn" collection_is_never_read = "warn" copy_iterator = "warn" expl_impl_clone_on_copy = "warn" diff --git a/benches/src/perfenc.rs b/benches/src/perfenc.rs index 050a3ac6..45b1383f 100644 --- a/benches/src/perfenc.rs +++ b/benches/src/perfenc.rs @@ -4,15 +4,15 @@ use core::num::NonZero; use core::time::Duration; -use std::io::Write; +use std::io::Write as _; use std::time::Instant; -use anyhow::Context; +use anyhow::Context as _; use ironrdp::pdu::rdp::capability_sets::{CmdFlags, EntropyBits}; use ironrdp::server::bench::encoder::{UpdateEncoder, UpdateEncoderCodecs}; use ironrdp::server::{BitmapUpdate, DesktopSize, DisplayUpdate, PixelFormat, RdpServerDisplayUpdates}; use tokio::fs::File; -use tokio::io::AsyncReadExt; +use tokio::io::AsyncReadExt as _; use tokio::time::sleep; #[tokio::main(flavor = "current_thread")] diff --git a/crates/ironrdp-acceptor/src/channel_connection.rs b/crates/ironrdp-acceptor/src/channel_connection.rs index a176cb25..25f876f7 100644 --- a/crates/ironrdp-acceptor/src/channel_connection.rs +++ b/crates/ironrdp-acceptor/src/channel_connection.rs @@ -1,6 +1,8 @@ use std::collections::HashSet; -use ironrdp_connector::{reason_err, ConnectorError, ConnectorErrorExt, ConnectorResult, Sequence, State, Written}; +use ironrdp_connector::{ + reason_err, ConnectorError, ConnectorErrorExt as _, ConnectorResult, Sequence, State, Written, +}; use ironrdp_core::WriteBuf; use ironrdp_pdu::x224::X224; use ironrdp_pdu::{self as pdu}; diff --git a/crates/ironrdp-acceptor/src/connection.rs b/crates/ironrdp-acceptor/src/connection.rs index 9a2ed37f..fd8b694c 100644 --- a/crates/ironrdp-acceptor/src/connection.rs +++ b/crates/ironrdp-acceptor/src/connection.rs @@ -1,8 +1,8 @@ use core::mem; use ironrdp_connector::{ - encode_x224_packet, reason_err, ConnectorError, ConnectorErrorExt, ConnectorResult, DesktopSize, Sequence, State, - Written, + encode_x224_packet, reason_err, ConnectorError, ConnectorErrorExt as _, ConnectorResult, DesktopSize, Sequence, + State, Written, }; use ironrdp_core::{decode, WriteBuf}; use ironrdp_pdu as pdu; diff --git a/crates/ironrdp-acceptor/src/finalization.rs b/crates/ironrdp-acceptor/src/finalization.rs index 16c36f82..406d4d71 100644 --- a/crates/ironrdp-acceptor/src/finalization.rs +++ b/crates/ironrdp-acceptor/src/finalization.rs @@ -1,4 +1,4 @@ -use ironrdp_connector::{ConnectorError, ConnectorErrorExt, ConnectorResult, Sequence, State, Written}; +use ironrdp_connector::{ConnectorError, ConnectorErrorExt as _, ConnectorResult, Sequence, State, Written}; use ironrdp_core::WriteBuf; use ironrdp_pdu::x224::X224; use ironrdp_pdu::{self as pdu}; diff --git a/crates/ironrdp-acceptor/src/util.rs b/crates/ironrdp-acceptor/src/util.rs index ee7592e3..0b22a8c1 100644 --- a/crates/ironrdp-acceptor/src/util.rs +++ b/crates/ironrdp-acceptor/src/util.rs @@ -1,6 +1,6 @@ use std::borrow::Cow; -use ironrdp_connector::{ConnectorError, ConnectorErrorExt, ConnectorResult}; +use ironrdp_connector::{ConnectorError, ConnectorErrorExt as _, ConnectorResult}; use ironrdp_core::{encode_vec, Encode, WriteBuf}; use ironrdp_pdu::rdp; use ironrdp_pdu::x224::X224; diff --git a/crates/ironrdp-client/src/app.rs b/crates/ironrdp-client/src/app.rs index c13198a9..76b89338 100644 --- a/crates/ironrdp-client/src/app.rs +++ b/crates/ironrdp-client/src/app.rs @@ -5,14 +5,14 @@ use core::time::Duration; use std::sync::Arc; use std::time::Instant; -use raw_window_handle::{DisplayHandle, HasDisplayHandle}; +use raw_window_handle::{DisplayHandle, HasDisplayHandle as _}; use tokio::sync::mpsc; use winit::application::ApplicationHandler; use winit::dpi::{LogicalPosition, PhysicalSize}; use winit::event::{self, WindowEvent}; use winit::event_loop::{ActiveEventLoop, ControlFlow, EventLoop}; use winit::keyboard::ModifiersKeyState; -use winit::platform::scancode::PhysicalKeyExtScancode; +use winit::platform::scancode::PhysicalKeyExtScancode as _; use winit::window::{CursorIcon, CustomCursor, Window, WindowAttributes}; use crate::rdp::{RdpInputEvent, RdpOutputEvent}; diff --git a/crates/ironrdp-cliprdr-native/src/windows/cliprdr_backend.rs b/crates/ironrdp-cliprdr-native/src/windows/cliprdr_backend.rs index f7da46bc..52c1bf53 100644 --- a/crates/ironrdp-cliprdr-native/src/windows/cliprdr_backend.rs +++ b/crates/ironrdp-cliprdr-native/src/windows/cliprdr_backend.rs @@ -5,7 +5,7 @@ use ironrdp_cliprdr::pdu::{ ClipboardFormat, ClipboardGeneralCapabilityFlags, FileContentsRequest, FileContentsResponse, FormatDataRequest, FormatDataResponse, LockDataId, }; -use ironrdp_core::{impl_as_any, IntoOwned}; +use ironrdp_core::{impl_as_any, IntoOwned as _}; use windows::Win32::Foundation::{HWND, LPARAM, WPARAM}; use windows::Win32::UI::WindowsAndMessaging::PostMessageW; diff --git a/crates/ironrdp-connector/src/license_exchange.rs b/crates/ironrdp-connector/src/license_exchange.rs index 0e9dedfa..c995b6bb 100644 --- a/crates/ironrdp-connector/src/license_exchange.rs +++ b/crates/ironrdp-connector/src/license_exchange.rs @@ -9,7 +9,7 @@ use ironrdp_pdu::rdp::server_license::{self, LicenseInformation, LicensePdu, Ser use ironrdp_pdu::PduHint; use rand::prelude::*; -use super::{legacy, ConnectorError, ConnectorErrorExt}; +use super::{legacy, ConnectorError, ConnectorErrorExt as _}; use crate::{encode_send_data_request, ConnectorResult, ConnectorResultExt as _, Sequence, State, Written}; #[derive(Default, Debug)] diff --git a/crates/ironrdp-displaycontrol/src/client.rs b/crates/ironrdp-displaycontrol/src/client.rs index 62646348..74764896 100644 --- a/crates/ironrdp-displaycontrol/src/client.rs +++ b/crates/ironrdp-displaycontrol/src/client.rs @@ -1,4 +1,4 @@ -use ironrdp_core::{impl_as_any, Decode, EncodeResult, ReadCursor}; +use ironrdp_core::{impl_as_any, Decode as _, EncodeResult, ReadCursor}; use ironrdp_dvc::{encode_dvc_messages, DvcClientProcessor, DvcMessage, DvcProcessor}; use ironrdp_pdu::{decode_err, PduResult}; use ironrdp_svc::{ChannelFlags, SvcMessage}; diff --git a/crates/ironrdp-dvc-pipe-proxy/src/windows/pipe.rs b/crates/ironrdp-dvc-pipe-proxy/src/windows/pipe.rs index 754f49ab..6a7e69b4 100644 --- a/crates/ironrdp-dvc-pipe-proxy/src/windows/pipe.rs +++ b/crates/ironrdp-dvc-pipe-proxy/src/windows/pipe.rs @@ -1,4 +1,4 @@ -use core::ops::DerefMut; +use core::ops::DerefMut as _; use core::pin::Pin; use windows::core::{Owned, PCWSTR}; diff --git a/crates/ironrdp-dvc/src/lib.rs b/crates/ironrdp-dvc/src/lib.rs index 197aae03..5e8ca561 100644 --- a/crates/ironrdp-dvc/src/lib.rs +++ b/crates/ironrdp-dvc/src/lib.rs @@ -15,7 +15,7 @@ use core::any::TypeId; use pdu::DrdynvcDataPdu; -use crate::alloc::borrow::ToOwned; +use crate::alloc::borrow::ToOwned as _; // Re-export ironrdp_pdu crate for convenience #[rustfmt::skip] // do not re-order this pub use pub use ironrdp_pdu; diff --git a/crates/ironrdp-error/src/lib.rs b/crates/ironrdp-error/src/lib.rs index c2e13a33..4a051140 100644 --- a/crates/ironrdp-error/src/lib.rs +++ b/crates/ironrdp-error/src/lib.rs @@ -131,7 +131,7 @@ where Kind: core::error::Error, { fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { - use core::error::Error; + use core::error::Error as _; write!(f, "{}", self.0)?; diff --git a/crates/ironrdp-fuzzing/src/oracles/mod.rs b/crates/ironrdp-fuzzing/src/oracles/mod.rs index cd765af2..686d9eb0 100644 --- a/crates/ironrdp-fuzzing/src/oracles/mod.rs +++ b/crates/ironrdp-fuzzing/src/oracles/mod.rs @@ -137,7 +137,7 @@ pub fn cliprdr_format(input: &[u8]) { } pub fn channel_process(input: &[u8]) { - use ironrdp_svc::SvcProcessor; + use ironrdp_svc::SvcProcessor as _; let mut rdpdr = ironrdp_rdpdr::Rdpdr::new(Box::new(ironrdp_rdpdr::NoopRdpdrBackend), "Backend".to_owned()) .with_smartcard(1) diff --git a/crates/ironrdp-graphics/src/image_processing.rs b/crates/ironrdp-graphics/src/image_processing.rs index 85bd191a..1dc22bbf 100644 --- a/crates/ironrdp-graphics/src/image_processing.rs +++ b/crates/ironrdp-graphics/src/image_processing.rs @@ -1,7 +1,7 @@ use core::{cmp, fmt}; use std::io; -use byteorder::WriteBytesExt; +use byteorder::WriteBytesExt as _; use ironrdp_pdu::geometry::{InclusiveRectangle, Rectangle as _}; use num_derive::ToPrimitive; use num_traits::ToPrimitive as _; diff --git a/crates/ironrdp-graphics/src/rdp6/rle.rs b/crates/ironrdp-graphics/src/rdp6/rle.rs index 1c415adf..e423824a 100644 --- a/crates/ironrdp-graphics/src/rdp6/rle.rs +++ b/crates/ironrdp-graphics/src/rdp6/rle.rs @@ -1,7 +1,7 @@ use core::cmp; -use std::io::{Read, Write}; +use std::io::{Read as _, Write as _}; -use byteorder::ReadBytesExt; +use byteorder::ReadBytesExt as _; use ironrdp_core::WriteCursor; /// Maximum possible segment size is 47 (run_length = 2, raw_bytes_count = 15), which is treated as diff --git a/crates/ironrdp-graphics/src/zgfx/circular_buffer.rs b/crates/ironrdp-graphics/src/zgfx/circular_buffer.rs index face440e..99469da8 100644 --- a/crates/ironrdp-graphics/src/zgfx/circular_buffer.rs +++ b/crates/ironrdp-graphics/src/zgfx/circular_buffer.rs @@ -83,7 +83,7 @@ impl io::Write for FixedCircularBuffer { #[cfg(test)] mod tests { - use std::io::Write; + use std::io::Write as _; use super::*; diff --git a/crates/ironrdp-graphics/src/zgfx/control_messages.rs b/crates/ironrdp-graphics/src/zgfx/control_messages.rs index affe9346..52231929 100644 --- a/crates/ironrdp-graphics/src/zgfx/control_messages.rs +++ b/crates/ironrdp-graphics/src/zgfx/control_messages.rs @@ -1,4 +1,4 @@ -use bit_field::BitField; +use bit_field::BitField as _; use bitflags::bitflags; use byteorder::{LittleEndian, ReadBytesExt as _}; use num_derive::FromPrimitive; diff --git a/crates/ironrdp-graphics/src/zgfx/mod.rs b/crates/ironrdp-graphics/src/zgfx/mod.rs index d140b374..4e6a3e47 100644 --- a/crates/ironrdp-graphics/src/zgfx/mod.rs +++ b/crates/ironrdp-graphics/src/zgfx/mod.rs @@ -3,13 +3,13 @@ mod circular_buffer; mod control_messages; -use std::io::{self, Write}; +use std::io::{self, Write as _}; use bitvec::bits; use bitvec::field::BitField as _; use bitvec::order::Msb0; use bitvec::slice::BitSlice; -use byteorder::WriteBytesExt; +use byteorder::WriteBytesExt as _; use self::circular_buffer::FixedCircularBuffer; use self::control_messages::{BulkEncodedData, CompressionFlags, SegmentedDataPdu}; diff --git a/crates/ironrdp-pdu/src/basic_output/fast_path.rs b/crates/ironrdp-pdu/src/basic_output/fast_path.rs index 96787d32..12a5582a 100644 --- a/crates/ironrdp-pdu/src/basic_output/fast_path.rs +++ b/crates/ironrdp-pdu/src/basic_output/fast_path.rs @@ -1,14 +1,14 @@ #[cfg(test)] mod tests; -use bit_field::BitField; +use bit_field::BitField as _; use bitflags::bitflags; use ironrdp_core::{ decode_cursor, ensure_fixed_part_size, ensure_size, invalid_field_err, Decode, DecodeError, DecodeResult, Encode, - EncodeResult, InvalidFieldErr, ReadCursor, WriteCursor, + EncodeResult, InvalidFieldErr as _, ReadCursor, WriteCursor, }; use num_derive::{FromPrimitive, ToPrimitive}; -use num_traits::{FromPrimitive, ToPrimitive}; +use num_traits::{FromPrimitive as _, ToPrimitive as _}; use super::bitmap::BitmapUpdateData; use super::pointer::PointerUpdateData; diff --git a/crates/ironrdp-pdu/src/codecs/rfx/data_messages.rs b/crates/ironrdp-pdu/src/codecs/rfx/data_messages.rs index 796d0602..8e33da9a 100644 --- a/crates/ironrdp-pdu/src/codecs/rfx/data_messages.rs +++ b/crates/ironrdp-pdu/src/codecs/rfx/data_messages.rs @@ -1,11 +1,11 @@ -use bit_field::BitField; +use bit_field::BitField as _; use bitflags::bitflags; use ironrdp_core::{ cast_length, ensure_fixed_part_size, ensure_size, invalid_field_err, Decode, DecodeResult, Encode, EncodeResult, ReadCursor, WriteCursor, }; use num_derive::{FromPrimitive, ToPrimitive}; -use num_traits::{FromPrimitive, ToPrimitive}; +use num_traits::{FromPrimitive as _, ToPrimitive as _}; use crate::codecs::rfx::Block; diff --git a/crates/ironrdp-pdu/src/gcc/core_data/client.rs b/crates/ironrdp-pdu/src/gcc/core_data/client.rs index 90401dbb..e207086b 100644 --- a/crates/ironrdp-pdu/src/gcc/core_data/client.rs +++ b/crates/ironrdp-pdu/src/gcc/core_data/client.rs @@ -4,7 +4,7 @@ use ironrdp_core::{ ReadCursor, WriteCursor, }; use num_derive::{FromPrimitive, ToPrimitive}; -use num_traits::{FromPrimitive, ToPrimitive}; +use num_traits::{FromPrimitive as _, ToPrimitive as _}; use tap::Pipe as _; use super::{RdpVersion, VERSION_SIZE}; diff --git a/crates/ironrdp-pdu/src/gcc/monitor_extended_data.rs b/crates/ironrdp-pdu/src/gcc/monitor_extended_data.rs index 629c78ad..313ece7a 100644 --- a/crates/ironrdp-pdu/src/gcc/monitor_extended_data.rs +++ b/crates/ironrdp-pdu/src/gcc/monitor_extended_data.rs @@ -3,7 +3,7 @@ use ironrdp_core::{ ReadCursor, WriteCursor, }; use num_derive::{FromPrimitive, ToPrimitive}; -use num_traits::{FromPrimitive, ToPrimitive}; +use num_traits::{FromPrimitive as _, ToPrimitive as _}; const MONITOR_COUNT_MAX: usize = 16; const MONITOR_ATTRIBUTE_SIZE: u32 = 20; diff --git a/crates/ironrdp-pdu/src/gcc/network_data.rs b/crates/ironrdp-pdu/src/gcc/network_data.rs index 6f6b500e..33b6d387 100644 --- a/crates/ironrdp-pdu/src/gcc/network_data.rs +++ b/crates/ironrdp-pdu/src/gcc/network_data.rs @@ -6,7 +6,7 @@ use ironrdp_core::{ cast_length, ensure_fixed_part_size, ensure_size, invalid_field_err, read_padding, write_padding, Decode, DecodeResult, Encode, EncodeResult, ReadCursor, WriteCursor, }; -use num_integer::Integer; +use num_integer::Integer as _; use thiserror::Error; const CHANNELS_MAX: usize = 31; diff --git a/crates/ironrdp-pdu/src/gcc/security_data.rs b/crates/ironrdp-pdu/src/gcc/security_data.rs index 243b8efd..cb269a84 100644 --- a/crates/ironrdp-pdu/src/gcc/security_data.rs +++ b/crates/ironrdp-pdu/src/gcc/security_data.rs @@ -6,7 +6,7 @@ use ironrdp_core::{ ReadCursor, WriteCursor, }; use num_derive::{FromPrimitive, ToPrimitive}; -use num_traits::{FromPrimitive, ToPrimitive}; +use num_traits::{FromPrimitive as _, ToPrimitive as _}; use thiserror::Error; const CLIENT_ENCRYPTION_METHODS_SIZE: usize = 4; diff --git a/crates/ironrdp-pdu/src/input/fast_path.rs b/crates/ironrdp-pdu/src/input/fast_path.rs index 0791e4d5..705d4dfa 100644 --- a/crates/ironrdp-pdu/src/input/fast_path.rs +++ b/crates/ironrdp-pdu/src/input/fast_path.rs @@ -1,11 +1,11 @@ -use bit_field::BitField; +use bit_field::BitField as _; use bitflags::bitflags; use ironrdp_core::{ cast_length, ensure_fixed_part_size, ensure_size, invalid_field_err, other_err, Decode, DecodeResult, Encode, EncodeResult, ReadCursor, WriteCursor, }; use num_derive::{FromPrimitive, ToPrimitive}; -use num_traits::{FromPrimitive, ToPrimitive}; +use num_traits::{FromPrimitive as _, ToPrimitive as _}; use crate::fast_path::EncryptionFlags; use crate::input::{MousePdu, MouseRelPdu, MouseXPdu}; diff --git a/crates/ironrdp-pdu/src/input/mod.rs b/crates/ironrdp-pdu/src/input/mod.rs index 76382269..a3d168d2 100644 --- a/crates/ironrdp-pdu/src/input/mod.rs +++ b/crates/ironrdp-pdu/src/input/mod.rs @@ -5,7 +5,7 @@ use ironrdp_core::{ EncodeResult, ReadCursor, WriteCursor, }; use num_derive::{FromPrimitive, ToPrimitive}; -use num_traits::{FromPrimitive, ToPrimitive}; +use num_traits::{FromPrimitive as _, ToPrimitive as _}; use thiserror::Error; pub mod fast_path; diff --git a/crates/ironrdp-pdu/src/per.rs b/crates/ironrdp-pdu/src/per.rs index d4ea96b0..9f1deb8a 100644 --- a/crates/ironrdp-pdu/src/per.rs +++ b/crates/ironrdp-pdu/src/per.rs @@ -316,7 +316,7 @@ pub(crate) fn write_numeric_string(dst: &mut WriteCursor<'_>, num_str: &[u8], mi pub(crate) mod legacy { use std::io; - use byteorder::{BigEndian, ReadBytesExt, WriteBytesExt}; + use byteorder::{BigEndian, ReadBytesExt as _, WriteBytesExt as _}; use super::OBJECT_ID_SIZE; diff --git a/crates/ironrdp-pdu/src/rdp/capability_sets/bitmap_codecs.rs b/crates/ironrdp-pdu/src/rdp/capability_sets/bitmap_codecs.rs index 720d00bf..d7242f71 100644 --- a/crates/ironrdp-pdu/src/rdp/capability_sets/bitmap_codecs.rs +++ b/crates/ironrdp-pdu/src/rdp/capability_sets/bitmap_codecs.rs @@ -10,7 +10,7 @@ use ironrdp_core::{ Encode, EncodeResult, ReadCursor, WriteCursor, }; use num_derive::{FromPrimitive, ToPrimitive}; -use num_traits::{FromPrimitive, ToPrimitive}; +use num_traits::{FromPrimitive as _, ToPrimitive as _}; const RFX_ICAP_VERSION: u16 = 0x0100; const RFX_ICAP_TILE_SIZE: u16 = 0x40; diff --git a/crates/ironrdp-pdu/src/rdp/capability_sets/brush.rs b/crates/ironrdp-pdu/src/rdp/capability_sets/brush.rs index aacde709..fd2daca9 100644 --- a/crates/ironrdp-pdu/src/rdp/capability_sets/brush.rs +++ b/crates/ironrdp-pdu/src/rdp/capability_sets/brush.rs @@ -5,7 +5,7 @@ use ironrdp_core::{ ensure_fixed_part_size, invalid_field_err, Decode, DecodeResult, Encode, EncodeResult, ReadCursor, WriteCursor, }; use num_derive::{FromPrimitive, ToPrimitive}; -use num_traits::{FromPrimitive, ToPrimitive}; +use num_traits::{FromPrimitive as _, ToPrimitive as _}; const BRUSH_LENGTH: usize = 4; diff --git a/crates/ironrdp-pdu/src/rdp/capability_sets/glyph_cache.rs b/crates/ironrdp-pdu/src/rdp/capability_sets/glyph_cache.rs index 0ad26a2b..fe11b059 100644 --- a/crates/ironrdp-pdu/src/rdp/capability_sets/glyph_cache.rs +++ b/crates/ironrdp-pdu/src/rdp/capability_sets/glyph_cache.rs @@ -6,7 +6,7 @@ use ironrdp_core::{ WriteCursor, }; use num_derive::{FromPrimitive, ToPrimitive}; -use num_traits::{FromPrimitive, ToPrimitive}; +use num_traits::{FromPrimitive as _, ToPrimitive as _}; pub const GLYPH_CACHE_NUM: usize = 10; diff --git a/crates/ironrdp-pdu/src/rdp/capability_sets/input.rs b/crates/ironrdp-pdu/src/rdp/capability_sets/input.rs index fe1cdee8..ab8341c1 100644 --- a/crates/ironrdp-pdu/src/rdp/capability_sets/input.rs +++ b/crates/ironrdp-pdu/src/rdp/capability_sets/input.rs @@ -6,7 +6,7 @@ use ironrdp_core::{ ensure_fixed_part_size, read_padding, write_padding, Decode, DecodeResult, Encode, EncodeResult, ReadCursor, WriteCursor, }; -use num_traits::{FromPrimitive, ToPrimitive}; +use num_traits::{FromPrimitive as _, ToPrimitive as _}; use crate::gcc::{KeyboardType, IME_FILE_NAME_SIZE}; use crate::utils; diff --git a/crates/ironrdp-pdu/src/rdp/headers.rs b/crates/ironrdp-pdu/src/rdp/headers.rs index 0f6b9474..5632c1d1 100644 --- a/crates/ironrdp-pdu/src/rdp/headers.rs +++ b/crates/ironrdp-pdu/src/rdp/headers.rs @@ -4,7 +4,7 @@ use ironrdp_core::{ write_padding, Decode, DecodeResult, Encode, EncodeResult, ReadCursor, WriteCursor, }; use num_derive::{FromPrimitive, ToPrimitive}; -use num_traits::{FromPrimitive, ToPrimitive}; +use num_traits::{FromPrimitive as _, ToPrimitive as _}; use crate::codecs::rfx::FrameAcknowledgePdu; use crate::input::InputEventPdu; diff --git a/crates/ironrdp-pdu/src/rdp/server_license.rs b/crates/ironrdp-pdu/src/rdp/server_license.rs index 071fceb2..2ec3dd6d 100644 --- a/crates/ironrdp-pdu/src/rdp/server_license.rs +++ b/crates/ironrdp-pdu/src/rdp/server_license.rs @@ -5,9 +5,9 @@ use ironrdp_core::{ cast_length, ensure_fixed_part_size, invalid_field_err, unsupported_value_err, Decode, DecodeResult, Encode, EncodeResult, ReadCursor, WriteCursor, }; -use md5::Digest; +use md5::Digest as _; use num_derive::{FromPrimitive, ToPrimitive}; -use num_traits::{FromPrimitive, ToPrimitive}; +use num_traits::{FromPrimitive as _, ToPrimitive as _}; use thiserror::Error; use crate::rdp::headers::{BasicSecurityHeader, BasicSecurityHeaderFlags, BASIC_SECURITY_HEADER_SIZE}; diff --git a/crates/ironrdp-pdu/src/rdp/server_license/client_license_info.rs b/crates/ironrdp-pdu/src/rdp/server_license/client_license_info.rs index 74c519d0..19bb9633 100644 --- a/crates/ironrdp-pdu/src/rdp/server_license/client_license_info.rs +++ b/crates/ironrdp-pdu/src/rdp/server_license/client_license_info.rs @@ -1,10 +1,10 @@ use std::io; -use byteorder::{LittleEndian, WriteBytesExt}; +use byteorder::{LittleEndian, WriteBytesExt as _}; use ironrdp_core::{ - ensure_size, invalid_field_err, Decode, DecodeResult, Encode, EncodeResult, ReadCursor, WriteCursor, + ensure_size, invalid_field_err, Decode as _, DecodeResult, Encode as _, EncodeResult, ReadCursor, WriteCursor, }; -use md5::Digest; +use md5::Digest as _; use crate::crypto::rc4::Rc4; use crate::crypto::rsa::encrypt_with_public_key; diff --git a/crates/ironrdp-pdu/src/rdp/server_license/client_new_license_request.rs b/crates/ironrdp-pdu/src/rdp/server_license/client_new_license_request.rs index 4d1930a9..883353c0 100644 --- a/crates/ironrdp-pdu/src/rdp/server_license/client_new_license_request.rs +++ b/crates/ironrdp-pdu/src/rdp/server_license/client_new_license_request.rs @@ -5,9 +5,9 @@ use std::io; use bitflags::bitflags; use ironrdp_core::{ - ensure_size, invalid_field_err, Decode, DecodeResult, Encode, EncodeResult, ReadCursor, WriteCursor, + ensure_size, invalid_field_err, Decode as _, DecodeResult, Encode as _, EncodeResult, ReadCursor, WriteCursor, }; -use md5::Digest; +use md5::Digest as _; use super::{ BasicSecurityHeader, BasicSecurityHeaderFlags, BlobHeader, BlobType, LicenseEncryptionData, LicenseHeader, diff --git a/crates/ironrdp-pdu/src/rdp/server_license/client_new_license_request/tests.rs b/crates/ironrdp-pdu/src/rdp/server_license/client_new_license_request/tests.rs index 70334a50..187c03db 100644 --- a/crates/ironrdp-pdu/src/rdp/server_license/client_new_license_request/tests.rs +++ b/crates/ironrdp-pdu/src/rdp/server_license/client_new_license_request/tests.rs @@ -1,4 +1,4 @@ -use byteorder::{LittleEndian, WriteBytesExt}; +use byteorder::{LittleEndian, WriteBytesExt as _}; use ironrdp_core::{decode, encode_vec}; use lazy_static::lazy_static; diff --git a/crates/ironrdp-pdu/src/rdp/server_license/client_platform_challenge_response.rs b/crates/ironrdp-pdu/src/rdp/server_license/client_platform_challenge_response.rs index 9498e351..3a6e8cb3 100644 --- a/crates/ironrdp-pdu/src/rdp/server_license/client_platform_challenge_response.rs +++ b/crates/ironrdp-pdu/src/rdp/server_license/client_platform_challenge_response.rs @@ -1,7 +1,7 @@ #[cfg(test)] mod test; -use std::io::Write; +use std::io::Write as _; use byteorder::{LittleEndian, WriteBytesExt as _}; use ironrdp_core::{ diff --git a/crates/ironrdp-pdu/src/rdp/server_license/licensing_error_message.rs b/crates/ironrdp-pdu/src/rdp/server_license/licensing_error_message.rs index b6fb40f0..dd2a07b7 100644 --- a/crates/ironrdp-pdu/src/rdp/server_license/licensing_error_message.rs +++ b/crates/ironrdp-pdu/src/rdp/server_license/licensing_error_message.rs @@ -2,11 +2,11 @@ mod test; use ironrdp_core::{ - cast_length, ensure_fixed_part_size, ensure_size, invalid_field_err, Decode, DecodeResult, Encode, EncodeResult, - ReadCursor, WriteCursor, + cast_length, ensure_fixed_part_size, ensure_size, invalid_field_err, Decode as _, DecodeResult, Encode as _, + EncodeResult, ReadCursor, WriteCursor, }; use num_derive::{FromPrimitive, ToPrimitive}; -use num_traits::{FromPrimitive, ToPrimitive}; +use num_traits::{FromPrimitive as _, ToPrimitive as _}; use super::{BlobHeader, BlobType, LicenseHeader, PreambleFlags, PreambleVersion, BLOB_LENGTH_SIZE, BLOB_TYPE_SIZE}; use crate::rdp::headers::{BasicSecurityHeader, BasicSecurityHeaderFlags, BASIC_SECURITY_HEADER_SIZE}; diff --git a/crates/ironrdp-pdu/src/rdp/server_license/server_license_request/tests.rs b/crates/ironrdp-pdu/src/rdp/server_license/server_license_request/tests.rs index 87416433..7119bb98 100644 --- a/crates/ironrdp-pdu/src/rdp/server_license/server_license_request/tests.rs +++ b/crates/ironrdp-pdu/src/rdp/server_license/server_license_request/tests.rs @@ -1,4 +1,4 @@ -use ironrdp_core::{decode, encode_vec, Encode}; +use ironrdp_core::{decode, encode_vec, Encode as _}; use lazy_static::lazy_static; use super::cert::{RsaPublicKey, PROP_CERT_BLOBS_HEADERS_SIZE, PROP_CERT_NO_BLOBS_SIZE, RSA_KEY_SIZE_WITHOUT_MODULUS}; diff --git a/crates/ironrdp-pdu/src/rdp/server_license/server_platform_challenge.rs b/crates/ironrdp-pdu/src/rdp/server_license/server_platform_challenge.rs index 658558e8..eae89b90 100644 --- a/crates/ironrdp-pdu/src/rdp/server_license/server_platform_challenge.rs +++ b/crates/ironrdp-pdu/src/rdp/server_license/server_platform_challenge.rs @@ -2,7 +2,7 @@ mod test; use ironrdp_core::{ - ensure_size, invalid_field_err, Decode, DecodeResult, Encode, EncodeResult, ReadCursor, WriteCursor, + ensure_size, invalid_field_err, Decode as _, DecodeResult, Encode as _, EncodeResult, ReadCursor, WriteCursor, }; use super::{BlobHeader, BlobType, LicenseHeader, PreambleType, BLOB_LENGTH_SIZE, BLOB_TYPE_SIZE, MAC_SIZE}; diff --git a/crates/ironrdp-pdu/src/rdp/session_info/logon_extended.rs b/crates/ironrdp-pdu/src/rdp/session_info/logon_extended.rs index dffe5950..b9fbb7a6 100644 --- a/crates/ironrdp-pdu/src/rdp/session_info/logon_extended.rs +++ b/crates/ironrdp-pdu/src/rdp/session_info/logon_extended.rs @@ -4,7 +4,7 @@ use ironrdp_core::{ EncodeResult, ReadCursor, WriteCursor, }; use num_derive::{FromPrimitive, ToPrimitive}; -use num_traits::{FromPrimitive, ToPrimitive}; +use num_traits::{FromPrimitive as _, ToPrimitive as _}; const LOGON_EX_LENGTH_FIELD_SIZE: usize = 2; const LOGON_EX_FLAGS_FIELD_SIZE: usize = 4; diff --git a/crates/ironrdp-pdu/src/rdp/session_info/tests.rs b/crates/ironrdp-pdu/src/rdp/session_info/tests.rs index ddb8a3f9..e5db624f 100644 --- a/crates/ironrdp-pdu/src/rdp/session_info/tests.rs +++ b/crates/ironrdp-pdu/src/rdp/session_info/tests.rs @@ -1,4 +1,4 @@ -use ironrdp_core::{decode, encode_vec, DecodeErrorKind, Encode}; +use ironrdp_core::{decode, encode_vec, DecodeErrorKind, Encode as _}; use lazy_static::lazy_static; use super::*; diff --git a/crates/ironrdp-pdu/src/rdp/vc/dvc/gfx/graphics_messages/avc_messages.rs b/crates/ironrdp-pdu/src/rdp/vc/dvc/gfx/graphics_messages/avc_messages.rs index ace2d9a8..501c44c3 100644 --- a/crates/ironrdp-pdu/src/rdp/vc/dvc/gfx/graphics_messages/avc_messages.rs +++ b/crates/ironrdp-pdu/src/rdp/vc/dvc/gfx/graphics_messages/avc_messages.rs @@ -1,6 +1,6 @@ use core::fmt::Debug; -use bit_field::BitField; +use bit_field::BitField as _; use bitflags::bitflags; use ironrdp_core::{ cast_length, ensure_fixed_part_size, ensure_size, invalid_field_err, Decode, DecodeResult, Encode, EncodeResult, diff --git a/crates/ironrdp-pdu/src/rdp/vc/dvc/gfx/graphics_messages/server.rs b/crates/ironrdp-pdu/src/rdp/vc/dvc/gfx/graphics_messages/server.rs index 3e8e219b..8e366ff1 100644 --- a/crates/ironrdp-pdu/src/rdp/vc/dvc/gfx/graphics_messages/server.rs +++ b/crates/ironrdp-pdu/src/rdp/vc/dvc/gfx/graphics_messages/server.rs @@ -1,12 +1,12 @@ use std::fmt; -use bit_field::BitField; +use bit_field::BitField as _; use ironrdp_core::{ cast_length, decode_cursor, ensure_fixed_part_size, ensure_size, invalid_field_err, read_padding, write_padding, Decode, DecodeResult, Encode, EncodeResult, ReadCursor, WriteCursor, }; use num_derive::{FromPrimitive, ToPrimitive}; -use num_traits::{FromPrimitive, ToPrimitive}; +use num_traits::{FromPrimitive as _, ToPrimitive as _}; use super::{CapabilitySet, Color, Point, RDP_GFX_HEADER_SIZE}; use crate::gcc::Monitor; diff --git a/crates/ironrdp-rdpfile/src/lib.rs b/crates/ironrdp-rdpfile/src/lib.rs index 82ca2d75..37519259 100644 --- a/crates/ironrdp-rdpfile/src/lib.rs +++ b/crates/ironrdp-rdpfile/src/lib.rs @@ -4,8 +4,8 @@ extern crate alloc; -use alloc::borrow::ToOwned; -use alloc::string::{String, ToString}; +use alloc::borrow::ToOwned as _; +use alloc::string::{String, ToString as _}; use alloc::vec::Vec; use core::fmt; diff --git a/crates/ironrdp-rdpsnd-native/examples/cpal.rs b/crates/ironrdp-rdpsnd-native/examples/cpal.rs index ac96d11b..e7d2f479 100644 --- a/crates/ironrdp-rdpsnd-native/examples/cpal.rs +++ b/crates/ironrdp-rdpsnd-native/examples/cpal.rs @@ -4,8 +4,8 @@ use core::time::Duration; use std::sync::mpsc; use std::thread; -use anyhow::Context; -use cpal::traits::StreamTrait; +use anyhow::Context as _; +use cpal::traits::StreamTrait as _; use ironrdp_rdpsnd::pdu::{AudioFormat, WaveFormat}; use ironrdp_rdpsnd_native::cpal::DecodeStream; use tracing::debug; diff --git a/crates/ironrdp-rdpsnd-native/src/cpal.rs b/crates/ironrdp-rdpsnd-native/src/cpal.rs index 7c9a8ee8..768b0669 100644 --- a/crates/ironrdp-rdpsnd-native/src/cpal.rs +++ b/crates/ironrdp-rdpsnd-native/src/cpal.rs @@ -6,8 +6,8 @@ use std::sync::mpsc::{self, Receiver, Sender}; use std::sync::Arc; use std::thread::{self, JoinHandle}; -use anyhow::{bail, Context}; -use cpal::traits::{DeviceTrait, HostTrait}; +use anyhow::{bail, Context as _}; +use cpal::traits::{DeviceTrait as _, HostTrait as _}; use cpal::{SampleFormat, Stream, StreamConfig}; use ironrdp_rdpsnd::client::RdpsndClientHandler; use ironrdp_rdpsnd::pdu::{AudioFormat, PitchPdu, VolumePdu, WaveFormat}; diff --git a/crates/ironrdp-rdpsnd/src/client.rs b/crates/ironrdp-rdpsnd/src/client.rs index fb6f6b21..b90e7dc9 100644 --- a/crates/ironrdp-rdpsnd/src/client.rs +++ b/crates/ironrdp-rdpsnd/src/client.rs @@ -1,7 +1,7 @@ use std::borrow::Cow; use std::collections::HashSet; -use ironrdp_core::{cast_length, impl_as_any, Decode, EncodeResult, ReadCursor}; +use ironrdp_core::{cast_length, impl_as_any, Decode as _, EncodeResult, ReadCursor}; use ironrdp_pdu::gcc::ChannelName; use ironrdp_pdu::{decode_err, encode_err, pdu_other_err, PduResult}; use ironrdp_svc::{CompressionCondition, SvcClientProcessor, SvcMessage, SvcProcessor}; diff --git a/crates/ironrdp-rdpsnd/src/server.rs b/crates/ironrdp-rdpsnd/src/server.rs index 1e8103d4..435b4c57 100644 --- a/crates/ironrdp-rdpsnd/src/server.rs +++ b/crates/ironrdp-rdpsnd/src/server.rs @@ -1,4 +1,4 @@ -use ironrdp_core::{impl_as_any, Decode, ReadCursor}; +use ironrdp_core::{impl_as_any, Decode as _, ReadCursor}; use ironrdp_pdu::gcc::ChannelName; use ironrdp_pdu::{decode_err, pdu_other_err, PduResult}; use ironrdp_svc::{CompressionCondition, SvcMessage, SvcProcessor, SvcProcessorMessages, SvcServerProcessor}; diff --git a/crates/ironrdp-server/src/encoder/bitmap.rs b/crates/ironrdp-server/src/encoder/bitmap.rs index bda338e5..9a1647d0 100644 --- a/crates/ironrdp-server/src/encoder/bitmap.rs +++ b/crates/ironrdp-server/src/encoder/bitmap.rs @@ -1,6 +1,6 @@ use core::num::NonZeroUsize; -use ironrdp_core::{invalid_field_err, Encode, EncodeResult, WriteCursor}; +use ironrdp_core::{invalid_field_err, Encode as _, EncodeResult, WriteCursor}; use ironrdp_graphics::image_processing::PixelFormat; use ironrdp_graphics::rdp6::{ABgrChannels, ARgbChannels, BgrAChannels, BitmapStreamEncoder, RgbAChannels}; use ironrdp_pdu::bitmap::{self, BitmapData, BitmapUpdateData, Compression}; diff --git a/crates/ironrdp-server/src/encoder/fast_path.rs b/crates/ironrdp-server/src/encoder/fast_path.rs index d348b7e7..90ed98e4 100644 --- a/crates/ironrdp-server/src/encoder/fast_path.rs +++ b/crates/ironrdp-server/src/encoder/fast_path.rs @@ -1,7 +1,7 @@ use core::{cmp, fmt}; use ironrdp_pdu::fast_path::{EncryptionFlags, FastPathHeader, FastPathUpdatePdu, Fragmentation, UpdateCode}; -use ironrdp_pdu::{Encode, WriteCursor}; +use ironrdp_pdu::{Encode as _, WriteCursor}; // this is the maximum amount of data (not including headers) we can send in a single TS_FP_UPDATE_PDU const MAX_FASTPATH_UPDATE_SIZE: usize = 16_374; diff --git a/crates/ironrdp-server/src/encoder/mod.rs b/crates/ironrdp-server/src/encoder/mod.rs index af12bf15..0f730dd8 100644 --- a/crates/ironrdp-server/src/encoder/mod.rs +++ b/crates/ironrdp-server/src/encoder/mod.rs @@ -2,7 +2,7 @@ use core::fmt; use core::num::NonZeroU16; use std::sync::{Arc, Mutex}; -use anyhow::{anyhow, Context, Result}; +use anyhow::{anyhow, Context as _, Result}; use ironrdp_acceptor::DesktopSize; use ironrdp_graphics::diff::{find_different_rects_sub, Rect}; use ironrdp_pdu::encode_vec; diff --git a/crates/ironrdp-server/src/encoder/rfx.rs b/crates/ironrdp-server/src/encoder/rfx.rs index 220ed9e8..4f9cf289 100644 --- a/crates/ironrdp-server/src/encoder/rfx.rs +++ b/crates/ironrdp-server/src/encoder/rfx.rs @@ -1,5 +1,5 @@ use ironrdp_acceptor::DesktopSize; -use ironrdp_core::{cast_length, other_err, Encode, EncodeResult}; +use ironrdp_core::{cast_length, other_err, Encode as _, EncodeResult}; use ironrdp_graphics::color_conversion::to_64x64_ycbcr_tile; use ironrdp_graphics::rfx_encode_component; use ironrdp_graphics::rlgr::RlgrError; diff --git a/crates/ironrdp-server/src/helper.rs b/crates/ironrdp-server/src/helper.rs index 5dc23261..38b76fa3 100644 --- a/crates/ironrdp-server/src/helper.rs +++ b/crates/ironrdp-server/src/helper.rs @@ -3,9 +3,9 @@ use std::io::BufReader; use std::path::Path; use std::sync::Arc; -use anyhow::Context; +use anyhow::Context as _; use rustls_pemfile::{certs, pkcs8_private_keys}; -use tokio_rustls::rustls::pki_types::pem::PemObject; +use tokio_rustls::rustls::pki_types::pem::PemObject as _; use tokio_rustls::rustls::pki_types::{CertificateDer, PrivateKeyDer}; use tokio_rustls::rustls::{self}; use tokio_rustls::TlsAcceptor; diff --git a/crates/ironrdp-server/src/server.rs b/crates/ironrdp-server/src/server.rs index 54a8e79d..188a23af 100644 --- a/crates/ironrdp-server/src/server.rs +++ b/crates/ironrdp-server/src/server.rs @@ -2,7 +2,7 @@ use core::net::SocketAddr; use std::rc::Rc; use std::sync::Arc; -use anyhow::{anyhow, bail, Context, Result}; +use anyhow::{anyhow, bail, Context as _, Result}; use ironrdp_acceptor::{self, Acceptor, AcceptorResult, BeginResult, DesktopSize}; use ironrdp_async::{bytes, Framed}; use ironrdp_cliprdr::backend::ClipboardMessage; diff --git a/crates/ironrdp-session/src/active_stage.rs b/crates/ironrdp-session/src/active_stage.rs index 4fd7c567..1c38334d 100644 --- a/crates/ironrdp-session/src/active_stage.rs +++ b/crates/ironrdp-session/src/active_stage.rs @@ -14,7 +14,7 @@ use ironrdp_svc::{SvcMessage, SvcProcessor, SvcProcessorMessages}; use crate::fast_path::UpdateKind; use crate::image::DecodedImage; -use crate::{fast_path, x224, SessionError, SessionErrorExt, SessionResult}; +use crate::{fast_path, x224, SessionError, SessionErrorExt as _, SessionResult}; pub struct ActiveStage { x224_processor: x224::Processor, diff --git a/crates/ironrdp-session/src/fast_path.rs b/crates/ironrdp-session/src/fast_path.rs index 229108fd..1baa685d 100644 --- a/crates/ironrdp-session/src/fast_path.rs +++ b/crates/ironrdp-session/src/fast_path.rs @@ -15,7 +15,7 @@ use ironrdp_pdu::surface_commands::{FrameAction, FrameMarkerPdu, SurfaceCommand} use crate::image::DecodedImage; use crate::pointer::PointerCache; -use crate::{rfx, SessionError, SessionErrorExt, SessionResult}; +use crate::{rfx, SessionError, SessionErrorExt as _, SessionResult}; #[derive(Debug)] pub enum UpdateKind { diff --git a/crates/ironrdp-session/src/rfx.rs b/crates/ironrdp-session/src/rfx.rs index 16e808f5..d4c9267b 100644 --- a/crates/ironrdp-session/src/rfx.rs +++ b/crates/ironrdp-session/src/rfx.rs @@ -5,8 +5,8 @@ use ironrdp_graphics::image_processing::PixelFormat; use ironrdp_graphics::rectangle_processing::Region; use ironrdp_graphics::{dwt, quantization, rlgr, subband_reconstruction}; use ironrdp_pdu::codecs::rfx::{self, EntropyAlgorithm, Quant, RfxRectangle, Tile}; -use ironrdp_pdu::geometry::{InclusiveRectangle, Rectangle}; -use ironrdp_pdu::{decode_cursor, Decode, ReadCursor}; +use ironrdp_pdu::geometry::{InclusiveRectangle, Rectangle as _}; +use ironrdp_pdu::{decode_cursor, Decode as _, ReadCursor}; use crate::image::DecodedImage; use crate::SessionResult; diff --git a/crates/ironrdp-testsuite-core/tests/pdu/gcc.rs b/crates/ironrdp-testsuite-core/tests/pdu/gcc.rs index 03ef10d2..718ccca9 100644 --- a/crates/ironrdp-testsuite-core/tests/pdu/gcc.rs +++ b/crates/ironrdp-testsuite-core/tests/pdu/gcc.rs @@ -1,4 +1,4 @@ -use ironrdp_core::{decode, encode_vec, DecodeErrorKind, Encode, EncodeErrorKind, ReadCursor}; +use ironrdp_core::{decode, encode_vec, DecodeErrorKind, Encode as _, EncodeErrorKind, ReadCursor}; use ironrdp_pdu::gcc::*; use ironrdp_testsuite_core::cluster_data::*; use ironrdp_testsuite_core::conference_create::*; diff --git a/crates/ironrdp-testsuite-core/tests/pdu/gfx.rs b/crates/ironrdp-testsuite-core/tests/pdu/gfx.rs index 21f0cf99..098d3c1d 100644 --- a/crates/ironrdp-testsuite-core/tests/pdu/gfx.rs +++ b/crates/ironrdp-testsuite-core/tests/pdu/gfx.rs @@ -1,4 +1,4 @@ -use ironrdp_core::{decode, decode_cursor, encode_vec, Encode, ReadCursor}; +use ironrdp_core::{decode, decode_cursor, encode_vec, Encode as _, ReadCursor}; use ironrdp_testsuite_core::gfx::*; use ironrdp_testsuite_core::graphics_messages::*; diff --git a/crates/ironrdp-testsuite-core/tests/pdu/mcs.rs b/crates/ironrdp-testsuite-core/tests/pdu/mcs.rs index fc994c22..fc2a3c37 100644 --- a/crates/ironrdp-testsuite-core/tests/pdu/mcs.rs +++ b/crates/ironrdp-testsuite-core/tests/pdu/mcs.rs @@ -1,5 +1,5 @@ use expect_test::expect; -use ironrdp_core::{decode, encode_vec, Encode}; +use ironrdp_core::{decode, encode_vec, Encode as _}; use ironrdp_pdu::mcs::*; use ironrdp_testsuite_core::mcs::*; use ironrdp_testsuite_core::mcs_encode_decode_test; diff --git a/crates/ironrdp-testsuite-core/tests/pdu/rdp.rs b/crates/ironrdp-testsuite-core/tests/pdu/rdp.rs index 3dfecfb5..f9fc45df 100644 --- a/crates/ironrdp-testsuite-core/tests/pdu/rdp.rs +++ b/crates/ironrdp-testsuite-core/tests/pdu/rdp.rs @@ -1,4 +1,4 @@ -use ironrdp_core::{decode, encode_vec, Encode}; +use ironrdp_core::{decode, encode_vec, Encode as _}; use ironrdp_testsuite_core::capsets::*; use ironrdp_testsuite_core::client_info::*; use ironrdp_testsuite_core::rdp::*; diff --git a/crates/ironrdp-testsuite-extra/tests/tests.rs b/crates/ironrdp-testsuite-extra/tests/tests.rs index 53cbfc11..6c3ec042 100644 --- a/crates/ironrdp-testsuite-extra/tests/tests.rs +++ b/crates/ironrdp-testsuite-extra/tests/tests.rs @@ -14,7 +14,7 @@ use ironrdp::server::{ }; use ironrdp::session::image::DecodedImage; use ironrdp::session::{self, ActiveStage, ActiveStageOutput}; -use ironrdp_async::{Framed, FramedWrite}; +use ironrdp_async::{Framed, FramedWrite as _}; use ironrdp_testsuite_extra as _; use ironrdp_tls::TlsStream; use ironrdp_tokio::TokioStream; diff --git a/crates/ironrdp-tokio/src/reqwest.rs b/crates/ironrdp-tokio/src/reqwest.rs index cca0a121..9758f666 100644 --- a/crates/ironrdp-tokio/src/reqwest.rs +++ b/crates/ironrdp-tokio/src/reqwest.rs @@ -5,7 +5,7 @@ use core::pin::Pin; use ironrdp_connector::{custom_err, ConnectorResult}; use reqwest::Client; use sspi::{Error, ErrorKind}; -use tokio::io::{AsyncReadExt, AsyncWriteExt}; +use tokio::io::{AsyncReadExt as _, AsyncWriteExt as _}; use tokio::net::{TcpStream, UdpSocket}; use url::Url; diff --git a/crates/ironrdp-web/src/clipboard.rs b/crates/ironrdp-web/src/clipboard.rs index 26a9a958..808e829f 100644 --- a/crates/ironrdp-web/src/clipboard.rs +++ b/crates/ironrdp-web/src/clipboard.rs @@ -21,7 +21,7 @@ use ironrdp::cliprdr::pdu::{ }; use ironrdp_cliprdr_format::bitmap::{dib_to_png, dibv5_to_png, png_to_cf_dibv5}; use ironrdp_cliprdr_format::html::{cf_html_to_plain_html, plain_html_to_cf_html}; -use ironrdp_core::{impl_as_any, IntoOwned}; +use ironrdp_core::{impl_as_any, IntoOwned as _}; use wasm_bindgen::prelude::*; use crate::session::RdpInputEvent; diff --git a/ffi/build.rs b/ffi/build.rs index eff43a38..4f2cacea 100644 --- a/ffi/build.rs +++ b/ffi/build.rs @@ -11,7 +11,7 @@ fn main() { mod win { use std::env; use std::fs::File; - use std::io::Write; + use std::io::Write as _; fn generate_version_rc() -> String { let output_name = "DevolutionsIronRdp"; diff --git a/ffi/src/connector/activation.rs b/ffi/src/connector/activation.rs index 2967feee..4ce2a368 100644 --- a/ffi/src/connector/activation.rs +++ b/ffi/src/connector/activation.rs @@ -1,6 +1,6 @@ #[diplomat::bridge] pub mod ffi { - use ironrdp::connector::Sequence; + use ironrdp::connector::Sequence as _; use crate::connector::config::ffi::DesktopSize; use crate::connector::ffi::PduHint; diff --git a/ffi/src/connector/mod.rs b/ffi/src/connector/mod.rs index bede9371..c41defec 100644 --- a/ffi/src/connector/mod.rs +++ b/ffi/src/connector/mod.rs @@ -5,7 +5,7 @@ pub mod state; #[diplomat::bridge] pub mod ffi { - use core::fmt::Write; + use core::fmt::Write as _; use diplomat_runtime::DiplomatWriteable; use ironrdp::connector::Sequence as _; diff --git a/ffi/src/credssp/network.rs b/ffi/src/credssp/network.rs index 4016ac76..b371dcf0 100644 --- a/ffi/src/credssp/network.rs +++ b/ffi/src/credssp/network.rs @@ -95,7 +95,7 @@ pub mod ffi { } pub fn get_url(&self, writeable: &mut diplomat_runtime::DiplomatWriteable) -> Result<(), Box> { - use core::fmt::Write; + use core::fmt::Write as _; let url: &str = self.0.url.as_ref(); write!(writeable, "{url}")?; Ok(()) diff --git a/ffi/src/pdu.rs b/ffi/src/pdu.rs index a75329f9..8dc60d17 100644 --- a/ffi/src/pdu.rs +++ b/ffi/src/pdu.rs @@ -1,7 +1,7 @@ #[diplomat::bridge] pub mod ffi { - use ironrdp::pdu::geometry::Rectangle; + use ironrdp::pdu::geometry::Rectangle as _; use crate::error::ffi::IronRdpError; use crate::utils::ffi::VecU8;