From 1132126c2aefbb1ff1e5d32e2e8005e65502d260 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Beno=C3=AEt=20Cortier?= <bcortier@proton.me>
Date: Thu, 24 Aug 2023 09:56:12 -0400
Subject: [PATCH] ci(cov): use GITHUB_TOKEN instead of DEVOLUTIONSBOT_TOKEN
 (#179)

---
 .github/workflows/coverage.yml | 2 +-
 xtask/src/cov.rs               | 8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml
index d85ddda7..343205a3 100644
--- a/.github/workflows/coverage.yml
+++ b/.github/workflows/coverage.yml
@@ -28,7 +28,7 @@ jobs:
       - name: Generate PR report
         if: github.event.number != ''
         env:
-          GH_TOKEN: ${{ secrets.DEVOLUTIONSBOT_TOKEN != '' && secrets.DEVOLUTIONSBOT_TOKEN || github.token }}
+          GH_TOKEN: ${{ github.token }}
         run: cargo xtask cov report-gh --repo "${{ github.repository }}" --pr "${{ github.event.number }}" -v
 
       - name: Configure Git Identity
diff --git a/xtask/src/cov.rs b/xtask/src/cov.rs
index 89fd5fb3..99c7aee9 100644
--- a/xtask/src/cov.rs
+++ b/xtask/src/cov.rs
@@ -94,6 +94,14 @@ pub fn report_github(sh: &Shell, repo: &str, pr_id: u32) -> anyhow::Result<()> {
     println!("New:\n{report}");
     println!("Diff: {:+}%", diff);
 
+    // `GH_TOKEN` environment variable sanity checks
+    match std::env::var_os("GH_TOKEN") {
+        Some(value) if value.is_empty() => trace!("WARNING: `GH_TOKEN` environment variable is empty"),
+        Some(value) if value.is_ascii() => trace!("`GH_TOKEN` environment variable appears to be set properly"),
+        Some(_) => trace!("WARNING: `GH_TOKEN` environment variable’s value is not an ASCII string"),
+        None => trace!("WARNING: `GH_TOKEN` environment variable is not set"),
+    }
+
     let comments = cmd!(sh, "gh api")
         .arg("-H")
         .arg("Accept: application/vnd.github.v3+json")