You've already forked linux-packaging-mono
acceptance-tests
data
debian
docs
external
Newtonsoft.Json
api-doc-tools
api-snapshot
aspnetwebstack
bdwgc
binary-reference-assemblies
bockbuild
boringssl
cecil
cecil-legacy
corefx
corert
helix-binaries
ikdasm
ikvm
illinker-test-assets
linker
llvm-project
clang
clang-tools-extra
change-namespace
clang-apply-replacements
clang-move
clang-query
clang-reorder-fields
clang-tidy
android
boost
bugprone
cert
cppcoreguidelines
fuchsia
google
hicpp
llvm
misc
modernize
mpi
objc
performance
CMakeLists.txt
FasterStringFindCheck.cpp
FasterStringFindCheck.h
ForRangeCopyCheck.cpp
ForRangeCopyCheck.h
ImplicitConversionInLoopCheck.cpp
ImplicitConversionInLoopCheck.h
InefficientAlgorithmCheck.cpp
InefficientAlgorithmCheck.h
InefficientStringConcatenationCheck.cpp
InefficientStringConcatenationCheck.h
InefficientVectorOperationCheck.cpp
InefficientVectorOperationCheck.h
MoveConstArgCheck.cpp
MoveConstArgCheck.h
MoveConstructorInitCheck.cpp
MoveConstructorInitCheck.h
NoexceptMoveConstructorCheck.cpp
NoexceptMoveConstructorCheck.h
PerformanceTidyModule.cpp
TypePromotionInMathFnCheck.cpp
TypePromotionInMathFnCheck.h
UnnecessaryCopyInitialization.cpp
UnnecessaryCopyInitialization.h
UnnecessaryValueParamCheck.cpp
UnnecessaryValueParamCheck.h
plugin
readability
tool
utils
CMakeLists.txt
ClangTidy.cpp
ClangTidy.h
ClangTidyDiagnosticConsumer.cpp
ClangTidyDiagnosticConsumer.h
ClangTidyModule.cpp
ClangTidyModule.h
ClangTidyModuleRegistry.h
ClangTidyOptions.cpp
ClangTidyOptions.h
add_new_check.py
rename_check.py
clang-tidy-vs
clangd
docs
include-fixer
modularize
pp-trace
test
tool-template
unittests
.arcconfig
.gitignore
CMakeLists.txt
CODE_OWNERS.TXT
LICENSE.TXT
README.txt
compiler-rt
libcxx
libcxxabi
libunwind
lld
lldb
llvm
openmp
polly
nuget-buildtasks
nunit-lite
roslyn-binaries
rx
xunit-binaries
how-to-bump-roslyn-binaries.md
ikvm-native
llvm
m4
man
mcs
mk
mono
msvc
netcore
po
runtime
samples
scripts
support
tools
COPYING.LIB
LICENSE
Makefile.am
Makefile.in
NEWS
README.md
acinclude.m4
aclocal.m4
autogen.sh
code_of_conduct.md
compile
config.guess
config.h.in
config.rpath
config.sub
configure.REMOVED.git-id
configure.ac.REMOVED.git-id
depcomp
install-sh
ltmain.sh.REMOVED.git-id
missing
mkinstalldirs
mono-uninstalled.pc.in
test-driver
winconfig.h
96 lines
3.6 KiB
C++
96 lines
3.6 KiB
C++
//===--- ForRangeCopyCheck.cpp - clang-tidy--------------------------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "ForRangeCopyCheck.h"
|
|
#include "../utils/DeclRefExprUtils.h"
|
|
#include "../utils/FixItHintUtils.h"
|
|
#include "../utils/TypeTraits.h"
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang {
|
|
namespace tidy {
|
|
namespace performance {
|
|
|
|
ForRangeCopyCheck::ForRangeCopyCheck(StringRef Name, ClangTidyContext *Context)
|
|
: ClangTidyCheck(Name, Context),
|
|
WarnOnAllAutoCopies(Options.get("WarnOnAllAutoCopies", 0)) {}
|
|
|
|
void ForRangeCopyCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
|
|
Options.store(Opts, "WarnOnAllAutoCopies", WarnOnAllAutoCopies);
|
|
}
|
|
|
|
void ForRangeCopyCheck::registerMatchers(MatchFinder *Finder) {
|
|
// Match loop variables that are not references or pointers or are already
|
|
// initialized through MaterializeTemporaryExpr which indicates a type
|
|
// conversion.
|
|
auto LoopVar = varDecl(
|
|
hasType(hasCanonicalType(unless(anyOf(referenceType(), pointerType())))),
|
|
unless(hasInitializer(expr(hasDescendant(materializeTemporaryExpr())))));
|
|
Finder->addMatcher(cxxForRangeStmt(hasLoopVariable(LoopVar.bind("loopVar")))
|
|
.bind("forRange"),
|
|
this);
|
|
}
|
|
|
|
void ForRangeCopyCheck::check(const MatchFinder::MatchResult &Result) {
|
|
const auto *Var = Result.Nodes.getNodeAs<VarDecl>("loopVar");
|
|
// Ignore code in macros since we can't place the fixes correctly.
|
|
if (Var->getLocStart().isMacroID())
|
|
return;
|
|
if (handleConstValueCopy(*Var, *Result.Context))
|
|
return;
|
|
const auto *ForRange = Result.Nodes.getNodeAs<CXXForRangeStmt>("forRange");
|
|
handleCopyIsOnlyConstReferenced(*Var, *ForRange, *Result.Context);
|
|
}
|
|
|
|
bool ForRangeCopyCheck::handleConstValueCopy(const VarDecl &LoopVar,
|
|
ASTContext &Context) {
|
|
if (WarnOnAllAutoCopies) {
|
|
// For aggressive check just test that loop variable has auto type.
|
|
if (!isa<AutoType>(LoopVar.getType()))
|
|
return false;
|
|
} else if (!LoopVar.getType().isConstQualified()) {
|
|
return false;
|
|
}
|
|
llvm::Optional<bool> Expensive =
|
|
utils::type_traits::isExpensiveToCopy(LoopVar.getType(), Context);
|
|
if (!Expensive || !*Expensive)
|
|
return false;
|
|
auto Diagnostic =
|
|
diag(LoopVar.getLocation(),
|
|
"the loop variable's type is not a reference type; this creates a "
|
|
"copy in each iteration; consider making this a reference")
|
|
<< utils::fixit::changeVarDeclToReference(LoopVar, Context);
|
|
if (!LoopVar.getType().isConstQualified())
|
|
Diagnostic << utils::fixit::changeVarDeclToConst(LoopVar);
|
|
return true;
|
|
}
|
|
|
|
bool ForRangeCopyCheck::handleCopyIsOnlyConstReferenced(
|
|
const VarDecl &LoopVar, const CXXForRangeStmt &ForRange,
|
|
ASTContext &Context) {
|
|
llvm::Optional<bool> Expensive =
|
|
utils::type_traits::isExpensiveToCopy(LoopVar.getType(), Context);
|
|
if (LoopVar.getType().isConstQualified() || !Expensive || !*Expensive)
|
|
return false;
|
|
if (!utils::decl_ref_expr::isOnlyUsedAsConst(LoopVar, *ForRange.getBody(),
|
|
Context))
|
|
return false;
|
|
diag(LoopVar.getLocation(),
|
|
"loop variable is copied but only used as const reference; consider "
|
|
"making it a const reference")
|
|
<< utils::fixit::changeVarDeclToConst(LoopVar)
|
|
<< utils::fixit::changeVarDeclToReference(LoopVar, Context);
|
|
return true;
|
|
}
|
|
|
|
} // namespace performance
|
|
} // namespace tidy
|
|
} // namespace clang
|