Imported Upstream version 5.4.0.167

Former-commit-id: 5624ac747d633e885131e8349322922b6a59baaa

mcs/class/referencesource/System.Data.Linq/SqlClient/Common/SqlVisitor.cs

@@ -9,7 +9,7 @@ namespace System.Data.Linq.SqlClient {
         int nDepth;
  
         // Visit a SqlNode
-        [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification="[....]: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")]
+        [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification="Microsoft: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")]
         [SuppressMessage("Microsoft.Maintainability", "CA1506:AvoidExcessiveClassCoupling", Justification = "These issues are related to our use of if-then and case statements for node types, which adds to the complexity count however when reviewed they are easy to navigate and understand.")]
         [SuppressMessage("Microsoft.Maintainability", "CA1502:AvoidExcessiveComplexity", Justification = "These issues are related to our use of if-then and case statements for node types, which adds to the complexity count however when reviewed they are easy to navigate and understand.")]
         internal virtual SqlNode Visit(SqlNode node) {

mcs/class/referencesource/System.Data.Linq/SqlClient/Query/Funcletizer.cs

@@ -142,7 +142,7 @@ namespace System.Data.Linq.SqlClient {
         }
 
         [SuppressMessage("Microsoft.Maintainability", "CA1502:AvoidExcessiveComplexity", Justification = "These issues are related to our use of if-then and case statements for node types, which adds to the complexity count however when reviewed they are easy to navigate and understand.")]
-        [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification = "[....]: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")]
+        [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification = "Microsoft: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")]
         internal virtual Expression Visit(Expression exp) {
             if (exp == null)
                 return exp;

mcs/class/referencesource/System.Data.Linq/SqlClient/Query/QueryConverter.cs.REMOVED.git-id

@@ -1 +1 @@
-55ae51ee9571e225d66d051c088e676a1ee4f3e6
+a9135481d56b670cb96d8798bd482357c1b2cd30

mcs/class/referencesource/System.Data.Linq/SqlClient/Query/SqlBinder.cs

@@ -1266,7 +1266,7 @@ namespace System.Data.Linq.SqlClient {
                 throw Error.UnexpectedNode(node.NodeType);
             }
 
-            [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification = "[....]: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")]
+            [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification = "Microsoft: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")]
             [SuppressMessage("Microsoft.Maintainability", "CA1506:AvoidExcessiveClassCoupling", Justification = "These issues are related to our use of if-then and case statements for node types, which adds to the complexity count however when reviewed they are easy to navigate and understand.")]
             [SuppressMessage("Microsoft.Maintainability", "CA1502:AvoidExcessiveComplexity", Justification = "These issues are related to our use of if-then and case statements for node types, which adds to the complexity count however when reviewed they are easy to navigate and understand.")]
             internal SqlExpression ConvertToFetchedExpression(SqlNode node) {

mcs/class/referencesource/System.Data.Linq/SqlClient/Query/SqlComparer.cs

@@ -13,7 +13,7 @@ namespace System.Data.Linq.SqlClient {
         internal SqlComparer() {
         }
 
-        [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification = "[....]: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")]
+        [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification = "Microsoft: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")]
         [SuppressMessage("Microsoft.Maintainability", "CA1506:AvoidExcessiveClassCoupling", Justification = "These issues are related to our use of if-then and case statements for node types, which adds to the complexity count however when reviewed they are easy to navigate and understand.")]
         [SuppressMessage("Microsoft.Maintainability", "CA1505:AvoidUnmaintainableCode", Justification = "These issues are related to our use of if-then and case statements for node types, which adds to the complexity count however when reviewed they are easy to navigate and understand.")]
         [SuppressMessage("Microsoft.Maintainability", "CA1502:AvoidExcessiveComplexity", Justification = "These issues are related to our use of if-then and case statements for node types, which adds to the complexity count however when reviewed they are easy to navigate and understand.")]

mcs/class/referencesource/System.Data.Linq/SqlClient/Query/SqlDeflator.cs

@@ -236,7 +236,7 @@ namespace System.Data.Linq.SqlClient {
                 return select;
             }
 
-            [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification="[....]: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")]
+            [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification="Microsoft: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")]
             private void CheckJoinCondition(SqlExpression expr) {
                 switch (expr.NodeType) {
                     case SqlNodeType.And: {

mcs/class/referencesource/System.Data.Linq/SqlClient/Query/SqlFlattener.cs

@@ -20,7 +20,7 @@ namespace System.Data.Linq.SqlClient {
         }
 
         class Visitor : SqlVisitor {
-            [SuppressMessage("Microsoft.Performance", "CA1823:AvoidUnusedPrivateFields", Justification = "[....]: part of our standard visitor pattern")]
+            [SuppressMessage("Microsoft.Performance", "CA1823:AvoidUnusedPrivateFields", Justification = "Microsoft: part of our standard visitor pattern")]
             SqlFactory sql;
             SqlColumnizer columnizer;
             bool isTopLevel;

mcs/class/referencesource/System.Data.Linq/SqlClient/Query/SqlMethodCallConverter.cs.REMOVED.git-id

@@ -1 +1 @@
-ddbca5a93db3b40896c13eb12fd79c5262f0a810
+79be6fe37eb380b36e1b72a1cf7c623b39964556

mcs/class/referencesource/System.Data.Linq/SqlClient/Reader/ObjectReaderCompiler.cs.REMOVED.git-id

@@ -1 +1 @@
-44139f927c2c7e86f11847768cc2daed9e85dd37
+70507c2459696b274393412e2a3044c4491491f1

mcs/class/referencesource/System.Data.Linq/SqlClient/SqlMethods.cs

@@ -562,8 +562,8 @@ namespace System.Data.Linq.SqlClient {
         /// <param name="match_expression">The string that is to be matched.</param>
         /// <param name="pattern">The pattern which may involve wildcards %,_,[,],^.</param>
         /// <returns>true if there is a match.</returns>
-        [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "pattern", Justification = "[....]: Method is a placeholder for a server-side method.")]
-        [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "matchExpression", Justification = "[....]: Method is a placeholder for a server-side method.")]
+        [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "pattern", Justification = "Microsoft: Method is a placeholder for a server-side method.")]
+        [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "matchExpression", Justification = "Microsoft: Method is a placeholder for a server-side method.")]
         public static bool Like(string matchExpression, string pattern) {
             throw Error.SqlMethodOnlyForSql(MethodInfo.GetCurrentMethod());
         }
@@ -576,9 +576,9 @@ namespace System.Data.Linq.SqlClient {
         /// <param name="pattern">The pattern which may involve wildcards %,_,[,],^.</param>
         /// <param name="escape_character">The escape character to use in front of %,_,[,],^ if they are not used as wildcards.</param>
         /// <returns>true if there is a match.</returns>
-        [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "pattern", Justification = "[....]: Method is a placeholder for a server-side method.")]
-        [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "matchExpression", Justification = "[....]: Method is a placeholder for a server-side method.")]
-        [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "escapeCharacter", Justification = "[....]: Method is a placeholder for a server-side method.")]
+        [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "pattern", Justification = "Microsoft: Method is a placeholder for a server-side method.")]
+        [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "matchExpression", Justification = "Microsoft: Method is a placeholder for a server-side method.")]
+        [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "escapeCharacter", Justification = "Microsoft: Method is a placeholder for a server-side method.")]
         public static bool Like(string matchExpression, string pattern, char escapeCharacter) {
             throw Error.SqlMethodOnlyForSql(MethodInfo.GetCurrentMethod());
         }
@@ -591,7 +591,7 @@ namespace System.Data.Linq.SqlClient {
         /// </summary>
         /// <param name="value">The string to take the length of.</param>
         /// <returns>length of the string</returns>
-        [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "value", Justification = "[....]: Method is a placeholder for a server-side method.")]
+        [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "value", Justification = "Microsoft: Method is a placeholder for a server-side method.")]
         internal static int RawLength(string value) {
             throw Error.SqlMethodOnlyForSql(MethodInfo.GetCurrentMethod());
         }
@@ -602,7 +602,7 @@ namespace System.Data.Linq.SqlClient {
         /// </summary>
         /// <param name="value">The byte array to take the length of.</param>
         /// <returns>length of the array</returns>
-        [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "value", Justification = "[....]: Method is a placeholder for a server-side method.")]
+        [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "value", Justification = "Microsoft: Method is a placeholder for a server-side method.")]
         internal static int RawLength(byte[] value) {
             throw Error.SqlMethodOnlyForSql(MethodInfo.GetCurrentMethod());
         }
@@ -613,7 +613,7 @@ namespace System.Data.Linq.SqlClient {
         /// </summary>
         /// <param name="value">The Binary value to take the length of.</param>
         /// <returns>length of the Binary</returns>
-        [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "value", Justification = "[....]: Method is a placeholder for a server-side method.")]
+        [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "value", Justification = "Microsoft: Method is a placeholder for a server-side method.")]
         internal static int RawLength(Binary value) {
             throw Error.SqlMethodOnlyForSql(MethodInfo.GetCurrentMethod());
         }

mcs/class/referencesource/System.Data.Linq/SqlClient/SqlProvider.cs

@@ -738,7 +738,7 @@ namespace System.Data.Linq.SqlClient {
             }
         }
 
-        [SuppressMessage("Microsoft.Design", "CA1031:DoNotCatchGeneralExceptionTypes", Justification="[....]: Code needs to return false regarless of exception.")]
+        [SuppressMessage("Microsoft.Design", "CA1031:DoNotCatchGeneralExceptionTypes", Justification="Microsoft: Code needs to return false regarless of exception.")]
         [ResourceExposure(ResourceScope.None)] // Exposure is via other methods that set dbName.
         [ResourceConsumption(ResourceScope.Machine, ResourceScope.Machine)] // File.Exists method call.
         bool IProvider.DatabaseExists() {
@@ -1779,7 +1779,7 @@ namespace System.Data.Linq.SqlClient {
             IObjectReaderSession session;
             int iReturnParameter = -1;
             object value;
-            [SuppressMessage("Microsoft.Performance", "CA1823:AvoidUnusedPrivateFields", Justification = "[....]: used in an assert in ReturnValue.set")]
+            [SuppressMessage("Microsoft.Performance", "CA1823:AvoidUnusedPrivateFields", Justification = "Microsoft: used in an assert in ReturnValue.set")]
             bool useReturnValue;
             bool isDisposed;
 

mcs/class/referencesource/System.Data.Linq/SqlClient/SqlTypeSystemProvider.cs

@@ -1316,7 +1316,7 @@ namespace System.Data.Linq.SqlClient {
                 }
             }
 
-            [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification = "[....]: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")]
+            [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification = "Microsoft: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")]
             internal override ProviderType GetBestType(ProviderType typeA, ProviderType typeB) {
                 // first determine the type precedence
                 SqlType bestType = (SqlType)(typeA.ComparePrecedenceTo(typeB) > 0 ? typeA : typeB);