mo2/modorganizer-uibase
0
0
Fork 0
mirror of https://github.com/ModOrganizer2/modorganizer-uibase.git synced 2026-07-27 14:03:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

Add small tests to check that copy/move do not populated for nothing.

Browse Source
This commit is contained in:
Mikaël Capelle
2020-05-16 15:55:08 +02:00
parent 48d92868cf
commit 8245dcb722
1 changed files with 34 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_ifiletree.cpp
+34 -3
View File
@@ -29,6 +29,8 @@ struct FileListTree : public IFileTree {
return std::shared_ptr<FileListTree>(new FileListTree(parent, name));
}
bool populated() const { return m_Populated; }
virtual void doPopulate(std::shared_ptr<const IFileTree> parent, std::vector<std::shared_ptr<FileTreeEntry>>& entries) const {
// We know that the files are sorted:
QString currentName = "";
@@ -61,6 +63,8 @@ struct FileListTree : public IFileTree {
if (currentName != "") {
entries.push_back(makeDirectory(parent, currentName, std::move(currentFiles)));
}
m_Populated = true;
}
virtual std::shared_ptr<IFileTree> doClone() const override {
@@ -91,9 +95,24 @@ protected:
FileListTree(std::shared_ptr<const IFileTree> parent, QString name, std::vector<File>&& files)
: FileTreeEntry(parent, name), IFileTree(), m_Files(std::move(files)) { }
mutable bool m_Populated = false;
std::vector<File> m_Files;
};
/**
* @brief Check if the given tree has been populated.
*
* Since IFileTree does not expose the "populated" flag, this is a convenient
* method that simply downcast to `FileListTree` and check `populated()` on it.
*
* @param tree The tree to check.
*
* @return true if the tree has been populated, false otherwize.
*/
bool populated(std::shared_ptr<const IFileTree> tree) {
return std::dynamic_pointer_cast<const FileListTree>(tree)->populated();
}
/**
* @brief Retrieve all the entry in the given tree.
*
@@ -599,14 +618,22 @@ TEST(IFileTreeTest, TreeMoveAndCopyOperations) {
{"b/", true},
{"c", false}
});
auto map1 = createMapping(tree1);
auto a = tree1->findDirectory("a");
EXPECT_FALSE(populated(a));
tree1->move(tree1->find("a"), "a1");
// Moving the tree should not have populated it:
EXPECT_EQ(tree1->find("a"), nullptr);
EXPECT_EQ(tree1->find("a1"), map1["a"]);
EXPECT_EQ(tree1->find("a1"), a);
EXPECT_FALSE(populated(a));
tree1->copy(tree1->find("a1"), "a2");
EXPECT_EQ(tree1->find("a1"), map1["a"]);
// Copying the tree should not have populated it:
EXPECT_FALSE(populated(a));
EXPECT_FALSE(populated(tree1->findDirectory("a2")));
EXPECT_EQ(tree1->find("a1"), a);
EXPECT_NE(tree1->find("a1"), tree1->find("a2"));
assertTreeEquals(tree1, {
@@ -622,6 +649,10 @@ TEST(IFileTreeTest, TreeMoveAndCopyOperations) {
{"c", false},
});
// Everything should be populated now:
EXPECT_TRUE(populated(tree1->findDirectory("a1")));
EXPECT_TRUE(populated(tree1->findDirectory("a2")));
QString a1("a1/"), a2("a2/");
for (auto p : { "b", "b/c", "b/m.y" }) {
EXPECT_NE(tree1->find(a1 + p), tree1->find(a2 + p)) << "Entry '" << (a1 + p) << "' and '" << (a2 + p) << "' should be different.";