From dff9bd2404cfe47a8c57bf1416efc0bda126d740 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mika=C3=ABl=20Capelle?= <capelle.mikael@gmail.com>
Date: Thu, 28 Apr 2022 13:51:26 +0200
Subject: [PATCH] Documentation.

---
 src/runner-pybind11/pythonrunner.cpp | 31 ++++++++++++++++------------
 1 file changed, 18 insertions(+), 13 deletions(-)

diff --git a/src/runner-pybind11/pythonrunner.cpp b/src/runner-pybind11/pythonrunner.cpp
index 5b3dbe2..df2bf79 100644
--- a/src/runner-pybind11/pythonrunner.cpp
+++ b/src/runner-pybind11/pythonrunner.cpp
@@ -288,8 +288,6 @@ public:
     bool isPythonVersionSupported() const;
 
 private:
-    void initPath();
-
     /**
      * @brief Ensure that the given folder is in sys.path.
      */
@@ -322,6 +320,18 @@ PYBIND11_MODULE(moprivate, m)
 
 bool PythonRunner::initPython()
 {
+    // we only initialize Python once for the whole lifetime of the program, even if MO2
+    // is restarted and the proxy or PythonRunner objects are deleted and recreated,
+    // Python is not re-initialized
+    //
+    // in an ideal world, we would initialize Python here (or in the constructor) and
+    // then finalize it in the destructor
+    //
+    // unfortunately, many library, including PyQt6, do not handle properly
+    // re-initializing the Python interpreter, so we cannot do that and we keep the
+    // interpreter alive
+    //
+
     if (Py_IsInitialized()) {
         return true;
     }
@@ -329,7 +339,12 @@ bool PythonRunner::initPython()
     try {
         static const char* argv0 = "ModOrganizer.exe";
 
-        initPath();
+        // initialize the core Path of Python, this must be done before initialization
+        const QStringList paths = {
+            QCoreApplication::applicationDirPath() + "/pythoncore.zip",
+            QCoreApplication::applicationDirPath() + "/pythoncore",
+            IOrganizer::getPluginDataPath()};
+        Py_SetPath(paths.join(';').toStdWString().c_str());
 
         if (PyImport_AppendInittab("mobase", &PyInit_mobase) == -1) {
             MOBase::log::error("failed to init python: failed to append mobase.");
@@ -393,16 +408,6 @@ void PythonRunner::ensureFolderInPath(QString folder)
     }
 }
 
-void PythonRunner::initPath()
-{
-    static QStringList paths = {QCoreApplication::applicationDirPath() +
-                                    "/pythoncore.zip",
-                                QCoreApplication::applicationDirPath() + "/pythoncore",
-                                IOrganizer::getPluginDataPath()};
-
-    Py_SetPath(paths.join(';').toStdWString().c_str());
-}
-
 QList<QObject*> PythonRunner::load(const QString& identifier)
 {
     py::gil_scoped_acquire lock;