paths refactoring, comments

src/core/conf.cpp

@@ -452,8 +452,7 @@ void init_options(
 	set_path_if_empty("licenses",   find_in_root("licenses"));
 	set_path_if_empty("qt_bin",     qt::installation_path() / "bin");
 
-	find_vcvars();
-	validate_qt();
+	details::set_string("tools", "vcvars", path_to_utf8(find_vcvars()));
 
 	this_env::append_to_path(conf().path().get("qt_bin"));
 

src/core/paths.h

@@ -3,20 +3,53 @@
 namespace mob
 {
 
-fs::path find_root(bool verbose=false);
-fs::path find_in_root(const fs::path& file);
-
-fs::path find_third_party_directory();
-fs::path find_program_files_x86();
-fs::path find_program_files_x64();
-fs::path find_vs();
-fs::path find_qt();
-fs::path find_iscc();
-fs::path find_temp_dir();
-
-void find_vcvars();
-void validate_qt();
-
+// returns the path to mob.exe that's currently running, including filename;
+// bails on failure
+//
 fs::path mob_exe_path();
 
+// returns mob's root directory, contains third-party/, etc.; bails on failure
+//
+// this is not necessarily the parent of mob_exe_path(), it mob could be running
+// from the build directory
+//
+fs::path find_root(bool verbose=false);
+
+// resolves the given relative path against find_root(); bails when not found
+//
+fs::path find_in_root(const fs::path& file);
+
+
+// returns the absolute path of mob's third-party directory; bails when not
+// found
+//
+fs::path find_third_party_directory();
+
+// returns the absolute path to x86/x64 program files directory
+//
+fs::path find_program_files_x86();
+fs::path find_program_files_x64();
+
+// returns the absolute path to visual studio's root directory, the one that
+// contains Common7, VC, etc.; bails if not found
+//
+fs::path find_vs();
+
+// returns the absolute path to Qt's root directory, the one that contains
+// the msvc_xxx directory; bails if not found
+//
+fs::path find_qt();
+
+// returns the absolute path to iscc.exe; bails if not found
+//
+fs::path find_iscc();
+
+// returns the absolute path to the system's temp directory; bails on error
+//
+fs::path find_temp_dir();
+
+// returns the absolute path to the vcvars batch file, bails if not found
+//
+fs::path find_vcvars();
+
 }	// namespace