mo2/githubpp
0
0
Fork 0
mirror of https://github.com/ModOrganizer2/githubpp.git synced 2026-07-27 14:04:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

better error logging

Browse Source
This commit is contained in:
isanae
2019-07-12 02:44:00 -04:00
parent bb48f0662b
commit ce23a98ae1
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/github.cpp
+9 -2
View File
@@ -170,7 +170,13 @@ void GitHub::onFinished(const Request& req)
void GitHub::onError(const Request& req, QNetworkReply::NetworkError error)
{
qDebug("network error %d", error);
// the only way the request can be aborted is when there's a timeout, which
// already logs a message
if (error != QNetworkReply::OperationCanceledError) {
qCritical().noquote().nospace()
<< "Github: request for " << req.reply->url().toString() << " failed, "
<< req.reply->errorString() << " (" << error << ")";
}
req.timer->stop();
req.reply->disconnect();
@@ -185,7 +191,8 @@ void GitHub::onError(const Request& req, QNetworkReply::NetworkError error)
void GitHub::onTimeout(const Request& req)
{
qDebug("timeout");
qCritical().noquote().nospace()
<< "Github: request for " << req.reply->url().toString() << " timed out";
// don't delete the reply, abort will fire the error() handler above
req.reply->abort();