From 78348b252127d80bee10f30d73cf50599fe12ee1 Mon Sep 17 00:00:00 2001 From: Zero King Date: Sat, 5 Jan 2019 17:36:07 +0000 Subject: [PATCH] Remove redundant check --- pr/webhook/pull_request_others.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pr/webhook/pull_request_others.go b/pr/webhook/pull_request_others.go index e096ded..3b81427 100644 --- a/pr/webhook/pull_request_others.go +++ b/pr/webhook/pull_request_others.go @@ -5,7 +5,6 @@ import ( "log" "regexp" "strconv" - "strings" "github.com/google/go-github/github" ) @@ -48,9 +47,9 @@ func (receiver *Receiver) handleOtherPullRequestEvents(eventType string, body [] receiver.membersLock.RUnlock() if members != nil { _, isMember := (*members)[*event.Sender.Login] - if isMember && strings.Contains(*event.Comment.Body, "@macportsbot") { // TODO: read bot user from ENV + if isMember { body := *event.Comment.Body - if botMentioned, _ := regexp.MatchString(`@macportsbot\s`, body); botMentioned { + if botMentioned, _ := regexp.MatchString(`@macportsbot\s`, body); botMentioned { // TODO: read bot user from ENV if doRetry, _ := regexp.MatchString(`@macportsbot\s+retry`, body); doRetry { // TODO: test compile patterns pr, err := receiver.githubClient.GetPullRequest(*event.Repo.Owner.Login, *event.Repo.Name, *event.Issue.Number) if err != nil {