mirror of
https://github.com/macports/macports-legacy-support.git
synced 2026-07-13 03:18:41 -07:00
Fred WrightandChristopher Nielsen
42c54ff9d5
Although more thorough testing of various path cases would be useful, this one, which just tests a simple nonexistent relative path, is sufficient to demonstrate a bug in the 10.6 non-POSIX realpath(), which returns "success" via an unsafe pointer to an internal buffer. TESTED: Fails in known bad case without the fix; passes in all cases with the fix.
141 lines
4.7 KiB
C
141 lines
4.7 KiB
C
/*
|
|
* Copyright (c) 2019 Christian Cornelssen
|
|
* Copyright (c) 2024 Frederick H. G. Wright II <fw@fwright.net>
|
|
*
|
|
* Permission to use, copy, modify, and distribute this software for any
|
|
* purpose with or without fee is hereby granted, provided that the above
|
|
* copyright notice and this permission notice appear in all copies.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
|
|
* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
|
|
* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
|
|
* ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
|
|
* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
|
|
* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
|
|
* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
|
|
*/
|
|
|
|
/*
|
|
* NOTE: Much of the complexity in this test is left over from an earlier
|
|
* implementation that used a wrapper macro instead of a wrapper function.
|
|
* Macro-related issues are no longer important to test, though the extra
|
|
* tests haven't been removed.
|
|
*/
|
|
|
|
/*
|
|
* Deliberately declaring some potentially redefined names
|
|
* before including the associated header file, to test robustness.
|
|
*/
|
|
|
|
/* Wrapper should work not only with calls, but with references as well */
|
|
/* __restrict not needed here (and remember: nothing included yet) */
|
|
typedef char * (*strfunc_t)(const char *, char *);
|
|
|
|
/* Renaming different objects should not affect functionality */
|
|
typedef struct { char *realpath; } rpv_t;
|
|
typedef struct { strfunc_t realpath; } rpf_t;
|
|
|
|
#include <assert.h>
|
|
#include <libgen.h>
|
|
#include <stddef.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <unistd.h>
|
|
|
|
#include <sys/param.h>
|
|
|
|
/*
|
|
* Beginning in the 15.x SDK, including malloc.h doesn't work when
|
|
* _POSIX_C_SOURCE is defined, which we need for the "nonext" version.
|
|
* So we avoid the official include and declare malloc_size() directly.
|
|
*
|
|
* #include <malloc/malloc.h>
|
|
*/
|
|
extern size_t malloc_size(const void *ptr);
|
|
|
|
#define NONEX_PATH "4981a2d5a4c7bea88154c434b4708045"
|
|
|
|
/*
|
|
* Allow testing the legacy compatibility entry.
|
|
* We use a simple argless macro and disable the fancier tests.
|
|
*/
|
|
#ifdef TEST_MACPORTS_LEGACY_REALPATH
|
|
#define realpath macports_legacy_realpath
|
|
extern char *realpath(const char * __restrict, char * __restrict);
|
|
#endif
|
|
|
|
int
|
|
main(int argc, char *argv[])
|
|
{
|
|
int verbose = 0;
|
|
const char *p, *q;
|
|
#ifndef TEST_MACPORTS_LEGACY_REALPATH
|
|
strfunc_t f;
|
|
rpf_t rpf = { realpath };
|
|
rpv_t rpv;
|
|
#endif /* !TEST_MACPORTS_LEGACY_REALPATH */
|
|
char buf[PATH_MAX], cwd[MAXPATHLEN];
|
|
|
|
if (argc > 1 && !strcmp(argv[1], "-v")) verbose = 1;
|
|
|
|
(void) getcwd(cwd, sizeof(cwd));
|
|
if (verbose) {
|
|
printf("Starting realpath test.\n");
|
|
printf("cwd = %s\n", cwd);
|
|
}
|
|
|
|
/* Test traditional version with supplied buffer */
|
|
p = realpath(".", buf);
|
|
assert(p && "realpath(path, buf) returned NULL");
|
|
if (verbose) printf("realpath(path, buf) supported.\n");
|
|
|
|
/* Test with direct function call */
|
|
q = realpath(".", NULL);
|
|
assert(q && "realpath(path, NULL) returned NULL");
|
|
assert (!strcmp(q, p) && "realpath(path, NULL) miscompared");
|
|
if (verbose) printf("realpath(path, NULL) supported.\n");
|
|
free((void*)q);
|
|
|
|
/*
|
|
* Test nonexistent path with no supplied buffer.
|
|
* In some cases (10.6 non-POSIX) this may "succeed" with a bad
|
|
* returned buffer address. We accept either failure or success
|
|
* with a valid buffer.
|
|
*/
|
|
q = realpath(NONEX_PATH, NULL);
|
|
assert((!q || malloc_size(q)) \
|
|
&& "realpath(_nonexpath, NULL) returned bad address");
|
|
if (verbose) {
|
|
printf("realpath(nonex_path, NULL) %s.\n", q ? "succeeds" : "fails");
|
|
}
|
|
if (q && malloc_size(q)) free((void*)q);
|
|
|
|
#ifndef TEST_MACPORTS_LEGACY_REALPATH
|
|
/* Test with name (reference) only */
|
|
f = realpath;
|
|
q = f(".", NULL);
|
|
assert(q && "realpath, f(path, NULL) returned NULL");
|
|
assert (!strcmp(q, p) && "realpath, f(path, NULL) miscompared");
|
|
if (verbose) printf("f = realpath, f(path, NULL) supported.\n");
|
|
free((void*)q);
|
|
|
|
/* Test with function macro disabler */
|
|
q = (realpath)(".", NULL);
|
|
assert(q && "(realpath)(path, NULL) returned NULL");
|
|
assert (!strcmp(q, p) && "(realpath)(path, NULL) miscompared");
|
|
if (verbose) printf("(realpath)(path, NULL) supported.\n");
|
|
free((void*)q);
|
|
|
|
/* Test with same-named fields */
|
|
rpv.realpath = rpf.realpath(".", NULL);
|
|
assert(rpv.realpath && "rpf.realpath(path, NULL) returned NULL");
|
|
assert (!strcmp(rpv.realpath, p) && "rpf.realpath(path, NULL) miscompared");
|
|
if (verbose) printf("rpv.realpath = rpf.realpath(path, NULL) supported.\n");
|
|
free((void*)rpv.realpath);
|
|
#endif /* !TEST_MACPORTS_LEGACY_REALPATH */
|
|
|
|
printf("%s succeeded.\n", basename(argv[0]));
|
|
return 0;
|
|
}
|