From ea7f26f1761598ae57dffe916070bacf3ed420b2 Mon Sep 17 00:00:00 2001
From: Joshua Root <jmr@macports.org>
Date: Tue, 16 Jun 2026 18:37:58 +1000
Subject: [PATCH] mportsync: call getuid once outside loop

Closes: https://trac.macports.org/ticket/74113
---
 src/macports1.0/macports.tcl | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/macports1.0/macports.tcl b/src/macports1.0/macports.tcl
index ec07780a6..d2268f312 100644
--- a/src/macports1.0/macports.tcl
+++ b/src/macports1.0/macports.tcl
@@ -3770,11 +3770,13 @@ proc mportsync {{options {}}} {
         upvar [dict get $options needed_portindex_var] any_needed_portindex
     }
 
+    set cur_uid [getuid]
+
     # We cd here for some commands, so make sure it exists.
     if {![file isdirectory ${portdbpath}/home]} {
         if {[catch {
             file mkdir ${portdbpath}/home
-            if {[getuid] == 0} {
+            if {$cur_uid == 0} {
                 file attributes ${portdbpath}/home -owner $macportsuser -group $macportsuser
             }
         } result]} {
@@ -3833,7 +3835,6 @@ proc mportsync {{options {}}} {
                 set destdir [file dirname $indexfile]
                 set is_tarball [_source_is_snapshot $source filename extension rooturl]
                 file mkdir $destdir
-                set cur_uid [getuid]
                 if {[file attributes $destdir -owner] eq $macportsuser} {
                     macports::chown $destdir $cur_uid
                 }
@@ -3912,7 +3913,7 @@ proc mportsync {{options {}}} {
                     }
 
                     set tar {}
-                    if {${hfscompression} && [getuid] == 0} {
+                    if {${hfscompression} && $cur_uid == 0} {
                         ui_debug "Using bsdtar with HFS+ compression (if valid)"
                         set tar [macports::find_tar_with_hfscompression]
                     }
@@ -4067,7 +4068,7 @@ proc mportsync {{options {}}} {
 
                 set tar {}
                 global macports::hfscompression
-                if {${hfscompression} && [getuid] == 0} {
+                if {${hfscompression} && $cur_uid == 0} {
                     ui_debug "Using bsdtar with HFS+ compression (if valid)"
                     set tar [macports::find_tar_with_hfscompression]
                 }
@@ -4147,7 +4148,7 @@ proc mportsync {{options {}}} {
                 set indexdir [file dirname $indexfile]
                 set owner [file attributes $indexdir -owner]
                 set group [file attributes $indexdir -group]
-                if {[getuid] == 0} {
+                if {$cur_uid == 0} {
                     # Ensure any existing index can be read and written
                     foreach f [list $indexfile ${indexfile}.quick] {
                         if {[file isfile $f] && [file attributes $f -owner] ne $owner} {