m5/MicroPythonOS
0
0
Fork 0
mirror of https://github.com/m5stack/MicroPythonOS.git synced 2026-05-20 11:51:27 -07:00
Code Issues Packages Projects Releases Wiki Activity

AppStore app: don't create unnecessary additional thread

Browse Source
This commit is contained in:
Thomas Farstrike
2025-11-01 09:51:18 +01:00
parent 51e702b9e0
commit 87f3bfeba1
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal_filesystem/builtin/apps/com.micropythonos.appstore/assets/appstore.py
+1 -5
View File
@@ -70,6 +70,7 @@ class AppStore(Activity):
time.sleep_ms(200) time.sleep_ms(200)
self.update_ui_threadsafe_if_foreground(self.please_wait_label.add_flag, lv.obj.FLAG.HIDDEN) self.update_ui_threadsafe_if_foreground(self.please_wait_label.add_flag, lv.obj.FLAG.HIDDEN)
self.update_ui_threadsafe_if_foreground(self.create_apps_list) self.update_ui_threadsafe_if_foreground(self.create_apps_list)
self.download_icons()
except Exception as e: except Exception as e:
print(f"ERROR: could not parse reponse.text JSON: {e}") print(f"ERROR: could not parse reponse.text JSON: {e}")
finally: finally:
@@ -119,11 +120,6 @@ class AppStore(Activity):
desc_label.set_style_text_font(lv.font_montserrat_12, 0) desc_label.set_style_text_font(lv.font_montserrat_12, 0)
desc_label.add_event_cb(lambda e, a=app: self.show_app_detail(a), lv.EVENT.CLICKED, None) desc_label.add_event_cb(lambda e, a=app: self.show_app_detail(a), lv.EVENT.CLICKED, None)
print("create_apps_list app done") print("create_apps_list app done")
try:
_thread.stack_size(mpos.apps.good_stack_size())
_thread.start_new_thread(self.download_icons,()) # maybe there's no need for a new thread here, just do it in download_app_index()?
except Exception as e:
print("Could not start thread to download icons: ", e)
def download_icons(self): def download_icons(self):
for app in self.apps: for app in self.apps: