From cbc91d7e72333c8efef2af923e04ed96b26a2d91 Mon Sep 17 00:00:00 2001 From: Oliver Hamlet Date: Wed, 8 Jul 2015 20:50:13 +0100 Subject: [PATCH] Use 'face' icon in non-GitHub credits. Instead of the question mark text. It looks a bit better. --- js/credits.js | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/js/credits.js b/js/credits.js index ae6a4c7..a4c5024 100644 --- a/js/credits.js +++ b/js/credits.js @@ -18,8 +18,10 @@ function addToList(listElement, person) { var avatar; if (person.avatar_url) { avatar = document.createElement('img'); + avatar.src = person.avatar_url; } else { - avatar = document.createElement('div'); + avatar = document.createElement('core-icon'); + avatar.setAttribute('icon', 'face'); } var div = document.createElement('div'); var primarySpan = document.createElement('span'); @@ -37,11 +39,6 @@ function addToList(listElement, person) { secondarySpan.className = 'secondary'; a.href = person.html_url; - if (person.avatar_url) { - avatar.src = person.avatar_url; - } else { - avatar.textContent = '?'; - } primarySpan.textContent = person.name; secondarySpan.textContent = person.contributions + ' contributions';