From ab7aef04f035461aea63acef69ca62773b5789bf Mon Sep 17 00:00:00 2001 From: Oliver Hamlet Date: Tue, 16 Dec 2014 10:59:28 +0000 Subject: [PATCH] Error handling improvements for credits and search. --- js/credits.js | 20 ++++++++++++++++++++ js/search.js | 2 +- 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/js/credits.js b/js/credits.js index d8b6131..07fea78 100644 --- a/js/credits.js +++ b/js/credits.js @@ -59,6 +59,11 @@ function getContributor(login) { } function showContributors(err, data) { + if (err) { + console.log(err); + return; + } + for (var i = 0; i < data.length; i++) { var person = { "login":data[i].login, @@ -97,6 +102,11 @@ function listContributors() { } function storeAdmins(err, data) { + if (err) { + console.log(err); + return; + } + for (var i = 0; i < data.length; i++) { admins.push(data[i].login); } @@ -105,6 +115,11 @@ function storeAdmins(err, data) { } function getTeams(err, data) { + if (err) { + console.log(err); + return; + } + for (var i = 0; i < data.length; i++) { if (data[i].name === "Owners") { github.getUser().teamMembers(data[i].id, storeAdmins); @@ -113,6 +128,11 @@ function getTeams(err, data) { } function storeTeamMembers(err, data) { + if (err) { + console.log(err); + return; + } + for (var i = 0; i < data.length; i++) { team.push(data[i].login); } diff --git a/js/search.js b/js/search.js index 64c571f..c1b2724 100644 --- a/js/search.js +++ b/js/search.js @@ -37,7 +37,7 @@ function isRegexEntry(name) { } function readMasterlist(err, data) { - if (err !== null) { + if (err) { console.log(err); return; }