mirror of
https://github.com/loot/loot-condition-interpreter.git
synced 2026-07-27 14:16:09 -07:00
Remove pelite dependency
The advantages of using the built-in implementation instead of pelite are: - It's much faster on average: for Starfield.exe (~ 100 MB) it is 2.8x faster and 4% slower reading file and product versions respectively, and for sfse_1_15_222.dll it is 3.35x faster and < 1% slower respectively. - It reduces the transitive dependency count by 8 - It uses ~ 700 lines of first-party code that only depends on the standard library, instead of 240715 lines of unaudited third-party code - pelite hasn't had a release in 3 years, and my PR for replacing winapi hasn't had any response in the month and a half it's been open, so the built-in implementation is probably less of a maintenance risk.
This commit is contained in:
@@ -38,14 +38,6 @@ criteria = "safe-to-run"
|
||||
version = "0.6.0"
|
||||
criteria = "safe-to-run"
|
||||
|
||||
[[exemptions.dataview]]
|
||||
version = "1.0.1"
|
||||
criteria = "safe-to-deploy"
|
||||
|
||||
[[exemptions.derive_pod]]
|
||||
version = "0.1.2"
|
||||
criteria = "safe-to-deploy"
|
||||
|
||||
[[exemptions.errno]]
|
||||
version = "0.3.14"
|
||||
criteria = "safe-to-run"
|
||||
@@ -68,22 +60,10 @@ notes = "At time of review this was only built if targeting WASM, which is not a
|
||||
version = "2.7.4"
|
||||
criteria = "safe-to-deploy"
|
||||
|
||||
[[exemptions.no-std-compat]]
|
||||
version = "0.4.1"
|
||||
criteria = "safe-to-deploy"
|
||||
|
||||
[[exemptions.nom]]
|
||||
version = "8.0.0"
|
||||
criteria = "safe-to-deploy"
|
||||
|
||||
[[exemptions.pelite]]
|
||||
version = "0.10.0"
|
||||
criteria = "safe-to-deploy"
|
||||
|
||||
[[exemptions.pelite-macros]]
|
||||
version = "0.1.1"
|
||||
criteria = "safe-to-deploy"
|
||||
|
||||
[[exemptions.plotters]]
|
||||
version = "0.3.7"
|
||||
criteria = "safe-to-run"
|
||||
@@ -157,15 +137,3 @@ version = "0.3.77"
|
||||
criteria = "safe-to-run"
|
||||
suggest = false
|
||||
notes = "At time of review this was only built if targeting WASM, which is not an intended target."
|
||||
|
||||
[[exemptions.winapi]]
|
||||
version = "0.3.9"
|
||||
criteria = "safe-to-deploy"
|
||||
|
||||
[[exemptions.winapi-i686-pc-windows-gnu]]
|
||||
version = "0.4.0"
|
||||
criteria = "safe-to-deploy"
|
||||
|
||||
[[exemptions.winapi-x86_64-pc-windows-gnu]]
|
||||
version = "0.4.0"
|
||||
criteria = "safe-to-deploy"
|
||||
|
||||
Reference in New Issue
Block a user