Rewrite it as reStructuredText so that it can be hosted alongside the
API documentation on Read The Docs, which allows linking to WIP syntax
documentation.
Instead, point to the CI configuration files, and include the extra
steps for Ubuntu 12.04 as a script. More useful, and less likely to
become outdated.
The readme now informs users that the MSVC 2015 x86 redistributable
is required, and the installer will download and install it if it
is not detected as being already installed.
Update libloadorder to 9.4.1 to support statically linking Boost
libraries while dynamically-linking the runtime library, and update
how CEF's default configuration is edited to also support dynamic
linking.
Dynamic linking is required for the API DLL, and static linking is
required by the C API wrapper. As building both would double build
times, CI will only build with dynamic linking, which means LOOT
application users will now also need the MSVC 2015 x86 runtime.
It's 1/2 or 1/5 (for Windows and Linux respectively) the size of the
standard distribution, compressed.
However, its CMakeLists.txt is an example for including into clients'
configs, and doesn't work with ExternalProject_Add, so ship a slightly
modified CMakeLists.txt to replace it (the only difference is the
cefsimple and cefclient include_directory lines have been removed).
On a lot of systems using bashisms in /bin/sh scripts will be fine,
since /bin/sh is a symlink to /bin/bash, but some systems symlink it to
the more lightweight (and more strictly POSIX) /bin/dash or some other
shell. Safest thing is to not assume a bashism will work.
What has been changed:
1) `[[ … ]]` is a bashism. Replaced with `[ … ]`.
2) `-eq` is for numeric operations. When a variable is quoted, it
becomes a string and uses `=` for comparison.
3) `&&` is a shell thing, but does not exist in `test`'s syntax.
(`[ … ]` is shorthand for `test …`.) `-a` is the "and" when
talking `test`.
This allows for symlinking it in .git/hooks/ directly[1] or executing
it from within an already existing `pre-commit` hook/script without
calling out to an interpreter in there[2], thus keeping up with any
upstream changes to it automatically.
Follow-up to e3b39b7233 / https://github.com/loot/loot/issues/622
[1] `ln -s ../../scripts/git/pre-commit .git/hooks/pre-commit`
[2] `./scripts/git/pre-commit` vs. `/bin/sh ./scripts/git/pre-commit`
Oliver Hamlet
Frederik “Freso” S. Olesen