From fa97ac8b5d14220e1204446f4bac6704d7aeac60 Mon Sep 17 00:00:00 2001 From: Oliver Hamlet Date: Mon, 22 Dec 2025 21:00:10 +0000 Subject: [PATCH] Fix off-by-one error in error column numbers It turns out that marker column values from Saphyr are not actually 1-indexed. --- src/metadata/error.rs | 4 ++-- src/metadata/yaml/merge.rs | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/metadata/error.rs b/src/metadata/error.rs index b874888a..14e36a65 100644 --- a/src/metadata/error.rs +++ b/src/metadata/error.rs @@ -96,7 +96,7 @@ impl std::fmt::Display for ParseMetadataError { f, "encountered a YAML parsing error at line {} column {}: {}", self.marker.line(), - self.marker.col(), + self.marker.col() + 1, self.reason ) } @@ -357,7 +357,7 @@ impl std::fmt::Display for YamlMergeKeyError { f, "invalid YAML merge key value at line {} column {}: {}", self.start.line(), - self.start.col(), + self.start.col() + 1, self.yaml ) } diff --git a/src/metadata/yaml/merge.rs b/src/metadata/yaml/merge.rs index 2282ff91..32b0c80a 100644 --- a/src/metadata/yaml/merge.rs +++ b/src/metadata/yaml/merge.rs @@ -90,7 +90,7 @@ mod tests { let error_message = process_merge_keys(yaml).unwrap_err().to_string(); assert_eq!( - "invalid YAML merge key value at line 3 column 6: test", + "invalid YAML merge key value at line 3 column 7: test", error_message ); } @@ -108,7 +108,7 @@ mod tests { let error_message = process_merge_keys(yaml).unwrap_err().to_string(); assert_eq!( - "invalid YAML merge key value at line 4 column 17: test", + "invalid YAML merge key value at line 4 column 18: test", error_message ); }