From f825ccbd3e816b7a38688410327f737721940534 Mon Sep 17 00:00:00 2001
From: WrinklyNinja <wrinklyninja1@gmail.com>
Date: Wed, 2 Oct 2013 14:19:41 +0100
Subject: [PATCH] Issue #72 tweaks.

---
 resources/script.js      |  4 +---
 resources/style.css      | 10 ++++------
 src/backend/generators.h | 20 +++++++++++---------
 3 files changed, 16 insertions(+), 18 deletions(-)

diff --git a/resources/script.js b/resources/script.js
index 1381efa2..f6364bf9 100755
--- a/resources/script.js
+++ b/resources/script.js
@@ -135,8 +135,6 @@ function toggleMessages(evt) {
                 filterMatch = true;
             } else if (evt.target.id == 'hideNotes' && listItems[i].className.indexOf('say') != -1) {
                 filterMatch = true;
-            } else if (evt.target.id == 'hideBashTags' && listItems[i].className.indexOf('tag') != -1) {
-                filterMatch = true;
             } else if (evt.target.id == 'hideDoNotCleanMessages' && listItems[i].innerHTML.indexOf('Do not clean.') != -1) {
                 filterMatch = true;
             }
@@ -209,8 +207,8 @@ function setupEventHandlers() {
     }
     document.getElementById('hideVersionNumbers').addEventListener('click', toggleDisplayCSS, false);
     document.getElementById('hideCRCs').addEventListener('click', toggleDisplayCSS, false);
+    document.getElementById('hideBashTags').addEventListener('click', toggleDisplayCSS, false);
     document.getElementById('hideNotes').addEventListener('click', toggleMessages, false);
-    document.getElementById('hideBashTags').addEventListener('click', toggleMessages, false);
     document.getElementById('hideDoNotCleanMessages').addEventListener('click', toggleMessages, false);
     document.getElementById('hideAllPluginMessages').addEventListener('click', toggleMessages, false);
     document.getElementById('hideMessagelessPlugins').addEventListener('click', togglePlugins, false);
diff --git a/resources/style.css b/resources/style.css
index cbf2a723..6a206676 100755
--- a/resources/style.css
+++ b/resources/style.css
@@ -74,7 +74,7 @@ td {
 }
 table td:first-child {
     text-align:left;
-    padding-left:0.5em;
+    padding-left:0;
 }
 #noChanges {
 	font-weight:bold;
@@ -116,12 +116,10 @@ ul {margin-top:0.5em;list-style:none;padding-left:0;}
 
 #plugins > ul > li, #summary > div {background:white; overflow:hidden; margin:1em; box-shadow:0 0 3px 0px rgba(0,0,0,0.5); padding:1em;}
 .mod {font-size:1.5em; display:block; font-weight:normal; margin-bottom:0.5em; margin-top:0; }
-.meta {padding-left:0; display:block;}
-.crc, .version, .tagAdd, .tagRemove {display:list-item;}
 .version{color:#6394F8;}
 .crc{color:#BC8923;}
-.tagAdd {color:green;}
-.tagRemove {color:red;}
+.tag.add {color:green;}
+.tag.remove {color:red;}
 .meta + ul {margin-top:1em;}
 
 .hidden, li.hidden, #summary.hidden, #plugins.hidden {
@@ -136,7 +134,7 @@ ul {margin-top:0.5em;list-style:none;padding-left:0;}
 
 .error{background:#ff9090;padding:0.5em 1em;list-style:disc inside;}
 
-.warn{background:#FFDD55;display:table;padding:0.5em 1em;border-radius:5px;}
+.warn{background:#FFDD55;padding:0.5em 1em;list-style:disc inside;}
 
 .good > td {background: #90ff90;}
 
diff --git a/src/backend/generators.h b/src/backend/generators.h
index 97571fe1..0406516a 100644
--- a/src/backend/generators.h
+++ b/src/backend/generators.h
@@ -306,10 +306,11 @@ namespace boss {
             note.text().set(boost::locale::translate("No change in details since last run.").str().c_str());
         }
 
-        div = summary.append_child();
-        div.set_name("div");
-
         if (!messages.empty()) {
+
+            div = summary.append_child();
+            div.set_name("div");
+
             heading = div.append_child();
             heading.set_name("h2");
             heading.text().set(boost::locale::translate("General Messages").str().c_str());
@@ -400,13 +401,13 @@ namespace boss {
                     if (!add.empty()) {
                         node = plugin.append_child();
                         node.set_name("div");
-                        node.append_attribute("class").set_value("tagAdd");
+                        node.append_attribute("class").set_value("tag add");
                         node.text().set((boost::locale::translate("Add:").str() + " " + add.substr(2)).c_str());
                     }
                     if (!remove.empty()) {
                         node = plugin.append_child();
                         node.set_name("div");
-                        node.append_attribute("class").set_value("tagRemove");
+                        node.append_attribute("class").set_value("tag remove");
                         node.text().set((boost::locale::translate("Remove:").str() + " " + add.substr(2)).c_str());
                     }
                 }
@@ -533,16 +534,17 @@ namespace boss {
         input = label.append_child();
         input.set_name("input");
         input.append_attribute("type").set_value("checkbox");
-        input.append_attribute("id").set_value("hideNotes");
-        input.text().set(boost::locale::translate("Hide Notes").str().c_str());
+        input.append_attribute("id").set_value("hideBashTags");
+        input.append_attribute("data-class").set_value("tag");
+        input.text().set(boost::locale::translate("Hide Bash Tag Suggestions").str().c_str());
 
         label = filters.append_child();
         label.set_name("label");
         input = label.append_child();
         input.set_name("input");
         input.append_attribute("type").set_value("checkbox");
-        input.append_attribute("id").set_value("hideBashTags");
-        input.text().set(boost::locale::translate("Hide Bash Tag Suggestions").str().c_str());
+        input.append_attribute("id").set_value("hideNotes");
+        input.text().set(boost::locale::translate("Hide Notes").str().c_str());
 
         label = filters.append_child();
         label.set_name("label");