From 86ff2a665b325915f294bb9c4044eff13fc8ce43 Mon Sep 17 00:00:00 2001
From: Oliver Hamlet <git@ortham.net>
Date: Sun, 2 Nov 2025 19:54:16 +0000
Subject: [PATCH] Improve CMake system and compiler checks

---
 cpp/CMakeLists.txt    | 6 +++---
 cpp/cmake/tests.cmake | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt
index c3be9beb..a64c97d9 100644
--- a/cpp/CMakeLists.txt
+++ b/cpp/CMakeLists.txt
@@ -177,7 +177,7 @@ set_target_properties(loot PROPERTIES
     CXX_STANDARD 17
     CXX_STANDARD_REQUIRED ON)
 
-if(CMAKE_SYSTEM_NAME STREQUAL "Windows")
+if(WIN32)
     target_compile_definitions(loot PRIVATE UNICODE _UNICODE LOOT_EXPORT)
 
     set(LOOT_LIBS ntdll ws2_32 bcrypt)
@@ -185,7 +185,7 @@ if(CMAKE_SYSTEM_NAME STREQUAL "Windows")
     target_link_libraries(loot PRIVATE ${LOOT_LIBS})
 endif()
 
-if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
+if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU" OR CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
     target_compile_options(loot PRIVATE
         "-Wall"
         "-Wextra"
@@ -367,7 +367,7 @@ if(NOT DEFINED CPACK_PACKAGE_VERSION)
     set(CPACK_PACKAGE_VERSION ${GIT_DESCRIBE_STRING})
 endif()
 
-if(CMAKE_SYSTEM_NAME STREQUAL "Windows")
+if(WIN32)
     set(CPACK_GENERATOR "7Z")
 else()
     set(CPACK_GENERATOR "TXZ")
diff --git a/cpp/cmake/tests.cmake b/cpp/cmake/tests.cmake
index cf3aa15a..6d91f995 100644
--- a/cpp/cmake/tests.cmake
+++ b/cpp/cmake/tests.cmake
@@ -93,7 +93,7 @@ set_target_properties(libloot_tests PROPERTIES
     CXX_STANDARD 17
     CXX_STANDARD_REQUIRED ON)
 
-if(CMAKE_SYSTEM_NAME STREQUAL "Windows")
+if(WIN32)
     target_compile_definitions(libloot_tests PRIVATE UNICODE _UNICODE)
 
     if((NOT CMAKE_HOST_SYSTEM_NAME STREQUAL "Windows") OR NOT LIBLOOT_BUILD_SHARED)
@@ -103,7 +103,7 @@ if(CMAKE_SYSTEM_NAME STREQUAL "Windows")
     target_link_libraries(libloot_tests PRIVATE ${LOOT_LIBS})
 endif()
 
-if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
+if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU" OR CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
     target_compile_options(libloot_tests PRIVATE "-Wall" "-Wextra")
 endif()