From 864299d3d58a637ad694c8e6d191acb0ed1192db Mon Sep 17 00:00:00 2001 From: Oliver Hamlet Date: Sun, 6 Mar 2016 09:05:26 +0000 Subject: [PATCH] Some misc. tidying up of editor-related code --- src/gui/html/elements/loot-plugin-card.html | 1 - src/gui/html/elements/loot-plugin-editor.html | 11 ++--------- src/gui/html/index.html | 1 + src/gui/html/js/events.js | 2 +- 4 files changed, 4 insertions(+), 11 deletions(-) diff --git a/src/gui/html/elements/loot-plugin-card.html b/src/gui/html/elements/loot-plugin-card.html index 5ae6c1ac..97c835ae 100644 --- a/src/gui/html/elements/loot-plugin-card.html +++ b/src/gui/html/elements/loot-plugin-card.html @@ -25,7 +25,6 @@ loot-clear-metadata - diff --git a/src/gui/html/elements/loot-plugin-editor.html b/src/gui/html/elements/loot-plugin-editor.html index 5caa7bc6..b5d26c4b 100644 --- a/src/gui/html/elements/loot-plugin-editor.html +++ b/src/gui/html/elements/loot-plugin-editor.html @@ -229,27 +229,20 @@ loot-editor-close attached() { this.$.accept.addEventListener('click', this._onHideEditor); this.$.cancel.addEventListener('click', this._onHideEditor); - this.$.tablePages.addEventListener('iron-deselect', this._onTablePageActivate); this.$.splitter.addEventListener('track', this._onSplitterDrag); }, detached() { this.$.accept.removeEventListener('click', this._onHideEditor); this.$.cancel.removeEventListener('click', this._onHideEditor); - this.$.tablePages.removeEventListener('iron-deselect', this._onTablePageActivate); this.$.splitter.removeEventListener('track', this._onSplitterDrag); }, - _onTablePageActivate() { - /* Notify that this editor (may have) changed size. */ - this.dispatchEvent(new CustomEvent('iron-resize', { bubbles: true })); - }, - _onSplitterDrag(evt) { if (evt.detail.state === 'start') { - this.parentNode.host.style.height = parseInt(window.getComputedStyle(this.parentNode.host).height) + 'px'; + this.parentNode.host.style.height = parseInt(window.getComputedStyle(this.parentNode.host).height, 10) + 'px'; } - this.parentNode.host.style.height = (parseInt(this.parentNode.host.style.height) - evt.detail.ddy) + 'px'; + this.parentNode.host.style.height = (parseInt(this.parentNode.host.style.height, 10) - evt.detail.ddy) + 'px'; }, _rowDataToMessage(rowData) { diff --git a/src/gui/html/index.html b/src/gui/html/index.html index 0c950355..ce053577 100644 --- a/src/gui/html/index.html +++ b/src/gui/html/index.html @@ -14,6 +14,7 @@ + diff --git a/src/gui/html/js/events.js b/src/gui/html/js/events.js index 61022883..d1c34de5 100644 --- a/src/gui/html/js/events.js +++ b/src/gui/html/js/events.js @@ -452,7 +452,7 @@ function onEditorClose(evt) { majority of the work to the C++ side of things. */ const plugin = loot.game.plugins.find((item) => { return item.name === evt.target.querySelector('h1').textContent; - }) + }); const edits = evt.target.readFromEditor(plugin); promise = loot.query('editorClosed', edits).then(JSON.parse).then((result) => { if (result) {