From 81ec1b5cd3c3131ca4b2c0ed32af161b409428bf Mon Sep 17 00:00:00 2001 From: Oliver Hamlet Date: Sat, 6 Feb 2021 09:42:42 +0000 Subject: [PATCH] Don't include SSH support when building libgit2 Windows CI builds are currently failing with the following error: -- Checking for module 'libssh2' -- Found libssh2, version 1.8.2 CMake Error at cmake/FindPkgLibraries.cmake:17 (MESSAGE): could not resolve ssh2 Call Stack (most recent call first): src/CMakeLists.txt:213 (FIND_PKGLIBRARIES) this is odd, but can be avoided by not building in SSH support. LOOT's masterlists are all downloaded over HTTPS, so this wouldn't break anything (unless there are people hosting their own masterlists that aren't accessible over HTTPS, but that's very unlikely). --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 5342869e..b3f6f20a 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -100,7 +100,7 @@ ENDIF () ExternalProject_Add(libgit2 PREFIX "external" URL "https://github.com/libgit2/libgit2/archive/v1.1.0.tar.gz" - CMAKE_ARGS -DBUILD_SHARED_LIBS=OFF -DBUILD_CLAR=OFF -DSTATIC_CRT=${MSVC_STATIC_RUNTIME} -DCMAKE_POSITION_INDEPENDENT_CODE=${CMAKE_POSITION_INDEPENDENT_CODE} -DREGEX_BACKEND=builtin + CMAKE_ARGS -DBUILD_SHARED_LIBS=OFF -DBUILD_CLAR=OFF -DUSE_SSH=OFF -DSTATIC_CRT=${MSVC_STATIC_RUNTIME} -DCMAKE_POSITION_INDEPENDENT_CODE=${CMAKE_POSITION_INDEPENDENT_CODE} -DREGEX_BACKEND=builtin BUILD_COMMAND ${CMAKE_COMMAND} --build . --target git2 --config $(CONFIGURATION) INSTALL_COMMAND "") ExternalProject_Get_Property(libgit2 SOURCE_DIR BINARY_DIR)