loot/libloot
0
0
Fork 0
mirror of https://github.com/loot/libloot.git synced 2026-07-27 14:16:01 -07:00
Code Issues Packages Projects Releases Wiki Activity

Allow loaded plugins to be retrieved using a .ghost extension

Browse Source 
libloot trims any .ghost extension from plugins it loads, so be consistent with that behaviour when getting or sorting plugins.
This commit is contained in:
Oliver Hamlet
2026-05-14 18:58:26 +01:00
parent 4410265e10
commit 7942083cd0
2 changed files with 45 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cpp/src/tests/api/interface/game_interface_test.h
+25 -3
View File
@@ -580,6 +580,23 @@ TEST_P(GameInterfaceTest,
EXPECT_NE(pointer1, pointer2);
}
TEST_P(GameInterfaceTest, getPluginShouldStripGhostExtension) {
if (GetParam() == GameType::openmw) {
return;
}
const auto ghostedName = std::string(BLANK_ESP) + ".ghost";
copyPlugin(BLANK_ESP, ghostedName);
handle_->LoadPlugins({BLANK_ESP}, true);
EXPECT_EQ(1, handle_->GetLoadedPlugins().size());
const auto plugin = handle_->GetPlugin(ghostedName);
ASSERT_NE(nullptr, plugin);
EXPECT_EQ(BLANK_ESP, plugin->GetName());
}
TEST_P(GameInterfaceTest,
getLoadedPluginsShouldReturnAnEmptySetIfNoneHaveBeenLoaded) {
EXPECT_TRUE(handle_->GetLoadedPlugins().empty());
@@ -666,14 +683,19 @@ TEST_P(GameInterfaceTest, sortPluginsShouldSupportGhostedPlugins) {
return;
}
const auto pluginName =
GetParam() == GameType::starfield ? BLANK_FULL_ESM : BLANK_ESM;
copyPlugin(pluginName);
copyPlugin(BLANK_ESP, "Blank.esp.ghost");
handle_->LoadPlugins({BLANK_ESP}, false);
handle_->LoadPlugins({pluginName, BLANK_ESP}, false);
const auto sortedOrder = handle_->SortPlugins(
{std::string(BLANK_ESP)});
{std::string(pluginName) + ".ghost", std::string(BLANK_ESP)});
std::vector<std::string> expectedOrder{std::string(BLANK_ESP)};
std::vector<std::string> expectedOrder{std::string(pluginName),
std::string(BLANK_ESP)};
EXPECT_EQ(expectedOrder, sortedOrder);
}