From 703317c94a6d3445b2bdb70d58183c7308d6945e Mon Sep 17 00:00:00 2001 From: Oliver Hamlet Date: Tue, 31 Jan 2017 22:50:54 +0000 Subject: [PATCH] Fix collections being passed by value --- src/gui/query/editor_closed_query.h | 2 +- src/gui/query/get_game_data_query.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gui/query/editor_closed_query.h b/src/gui/query/editor_closed_query.h index 7ff046fc..5a311726 100644 --- a/src/gui/query/editor_closed_query.h +++ b/src/gui/query/editor_closed_query.h @@ -148,7 +148,7 @@ private: return "null"; } - static std::vector toMessages(std::vector messages) { + static std::vector toMessages(const std::vector& messages) { std::vector list; for (const auto& message : messages) { diff --git a/src/gui/query/get_game_data_query.h b/src/gui/query/get_game_data_query.h index c21179eb..91e64297 100644 --- a/src/gui/query/get_game_data_query.h +++ b/src/gui/query/get_game_data_query.h @@ -67,7 +67,7 @@ public: } private: - static std::vector toEditorMessages(std::vector messages, const LanguageCode language) { + static std::vector toEditorMessages(const std::vector& messages, const LanguageCode language) { std::vector list; for (const auto& message : messages) { @@ -129,7 +129,7 @@ private: return pluginNode; } - std::string generateJsonResponse(std::vector> plugins) { + std::string generateJsonResponse(const std::vector>& plugins) { YAML::Node gameNode; // ID the game using its folder value.