loot/libloot
0
0
Fork 0
mirror of https://github.com/loot/libloot.git synced 2026-07-27 14:16:01 -07:00
Code Issues Packages Projects Releases Wiki Activity

Update GameInterface docs to reflect use of smart pointers

Browse Source
This commit is contained in:
Oliver Hamlet
2026-01-01 17:58:59 +00:00
parent 1a2baede8d
commit 6ca6a01fa9
2 changed files with 37 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cpp/src/tests/api/interface/game_interface_test.h
+32 -1
View File
@@ -336,6 +336,17 @@ TEST_P(GameInterfaceTest,
EXPECT_NE(pointer, newPointer);
}
TEST_P(GameInterfaceTest, loadPluginsShouldNotAffectExistingPluginPointers) {
handle_->LoadPlugins({std::filesystem::u8path(blankEsm)}, true);
const auto pointer = handle_->GetPlugin(blankEsm);
ASSERT_NE(nullptr, pointer);
handle_->LoadPlugins({std::filesystem::u8path(blankEsp)}, true);
const auto newPointer = handle_->GetPlugin(blankEsm);
EXPECT_EQ(pointer, newPointer);
}
TEST_P(GameInterfaceTest,
loadPluginsShouldThrowIfGivenVectorElementsWithTheSameFilename) {
const auto dataPluginPath = dataPath / std::filesystem::u8path(blankEsm);
@@ -522,10 +533,30 @@ TEST_P(GameInterfaceTest, getPluginThatIsNotCachedShouldReturnANullPointer) {
}
TEST_P(GameInterfaceTest,
gettingPluginsShouldReturnAnEmptySetIfNoneHaveBeenLoaded) {
getPluginReturnsTheSamePointerForConsecutiveCallsGivenTheSamePlugin) {
handle_->LoadPlugins({std::filesystem::u8path(blankEsm)}, true);
const auto pointer1 = handle_->GetPlugin(blankEsm);
const auto pointer2 = handle_->GetPlugin(blankEsm);
EXPECT_EQ(pointer1, pointer2);
}
TEST_P(GameInterfaceTest,
getLoadedPluginsShouldReturnAnEmptySetIfNoneHaveBeenLoaded) {
EXPECT_TRUE(handle_->GetLoadedPlugins().empty());
}
TEST_P(GameInterfaceTest,
getLoadedPluginReturnsTheSamePointersForConsecutiveCalls) {
handle_->LoadPlugins({std::filesystem::u8path(blankEsm)}, true);
const auto pointers1 = handle_->GetLoadedPlugins();
const auto pointers2 = handle_->GetLoadedPlugins();
EXPECT_EQ(pointers1, pointers2);
}
TEST_P(GameInterfaceTest, sortPluginsShouldSucceedIfPassedValidArguments) {
std::vector<std::string> expectedOrder;
if (GetParam() == GameType::starfield) {