From 5da599b84baf5b26fcff0bcab2c42f5c79545ff6 Mon Sep 17 00:00:00 2001 From: Oliver Hamlet Date: Thu, 15 Jan 2015 16:14:52 +0000 Subject: [PATCH] Misc. tidying. DRY when creating empty editable table rows, and remove a couple of unnecessary logging statements. --- resources/report/html/editable-table.html | 13 +------------ resources/report/html/loot-plugin-editor.html | 1 - resources/report/js/events.js | 1 - 3 files changed, 1 insertion(+), 14 deletions(-) diff --git a/resources/report/html/editable-table.html b/resources/report/html/editable-table.html index 8ed9c27d..f345e1c1 100644 --- a/resources/report/html/editable-table.html +++ b/resources/report/html/editable-table.html @@ -252,19 +252,8 @@ html /deep/ table[is=editable-table] paper-icon-button[icon=add]:hover { value: function(evt) { /* Create new row. */ var table = evt.currentTarget.parentElement.parentElement.parentElement.parentElement.parentElement; - var rowTemplateId = table.getAttribute('data-template'); - var content = document.querySelector('link[rel="import"][href$="editable-table.html"]'); - if (content) { - content = content.import.getElementById(rowTemplateId).content; - } else { - content = document.getElementById(rowTemplateId).content; - } - var row = document.importNode(content, true); - table.tBodies[0].insertBefore(row, table.tBodies[0].lastElementChild); - - /* Add deletion listener. */ - table.tBodies[0].lastElementChild.previousElementSibling.getElementsByClassName('delete')[0].addEventListener('click', table.onRemoveRow, false); + table.addRow({}); } }, diff --git a/resources/report/html/loot-plugin-editor.html b/resources/report/html/loot-plugin-editor.html index 19610fbf..8e1e25fd 100644 --- a/resources/report/html/loot-plugin-editor.html +++ b/resources/report/html/loot-plugin-editor.html @@ -368,7 +368,6 @@ loot-editor-close for (var i = 0; i < inputs.length; ++i) { if (!inputs[i].checkValidity()) { isValid = false; - console.log(inputs[i]); } } diff --git a/resources/report/js/events.js b/resources/report/js/events.js index 5b139234..9d536cb0 100644 --- a/resources/report/js/events.js +++ b/resources/report/js/events.js @@ -314,7 +314,6 @@ function areSettingsValid() { for (var i = 0; i < inputs.length; ++i) { if (!inputs[i].checkValidity()) { return false; - console.log(inputs[i]); } } return true;