From 4bfa4c9539fdf93b0478c4dfa5f48bb10c2a86e1 Mon Sep 17 00:00:00 2001 From: Oliver Hamlet Date: Tue, 30 Dec 2025 10:39:29 +0000 Subject: [PATCH] Don't error if metadata list contains duplicate known Bash Tags It's harmless to have duplicates, and the list is not documented to contain unique elements. --- src/metadata/metadata_document.rs | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/src/metadata/metadata_document.rs b/src/metadata/metadata_document.rs index 245ece56..80bc335e 100644 --- a/src/metadata/metadata_document.rs +++ b/src/metadata/metadata_document.rs @@ -167,7 +167,6 @@ impl MetadataDocument { .collect::, _>>()?; let mut bash_tags = Vec::new(); - let mut str_set = HashSet::new(); for bash_tag_yaml in get_slice_value(&doc, "bash_tags", YamlObjectType::MetadataDocument)? { let bash_tag: &str = match bash_tag_yaml.data.as_str() { Some(b) => b, @@ -181,17 +180,7 @@ impl MetadataDocument { } }; - if str_set.contains(bash_tag) { - return Err(ParseMetadataError::duplicate_entry( - bash_tag_yaml.span.start, - bash_tag.to_owned(), - YamlObjectType::BashTagsElement, - ) - .into()); - } - bash_tags.push(bash_tag.to_owned()); - str_set.insert(bash_tag); } let mut group_names = HashSet::new();